Re: [webkit-dev] Using ResourceTiming API for testing

2016-04-25 Thread Maciej Stachowiak

> On Apr 24, 2016, at 8:54 AM, Yoav Weiss  wrote:
> 
> Hey,
> 
> As part of implementing support for `` more tests are 
> needed to make sure resources are properly reused. The easiest way to test 
> that is using the ResourceTiming API, which is currently implemented behind 
> an off-by-default build-time flag.
> 
> Therefore, I'd like to move the implementation of ResourceTiming API to be 
> behind an off-by-default runtime flag, so I can use it in preload's layout 
> tests. (By adding an internal API that turns it on when needed)
> 
> Would that be OK with the project? Any reasons I shouldn't be doing that?

Seems good as long as it doesn't hurt performance or correctness when runtime 
disabled.

 - Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Using ResourceTiming API for testing

2016-04-24 Thread Yoav Weiss
Hey,

As part of implementing support for `` more tests are
needed to make sure resources are properly reused. The easiest way to test
that is using the ResourceTiming API, which is currently implemented behind
an off-by-default build-time flag.

Therefore, I'd like to move the implementation of ResourceTiming API to be
behind an off-by-default runtime flag, so I can use it in preload's layout
tests. (By adding an internal API that turns it on when needed)

Would that be OK with the project? Any reasons I shouldn't be doing that?

Thanks! :)
Yoav
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev