Re: [webkit-dev] Web Notifications update
Update: https://bugs.webkit.org/show_bug.cgi?id=80497 has a patch up. Would appreciate a once-over from port maintainers. It defines an additional variable, with values the same as that of ENABLE_NOTIFICATIONS. Jon On Mar 6, 2012, at 10:00 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 6, 2012, at 9:00 PM, Jon Lee wrote: Whoops, I forgot to mention this also: I would like to add a new ENABLE(LEGACY_NOTIFICATION_DEPRECATION) flag which allows ports to deprecate the legacy API. This saves us from the hazards of refactoring the code to use a different ENABLE flag for the legacy API, and allows ports to opt-in when they're ready. Does this sound good? It's thoughtful to do it that way, but I think we should stick with the standard approach of ENABLE flags enabling features, instead of disabling them. So ENABLE(LEGACY_NOTIFICATIONS) and we can default it to on for ports that already had ENABLE(NOTIFICATIONS) historically. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Web Notifications update
Hello all, We are still working on WG approval, but have submitted the proposal for changes to the notifications spec, based on our previous discussions. I hope we can get consensus and update the spec promptly. In the meantime I will begin to file bugs under https://bugs.webkit.org/show_bug.cgi?id=80472 to keep track of the work needed to bring the implementation up to spec. Also, I have patches for review, but will not commit them until we have reasonable agreement in the WG. The overall intent is to leave the current API alone, and to implement the API using Notification() rather than WebKitNotification(). I understand that Kentaro is working on modularizing notifications, but I don't see that work interfering that much. Any concerns? Jon ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Web Notifications update
Whoops, I forgot to mention this also: I would like to add a new ENABLE(LEGACY_NOTIFICATION_DEPRECATION) flag which allows ports to deprecate the legacy API. This saves us from the hazards of refactoring the code to use a different ENABLE flag for the legacy API, and allows ports to opt-in when they're ready. Does this sound good? Jon On Mar 6, 2012, at 7:09 PM, Jon Lee wrote: Hello all, We are still working on WG approval, but have submitted the proposal for changes to the notifications spec, based on our previous discussions. I hope we can get consensus and update the spec promptly. In the meantime I will begin to file bugs under https://bugs.webkit.org/show_bug.cgi?id=80472 to keep track of the work needed to bring the implementation up to spec. Also, I have patches for review, but will not commit them until we have reasonable agreement in the WG. The overall intent is to leave the current API alone, and to implement the API using Notification() rather than WebKitNotification(). I understand that Kentaro is working on modularizing notifications, but I don't see that work interfering that much. Any concerns? Jon ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Web Notifications update
On Mar 6, 2012, at 9:00 PM, Jon Lee wrote: Whoops, I forgot to mention this also: I would like to add a new ENABLE(LEGACY_NOTIFICATION_DEPRECATION) flag which allows ports to deprecate the legacy API. This saves us from the hazards of refactoring the code to use a different ENABLE flag for the legacy API, and allows ports to opt-in when they're ready. Does this sound good? It's thoughtful to do it that way, but I think we should stick with the standard approach of ENABLE flags enabling features, instead of disabling them. So ENABLE(LEGACY_NOTIFICATIONS) and we can default it to on for ports that already had ENABLE(NOTIFICATIONS) historically. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
