Re: [webkit-dev] WorkQueue for Windows?
On Sat, Mar 7, 2015 at 9:02 PM, Brent Fulgham bfulg...@gmail.com wrote: Hi Antti, Take a look at https://bugs.webkit.org/show_bug.cgi?id=142432. I haven't landed this yet, because I was hoping to get some kind of test for this. However, it seems to introduce no problems, so we could go ahead and land it. That was fast, thanks! Looks good as far as I can tell. Basic QOS support (thread priorities) would also be a useful addition at some point. I don't think there is any specific test coverage (though WorkQueue is used heavily in WK2). At least a basic unit test under Tools/TestWebKitAPI/Tests/WTF would be nice. Question: why do we have a separate WorkQueue implementation in DumpRenderTree *and* WebKitTestRunner? Seems like we could do some consolidation... This might be because the code used to live in WK2 and was only recently moved to WTF. It would indeed be good to get rid of the duplication. antti -Brent On Mar 6, 2015, at 10:55 AM, Anders Carlsson ander...@apple.com wrote: I think we used to have a WorkQueue implementation for Windows WK2 - anyone should be able to dig it up. (Alternatively, we can just make an implementation using std::thread). - Anders On Mar 6, 2015, at 10:46 AM, Antti Koivisto koivi...@iki.fi wrote: Hi, I'd like to start using WTF::WorkQueue abstraction in WebCore code. However we are currently missing a Windows implementation (WorkQueue used to be part of WK2). Anyone interested in making one? I assume it wouldn't be a difficult task for someone who knows the platform. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WorkQueue for Windows?
Hi Antti, Take a look at https://bugs.webkit.org/show_bug.cgi?id=142432. I haven't landed this yet, because I was hoping to get some kind of test for this. However, it seems to introduce no problems, so we could go ahead and land it. Question: why do we have a separate WorkQueue implementation in DumpRenderTree *and* WebKitTestRunner? Seems like we could do some consolidation... -Brent On Mar 6, 2015, at 10:55 AM, Anders Carlsson ander...@apple.com wrote: I think we used to have a WorkQueue implementation for Windows WK2 - anyone should be able to dig it up. (Alternatively, we can just make an implementation using std::thread). - Anders On Mar 6, 2015, at 10:46 AM, Antti Koivisto koivi...@iki.fi wrote: Hi, I'd like to start using WTF::WorkQueue abstraction in WebCore code. However we are currently missing a Windows implementation (WorkQueue used to be part of WK2). Anyone interested in making one? I assume it wouldn't be a difficult task for someone who knows the platform. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WorkQueue for Windows?
I think we used to have a WorkQueue implementation for Windows WK2 - anyone should be able to dig it up. (Alternatively, we can just make an implementation using std::thread). - Anders On Mar 6, 2015, at 10:46 AM, Antti Koivisto koivi...@iki.fi wrote: Hi, I'd like to start using WTF::WorkQueue abstraction in WebCore code. However we are currently missing a Windows implementation (WorkQueue used to be part of WK2). Anyone interested in making one? I assume it wouldn't be a difficult task for someone who knows the platform. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] WorkQueue for Windows?
Hi, I'd like to start using WTF::WorkQueue abstraction in WebCore code. However we are currently missing a Windows implementation (WorkQueue used to be part of WK2). Anyone interested in making one? I assume it wouldn't be a difficult task for someone who knows the platform. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
