[webkit-dev] no URL validation checking in KURLGoogle?

2011-11-11 Thread Huang, Deqing
Hi,

It seems that KURLGoogle is not validating url, it simply marks url as valid.

I tested an invalid url http://a a/ in Chrome, it tried to open it and failed.
In FireFox for this kind of url it will pop out a dialog saying The URL is not 
valid and cannot be loaded.

Should url be validated in KURLGoogle too? Or any concerns not adding it?

Thanks,
Deqing


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] no URL validation checking in KURLGoogle?

2011-11-11 Thread Brett Wilson
On Fri, Nov 11, 2011 at 12:29 AM, Huang, Deqing deqing.hu...@intel.com wrote:
 Hi,

 It seems that KURLGoogle is not validating url, it simply marks url as
 valid.

 I tested an invalid url http://a a/ in Chrome, it tried to open it and
 failed.
 In FireFox for this kind of url it will pop out a dialog saying The URL is
 not valid and cannot be loaded.

 Should url be validated in KURLGoogle too? Or any concerns not adding it?

This mailing list is not the correct place for this. If you think you
have a bug, you should file one.

I question why you think the problem is KURLGoogle and why you think
it is not validating the URL. If you step through the code for this
URL, you will find that this is not the case.

Brett
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev