Re: [webkit-dev] selecting text ignores mouse down position
And I fixed it in http://trac.webkit.org/changeset/81053.
Evan, was there a corresponding Chromium issue?
Best,
Ryosuke Niwa
Software Engineer
Google Inc.
On Fri, Mar 11, 2011 at 1:43 PM, Evan Martin wrote:
> For those following at home, this moved to
> https://bugs.webkit.org/show_bug.cgi?id=56213
>
> On Fri, Mar 11, 2011 at 11:39 AM, Ryosuke Niwa wrote:
> > I think this is a WebKit bug indeed. I've been annoyed by this bug quite
> > few times and have been trying to figure out the reason. Thanks for
> > spotting the root cause!
> > - Ryosuke
> >
> > On Fri, Mar 11, 2011 at 11:34 AM, Evan Martin wrote:
> >>
> >> The simple layout test below demonstrates that when you select text by
> >> clicking and dragging, we ignore the position of the initial mouse
> >> down and instead rely on mouse move events to judge what text is
> >> selected. I verified the behavior on Linux (Chrome) and Mac
> >> (non-Chrome).
> >>
> >> Is it expected that the platform sends a mouse move event at the
> >> position of the initial mouse down when dragging?
> >> Or is this a bug in WebKit? I'm trying to figure out which layer I
> >> should fix this at.
> >>
> >> I manually verified on Chrome Linux via some logging statements that
> >> if I move the mouse rapidly and drag, the mouse down position is
> >> sometimes a pixel away from the first mouse move event position.
> >>
> >> The first part of this text should be selected.
> >>
> >> if (window.eventSender) {
> >>var div = document.getElementById('text');
> >>var x = div.offsetLeft + 1;
> >>var y = div.offsetTop + 5;
> >>eventSender.mouseMoveTo(x, y);
> >>eventSender.mouseDown();
> >>
> >>// With this mouse move event, we select the initial range of text.
> >>// Without it, we don't -- we just get the caret positioned within
> the
> >> text.
> >>eventSender.mouseMoveTo(x, y);
> >>
> >>eventSender.mouseMoveTo(x + 50, y);
> >>eventSender.mouseUp();
> >> }
> >>
> >> ___
> >> webkit-dev mailing list
> >> webkit-dev@lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> >
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] selecting text ignores mouse down position
On Fri, Mar 11, 2011 at 01:43:25PM -0800, Evan Martin wrote: > For those following at home, this moved to > https://bugs.webkit.org/show_bug.cgi?id=56213 > Hi Evan, I've tried to fix this issue long time ago in this bug, feel free to dup it with your new bug as I did not spend time on the issue in a long time: https://bugs.webkit.org/show_bug.cgi?id=31711 HIH ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] selecting text ignores mouse down position
For those following at home, this moved to
https://bugs.webkit.org/show_bug.cgi?id=56213
On Fri, Mar 11, 2011 at 11:39 AM, Ryosuke Niwa wrote:
> I think this is a WebKit bug indeed. I've been annoyed by this bug quite
> few times and have been trying to figure out the reason. Thanks for
> spotting the root cause!
> - Ryosuke
>
> On Fri, Mar 11, 2011 at 11:34 AM, Evan Martin wrote:
>>
>> The simple layout test below demonstrates that when you select text by
>> clicking and dragging, we ignore the position of the initial mouse
>> down and instead rely on mouse move events to judge what text is
>> selected. I verified the behavior on Linux (Chrome) and Mac
>> (non-Chrome).
>>
>> Is it expected that the platform sends a mouse move event at the
>> position of the initial mouse down when dragging?
>> Or is this a bug in WebKit? I'm trying to figure out which layer I
>> should fix this at.
>>
>> I manually verified on Chrome Linux via some logging statements that
>> if I move the mouse rapidly and drag, the mouse down position is
>> sometimes a pixel away from the first mouse move event position.
>>
>> The first part of this text should be selected.
>>
>> if (window.eventSender) {
>> var div = document.getElementById('text');
>> var x = div.offsetLeft + 1;
>> var y = div.offsetTop + 5;
>> eventSender.mouseMoveTo(x, y);
>> eventSender.mouseDown();
>>
>> // With this mouse move event, we select the initial range of text.
>> // Without it, we don't -- we just get the caret positioned within the
>> text.
>> eventSender.mouseMoveTo(x, y);
>>
>> eventSender.mouseMoveTo(x + 50, y);
>> eventSender.mouseUp();
>> }
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] selecting text ignores mouse down position
I think this is a WebKit bug indeed. I've been annoyed by this bug quite
few times and have been trying to figure out the reason. Thanks for
spotting the root cause!
- Ryosuke
On Fri, Mar 11, 2011 at 11:34 AM, Evan Martin wrote:
> The simple layout test below demonstrates that when you select text by
> clicking and dragging, we ignore the position of the initial mouse
> down and instead rely on mouse move events to judge what text is
> selected. I verified the behavior on Linux (Chrome) and Mac
> (non-Chrome).
>
> Is it expected that the platform sends a mouse move event at the
> position of the initial mouse down when dragging?
> Or is this a bug in WebKit? I'm trying to figure out which layer I
> should fix this at.
>
> I manually verified on Chrome Linux via some logging statements that
> if I move the mouse rapidly and drag, the mouse down position is
> sometimes a pixel away from the first mouse move event position.
>
> The first part of this text should be selected.
>
> if (window.eventSender) {
>var div = document.getElementById('text');
>var x = div.offsetLeft + 1;
>var y = div.offsetTop + 5;
>eventSender.mouseMoveTo(x, y);
>eventSender.mouseDown();
>
>// With this mouse move event, we select the initial range of text.
>// Without it, we don't -- we just get the caret positioned within the
> text.
>eventSender.mouseMoveTo(x, y);
>
>eventSender.mouseMoveTo(x + 50, y);
>eventSender.mouseUp();
> }
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] selecting text ignores mouse down position
The simple layout test below demonstrates that when you select text by
clicking and dragging, we ignore the position of the initial mouse
down and instead rely on mouse move events to judge what text is
selected. I verified the behavior on Linux (Chrome) and Mac
(non-Chrome).
Is it expected that the platform sends a mouse move event at the
position of the initial mouse down when dragging?
Or is this a bug in WebKit? I'm trying to figure out which layer I
should fix this at.
I manually verified on Chrome Linux via some logging statements that
if I move the mouse rapidly and drag, the mouse down position is
sometimes a pixel away from the first mouse move event position.
The first part of this text should be selected.
if (window.eventSender) {
var div = document.getElementById('text');
var x = div.offsetLeft + 1;
var y = div.offsetTop + 5;
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
// With this mouse move event, we select the initial range of text.
// Without it, we don't -- we just get the caret positioned within the text.
eventSender.mouseMoveTo(x, y);
eventSender.mouseMoveTo(x + 50, y);
eventSender.mouseUp();
}
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
