Re: [webkit-dev] webkit-patch land behavior change

2022-04-27 Thread Jonathan Bedard via webkit-dev
For now, `webkit-patch land-unsafe` would be the answer.

In the future, new contributors would need an existing committer to add the 
`merge-queue` label to a PR which adds the new contributor to contributors.json

Jonathan

> On Apr 27, 2022, at 12:16 AM, Manuel Rego Casasnovas  wrote:
> 
> 
> 
> On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote:
>> As we move closer to transitioning away from Subversion, I’ve change 
>> ‘webkit-patch land’ to use commit-queue instead of directly committing a 
>> local change from a contributor’s machine 
>> (https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will 
>> allow contributors to directly land to Subversion for the time being, 
>> although after we transition to GitHub, will also use commit-queue and 
>> prefix “fast-cq” to uploaded patches to bypass building and testing.
> 
> If I remember correctly when you're accepted as committer you have to do
> a first manual commit adding you to the contributors.json file; and I
> guess people are using "webkit-patch land" for that (see example [1]).
> 
> Would the new contributors be able to land that first commit with the
> commit-queue behavior?
> 
> Cheers,
>  Rego
> 
> [1] https://bugs.webkit.org/show_bug.cgi?id=237634

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] webkit-patch land behavior change

2022-04-27 Thread Manuel Rego Casasnovas via webkit-dev


On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote:
> As we move closer to transitioning away from Subversion, I’ve change 
> ‘webkit-patch land’ to use commit-queue instead of directly committing a 
> local change from a contributor’s machine 
> (https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will 
> allow contributors to directly land to Subversion for the time being, 
> although after we transition to GitHub, will also use commit-queue and prefix 
> “fast-cq” to uploaded patches to bypass building and testing.

If I remember correctly when you're accepted as committer you have to do
a first manual commit adding you to the contributors.json file; and I
guess people are using "webkit-patch land" for that (see example [1]).

Would the new contributors be able to land that first commit with the
commit-queue behavior?

Cheers,
  Rego

[1] https://bugs.webkit.org/show_bug.cgi?id=237634
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] webkit-patch land behavior change

2022-04-26 Thread Jonathan Bedard via webkit-dev
Hey folks,

As we move closer to transitioning away from Subversion, I’ve change 
‘webkit-patch land’ to use commit-queue instead of directly committing a local 
change from a contributor’s machine 
(https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will 
allow contributors to directly land to Subversion for the time being, although 
after we transition to GitHub, will also use commit-queue and prefix “fast-cq” 
to uploaded patches to bypass building and testing.

Jonathan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev