Re: [webkit-dev] Bash scripts should support LF endings only

2012-02-24 Thread Peter Kasting
On Fri, Feb 24, 2012 at 11:13 AM, Ashod Nakashian
ashodnakash...@yahoo.comwrote:

 In short, the issue is that some bash scripts have their svn:eol-style set
 to native, which is CRLF on Windows. This is causing build failures on some
 version of cygwin-bash that don't like CR in the scripts.


I fixed a number of these cases in the past by doing precisely what you
suggested, and got r+ from aroben IIRC.

PK
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Bash scripts should support LF endings only

2012-02-24 Thread Ashod Nakashian
Thanks Peter, just submitted the patch[1] although I still don't see any 
property change related lines. I also added aroben to the cc list. Hope 
somebody will take it from here.

[1]: https://bugs.webkit.org/attachment.cgi?id=128849action=diffcontext=patchcollapsed=headers=1format=raw

-Ash


 From: Peter Kasting pkast...@chromium.org
To: Ashod Nakashian ashodnakash...@yahoo.com 
Cc: WebKit Development webkit-dev@lists.webkit.org 
Sent: Friday, February 24, 2012 11:20 PM
Subject: Re: [webkit-dev] Bash scripts should support LF endings only
 

On Fri, Feb 24, 2012 at 11:13 AM, Ashod Nakashian ashodnakash...@yahoo.com 
wrote:

In short, the issue is that some bash scripts have their svn:eol-style set to 
native, which is CRLF on Windows. This is causing build failures on some 
version of cygwin-bash that don't like CR in the scripts.

I fixed a number of these cases in the past by doing precisely what you 
suggested, and got r+ from aroben IIRC.

PK ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev