Re: [webkit-dev] chromium image tests on lion
On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.com wrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.org wrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
For those who want to follow along, I filed http://code.google.com/p/chromium/issues/detail?id=109637 for getting a Lion chromium bot running. On Mon, Jan 9, 2012 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.orgwrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
Thanks Ojan. There is an older issue for this that I went ahead and starred: http://code.google.com/p/chromium/issues/detail?id=101398 Thanks all for the replies. Cheers, Jarred On Mon, Jan 9, 2012 at 1:41 PM, Ojan Vafai o...@chromium.org wrote: For those who want to follow along, I filed http://code.google.com/p/chromium/issues/detail?id=109637 for getting a Lion chromium bot running. On Mon, Jan 9, 2012 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.orgwrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
This could have been me: http://trac.webkit.org/changeset/104351 Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
Here's a patch to fix the LayoutTestHelper: https://bugs.webkit.org/show_bug.cgi?id=75618, however, as you already noted, this doesn't help with the other issues -jochen On Sat, Jan 7, 2012 at 5:44 PM, Jarred Nicholls jar...@webkit.org wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
