[webkit-dev] JSObjectGetClass proposal

2016-07-21 Thread Danilo Cesar Lemes de Paula
Hello there,

So, when working on a javascript binding engine we faced the following
problem:
How to create a JSObjectRef as the same type as another one.

With SpiderMonkey, we could use JS_GetClass to get the JSObject's class,
and then use that JSClass to build the new object.
There's no such API on JavaScriptCore.

I'd heard some suggestions to workaround the issue with Set/Get privates
or prototypes, but it definitely didn't get the expected result.

So, I know the JSObjectRef API has been stable for a while, but I would
like to propose the inclusion of the following API in the public list of
jsc APIs.

* JSClassRef JSObjectGetClass(JSObjectRef obj).

I can see this API being used for:
 * Knowing if two objects are from the same class (by using
JSValueIsObjectOfClass)
 * Creating dynamic constructors using another JSObjectRef as reference
for the class.

I did submit a bug and a patch for it:
https://bugs.webkit.org/show_bug.cgi?id=160032

Would be lovely if a JSC engineer could drop some thoughts or maybe a
review there...

Thanks,

Danilo Cesar Lemes de Paula
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] High web process CPU usage

2016-07-21 Thread Myles C. Maxfield

>  I figured I'd `clearInterval` all the timers


I assume you also stopped all the setTimeout() timers and the 
requestAnimationFrame() timers too?

--Myles___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Request for comments on some bindings generator patches

2016-07-21 Thread Darin Adler
> On Jul 19, 2016, at 8:36 PM, Nikos Andronikos 
>  wrote:
> 
> https://bugs.webkit.org/show_bug.cgi?id=158830
> This patch stops the IDL preprocessor from looking for the IDL file at all, 
> and all is well.

What about “option 2” from this bug? Why aren’t we pursuing that? The IDL 
experts seem to prefer it.

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] On Mac and iOS ports, you may need to trigger clean rebuilds after r203337

2016-07-21 Thread Darin Adler
> On Jul 20, 2016, at 4:08 PM, Ryosuke Niwa  wrote:
> 
> It looks like the binding generator doesn't re-generate .cpp files when 
> CodeGeneratorJS.pm is modified even though that dependency is explicitly 
> expressed in DerivedSources.make.

Is that reproducible everywhere, or only on certain systems?

If reproducible, we should be able to track down and fix it using debug mode in 
make.

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] On Mac and iOS ports, you may need to trigger clean rebuilds after r203337

2016-07-21 Thread Brian Burg
It was reproducible for me, but I nuked my build directory and moved on.

Looking at the Makefile, it seems we don't prefix the bindings files with 
$(WEBCORE) so it might not even be looking at the right files.

Let's continue investigation here:

https://bugs.webkit.org/show_bug.cgi?id=160031

> On Jul 21, 2016, at 10:05 AM, Darin Adler  wrote:
> 
>> On Jul 20, 2016, at 4:08 PM, Ryosuke Niwa  wrote:
>> 
>> It looks like the binding generator doesn't re-generate .cpp files when 
>> CodeGeneratorJS.pm is modified even though that dependency is explicitly 
>> expressed in DerivedSources.make.
> 
> Is that reproducible everywhere, or only on certain systems?
> 
> If reproducible, we should be able to track down and fix it using debug mode 
> in make.
> 
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev