Re: [webkit-dev] OWNERS policy

2018-02-22 Thread Maciej Stachowiak 


> On Feb 21, 2018, at 11:06 PM, Carlos Garcia Campos  
> wrote:
> 
> El mié, 21-02-2018 a las 13:49 -0800, Ryosuke Niwa escribió:
>> If there was any confusion, WebKit2 Owner's policy is still active
>> and in effect.
> 
> And maybe it's time to get rid of it? I never liked the idea, but I
> have to admit it made sense at the time it was done. The WebKit2
> development was on fire and wk2 developers couldn't spend time dealing
> with build failures on other ports that would slow down the development
> pace. Nowadays, WebKit2 doesn't really exist, it's WebKit again, and
> the old WebKit is considered legacy. We no longer need a policy.
> Removing the policy doesn't mean not owners will do any kind of
> changes, I think we all know when to ask other developers for a second
> review or approval. The same we have always done in other components
> jsc, WebCore, WTF that don't have an owners policy.

Some of us at Apple have discussed changing it, but nothing to announce yet.

I do think we have problems with people reviewing things that they aren't fully 
qualified to review, but that happens throughout the whole tree. So that 
logically leads to the conclusion of either no OWNERS or OWNERS everywhere.

> 
>> In the case you aren't sure of the right reviewer, you can send a
>> bulk email to all of us. I get cc'ed on every WebKit bug with Mac
>> EWS/CQ failure, and as such, I ignore all WebKit bugs I'm cc'ed
>> unless the bug title is of my interest.
>> 
>> - R. Niwa
>> 
>> On Wed, Feb 21, 2018 at 1:27 PM, youenn fablet 
>> wrote:
>>> Hi Don,
>>> 
>>> I am not sure there is a well defined policy.
>>> If we want to continue with owners, it would indeed be good to make
>>> it clearer and more functional.
>>> 
>>> Here is my current understanding.
>>> The multi-process architecture is now well in place so things like
>>> updating IPC encoders/decoders might no longer require a dedicated
>>> owner scrutiny.
>>> Exposing the right WK2 APIs is more sensitive on the other hand.
>>> 
>>>   Y
>>> 
>>> Le mer. 21 févr. 2018 à 12:52,  a écrit :
 Hi WebKittens,
 
 As you know we're working on getting WinCairo running on modern
 WebKit. We're working through a backlog of patches we have to
 upstream and are sometimes running into issues where we can't
 find reviewers for our code.
 
 Here are some bugs with attachments that have been hanging out
 for over 5 days.
 
 https://bugs.webkit.org/show_bug.cgi?id=182870
 https://bugs.webkit.org/show_bug.cgi?id=182869
 https://bugs.webkit.org/show_bug.cgi?id=182751
 
 One thing we're unclear on is the OWNERS policy. The list itself
 is pretty small and has no guidance on who might be the right
 person(s) to assign a bug to when touching shared code. It feels
 like we're just guessing on reviewers which doesn't seem like it
 helps anything move along.
 
 There also seem to be commits that were reviewed by non-owners
 that are touching common code. We're not sure if unfamiliarity
 with Windows might prevent some owners from looking over a patch
 as we move further along in our implementation.
 
 Basically we'd like to get some clarification here so we can keep
 landing patches for modern WebKit on Windows.
 
 Thanks!
 Sony WebKit Team
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] OWNERS policy

2018-02-22 Thread Carlos Garcia Campos 
El jue, 22-02-2018 a las 00:19 -0800, Maciej Stachowiak escribió:
> > On Feb 21, 2018, at 11:06 PM, Carlos Garcia Campos  > .org> wrote:
> > 
> > El mié, 21-02-2018 a las 13:49 -0800, Ryosuke Niwa escribió:
> > > If there was any confusion, WebKit2 Owner's policy is still
> > > active
> > > and in effect.
> > 
> > And maybe it's time to get rid of it? I never liked the idea, but I
> > have to admit it made sense at the time it was done. The WebKit2
> > development was on fire and wk2 developers couldn't spend time
> > dealing
> > with build failures on other ports that would slow down the
> > development
> > pace. Nowadays, WebKit2 doesn't really exist, it's WebKit again,
> > and
> > the old WebKit is considered legacy. We no longer need a policy.
> > Removing the policy doesn't mean not owners will do any kind of
> > changes, I think we all know when to ask other developers for a
> > second
> > review or approval. The same we have always done in other
> > components
> > jsc, WebCore, WTF that don't have an owners policy.
> 
> Some of us at Apple have discussed changing it, but nothing to
> announce yet.
> 
> I do think we have problems with people reviewing things that they
> aren't fully qualified to review, but that happens throughout the
> whole tree. So that logically leads to the conclusion of either no
> OWNERS or OWNERS everywhere.

Well, I don't think the current owners policy is about being qualified
to review patches, because non-apple developer are not allowed to be
there. That would mean there aren't non-apple reviewers qualified to
review patches under WebKit directory. Who is better qualified than
Brian, Joe or me to review Automation patches? None of us are WebKit2
owners, though.

I don't think an owners policy would solve the problem of people
reviewing patches without being fully qualified. If we actually have a
problem with that, I guess they are very few cases, so we should be
able to handle them individually. We could simply rollout the offending
commit and discuss the situation with the reviewer in the reviewers
list. Common sense is the best policy here. If needed we could even set
a procedure to remove reviewer status to someone if we think he/she is
not behaving as expected by a WebKit reviewer.

> > 
> > > In the case you aren't sure of the right reviewer, you can send a
> > > bulk email to all of us. I get cc'ed on every WebKit bug with Mac
> > > EWS/CQ failure, and as such, I ignore all WebKit bugs I'm cc'ed
> > > unless the bug title is of my interest.
> > > 
> > > - R. Niwa
> > > 
> > > On Wed, Feb 21, 2018 at 1:27 PM, youenn fablet  > > >
> > > wrote:
> > > > Hi Don,
> > > > 
> > > > I am not sure there is a well defined policy.
> > > > If we want to continue with owners, it would indeed be good to
> > > > make
> > > > it clearer and more functional.
> > > > 
> > > > Here is my current understanding.
> > > > The multi-process architecture is now well in place so things
> > > > like
> > > > updating IPC encoders/decoders might no longer require a
> > > > dedicated
> > > > owner scrutiny.
> > > > Exposing the right WK2 APIs is more sensitive on the other
> > > > hand.
> > > > 
> > > >   Y
> > > > 
> > > > Le mer. 21 févr. 2018 à 12:52,  a écrit
> > > > :
> > > > > Hi WebKittens,
> > > > > 
> > > > > As you know we're working on getting WinCairo running on
> > > > > modern
> > > > > WebKit. We're working through a backlog of patches we have to
> > > > > upstream and are sometimes running into issues where we can't
> > > > > find reviewers for our code.
> > > > > 
> > > > > Here are some bugs with attachments that have been hanging
> > > > > out
> > > > > for over 5 days.
> > > > > 
> > > > > https://bugs.webkit.org/show_bug.cgi?id=182870
> > > > > https://bugs.webkit.org/show_bug.cgi?id=182869
> > > > > https://bugs.webkit.org/show_bug.cgi?id=182751
> > > > > 
> > > > > One thing we're unclear on is the OWNERS policy. The list
> > > > > itself
> > > > > is pretty small and has no guidance on who might be the right
> > > > > person(s) to assign a bug to when touching shared code. It
> > > > > feels
> > > > > like we're just guessing on reviewers which doesn't seem like
> > > > > it
> > > > > helps anything move along.
> > > > > 
> > > > > There also seem to be commits that were reviewed by non-
> > > > > owners
> > > > > that are touching common code. We're not sure if
> > > > > unfamiliarity
> > > > > with Windows might prevent some owners from looking over a
> > > > > patch
> > > > > as we move further along in our implementation.
> > > > > 
> > > > > Basically we'd like to get some clarification here so we can
> > > > > keep
> > > > > landing patches for modern WebKit on Windows.
> > > > > 
> > > > > Thanks!
> > > > > Sony WebKit Team
> > > > > ___
> > > > > webkit-dev mailing list
> > > > > webkit-dev@lists.webkit.org
> > > > >