Re: [libreoffice-website] Re: Call for Feedback - Maps

2019-06-21 Thread Mike Saunders
Hi Jean,

On 19/06/2019 17:00, Jean Spiteri wrote:
>> For example, is the entry popup good or should the picture be on the left
> and text on the
> right (ID card style)? Also picture should be square or rectangle? That
> sort of things.

I think the layout is fine, but make the picture width 100 or 150, and
remove the hight element (otherwise it forces all pictures to be a
certain ratio, which doesn't work). In my map here:

https://www.libreoffice.org/assets/Uploads/contributor-map.html

...I specify a width of 100, but no height, so the browser does that
automatically.

Also, I would suggest a preset zoom level. If you see my map, it shows
almost all land on the world (except for some parts right on the edges).
The code that does it in my map is:

var mymap = L.map('mapid').setView([28.505, 16.09], 13);

Cheers,
Mike

-- 
To unsubscribe e-mail to: website+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/website/
Privacy Policy: https://www.documentfoundation.org/privacy


Re: [libreoffice-website] Re: Call for Feedback - Maps

2019-06-19 Thread Jean Spiteri
Hi Mike, thank you for the feedback and for testing it out. I'll continue
replying inline.

On Wed, Jun 19, 2019 at 4:07 PM Mike Saunders <
mike.saund...@documentfoundation.org> wrote:

> Hi Jean,
>
> Thanks a lot for your work on this -- and to William for his feedback! I
> see you've already fixed a couple of things; here's my feedback:
> > William Gathoye wrote
> >>  2. The date is the date until which we want to appear, not the date
> >> when we started contributing to LibreOffice. "Date" alone is not
> >> meaningful.
> >
> > The Date field is intended for the events map type of map. As explained
> > better below, the  test map is accommodating 2 scenarios, contributor and
> > events map. When you see it in the aspect of an events map, Date makes
> > sense. When in contributors "mode", Date will not be visible but will be
> set
> > automatically to 1 year from verification (to be extended by the user
> > through email if he wants).
>
> I would prefer 2+ years, or even more. Some people come and go in the
> project, so it's good for a map to show how diverse and worldwide the
> community is, even if it includes people who haven't directly been
> active in the last 12 months.
>

This is a mteer of opinion. I would prefer to have more feedback before
changing
the code. Anyway, it could also be to be allow changes by the CMS admin.


>
> Meanwhile, I had an issue with the image:
>
> https://i.imgur.com/8rptehC.png
>
> This is on https://newdesign.libreoffice.org/community/maps/ -- the
> "Buzea Bogdan" entry for Romania. It seems the link URL and image have
> both been shortened somewhere on the way... Is that fixable?
>

Yes, it is fixable and it has been fixed! I have changed the URL of that
entry to the
blog post's address. I have also set the Picture URL as that of the blog's
TDF logo
since I do not know what was your intention there. I have done the changes
through
editing from the CMS. The issue was a too short URL field.


>
> Otherwise, it's looking really good -- let's test it a bit more, and
> then look at rolling it out, if there are no other issues!
>

Of course, it's open for testing. I intend to do some other work
specifically around the
map's sizing and zoom and other UX stuff so any special UX feedback would
be welcome.
For example, is the entry popup good or should the picture be on the left
and text on the
right (ID card style)? Also picture should be square or rectangle? That
sort of things.


>
> Cheers,
> Mike
>

-- 
To unsubscribe e-mail to: website+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/website/
Privacy Policy: https://www.documentfoundation.org/privacy


Re: [libreoffice-website] Re: Call for Feedback - Maps

2019-06-19 Thread Mike Saunders
Hi Jean,

Thanks a lot for your work on this -- and to William for his feedback! I
see you've already fixed a couple of things; here's my feedback:
> William Gathoye wrote
>>  2. The date is the date until which we want to appear, not the date
>> when we started contributing to LibreOffice. "Date" alone is not
>> meaningful.
> 
> The Date field is intended for the events map type of map. As explained
> better below, the  test map is accommodating 2 scenarios, contributor and
> events map. When you see it in the aspect of an events map, Date makes
> sense. When in contributors "mode", Date will not be visible but will be set
> automatically to 1 year from verification (to be extended by the user
> through email if he wants). 

I would prefer 2+ years, or even more. Some people come and go in the
project, so it's good for a map to show how diverse and worldwide the
community is, even if it includes people who haven't directly been
active in the last 12 months.

Meanwhile, I had an issue with the image:

https://i.imgur.com/8rptehC.png

This is on https://newdesign.libreoffice.org/community/maps/ -- the
"Buzea Bogdan" entry for Romania. It seems the link URL and image have
both been shortened somewhere on the way... Is that fixable?

Otherwise, it's looking really good -- let's test it a bit more, and
then look at rolling it out, if there are no other issues!

Cheers,
Mike

-- 
To unsubscribe e-mail to: website+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/website/
Privacy Policy: https://www.documentfoundation.org/privacy


[libreoffice-website] Re: Call for Feedback - Maps

2019-06-10 Thread Jean Spiteri
Hello William, thank you for your interest and help with identifying these
possible issues and apologies for the late reply. I will reply to your
feedback inline. 

For others, feedback is still highly appreciated. 


William Gathoye wrote
> Hello Jean,
> 
> A few issues I saw when testing the implementation:
> 
>  1. The date format is not precised when comes the time of inserting our
> data. I had to guess it from the error message appearing after
> having inserted the data.

I have added more information at the field name. This is temporary. In the
future, the extra bits should be replaced by a tooltip. 

William Gathoye wrote
>  2. The date is the date until which we want to appear, not the date
> when we started contributing to LibreOffice. "Date" alone is not
> meaningful.

The Date field is intended for the events map type of map. As explained
better below, the  test map is accommodating 2 scenarios, contributor and
events map. When you see it in the aspect of an events map, Date makes
sense. When in contributors "mode", Date will not be visible but will be set
automatically to 1 year from verification (to be extended by the user
through email if he wants). 

William Gathoye wrote
>  3. If an issue occurs, the popups is discarded. We need to click the
> "Add" button again to make the popup appear again and see our error
> message.

Thanks for the suggestion. This should now be fixed. 

William Gathoye wrote
>  4. There is no GDPR indication about how the email address will  be
> used. I had to guess it after I added my data to realize it is just
> needed for validation.

I have added more information about this. As I've said before, the text will
find its way in a tool tip in a future development. 

William Gathoye wrote
>  5. Anyone with the email address can edit the POI even if the POI
> doesn't belong to him/her.

I assume that you have not accessed the full editing experience due to the
bug you mentioned below. When you enter the email address to request edit,
you get sent an email with a URL. Only from that URL will you be able to
edit your entry. That's another reason why an email address is required. 

William Gathoye wrote
>  6. Editing didn't work for me. It leads to a 404 page.

This should now be fixed. It was the result of an "unrefreshed" cache on the
server. I have rechecked both editing scenarios and they should work. 

William Gathoye wrote
>  7. When I have several locations added. Each of them is listed under
> the same name and I don't know which one I'm editing.

Please remember that the current page is a little outside of the norm to
test the most things possible. In reality, the map can be used both as a
Contributor Maps and also Events Map. Thus, while what you say is strictly
true, the ability to have multiple listings for one email address is
expected to be used for events which do not have the same name normally. 

William Gathoye wrote
>  8. Please remove the float:left statement in the #ContributorMap and
> add margin: 0.

Thanks for the idea. I have applied it. 
 
William Gathoye wrote
>  9. Buttons need to be properly positioned. Call to action "Add" at the
> far right. Edit at the far left.
> 10. Avoid the popup.

While saying that I have no particular Design and UX experience, I think
these two are subjective. Thus, I would like to have more feedback about
them. 

William Gathoye wrote
> 11. When the website will be deployed, with all the contributors we
> have, the whole world will be covered by POI. POI should only appear
> when zooming in a specific region.

I think having a full map would be the best case scenario and that a full
map would be a benefit if it is loaded at first load so I don't agree with
this. 

William Gathoye wrote
> If you need help, feel free to ping me/give me access to the dev website.

Thanks for your offer. 

William Gathoye wrote
> Regards,
> 
> -- 
> William Gathoye
> 

> william@

> 
> 
> 
> -- 
> To unsubscribe e-mail to: 

> website+unsubscribe@.libreoffice

> Problems?
> https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
> List archive: https://listarchives.libreoffice.org/global/website/
> Privacy Policy: https://www.documentfoundation.org/privacy





--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Website-f1644957.html

-- 
To unsubscribe e-mail to: website+unsubscr...@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/website/
Privacy Policy: https://www.documentfoundation.org/privacy