Re: [weld-dev] CDI JavaSE tck

2017-10-17 Thread Martin Kouba
Dne 17.10.2017 v 16:01 Emily Jiang napsal(a):
> Back to my original question, TestGroups.SE is not supposed to be run by 
> an application server such as Wildfly, Glassfish, Liberty, right?

Yes.

> For certifying EE8, these tests are supposed to be excluded by JavaEE 
> runtimes?

Yes. A Java EE runtime TCK runner should not include the tests from this 
group.

> Are these tests only for JavaSE runtime such as Hammock?

TestGroups.SE is supposed to be run by a CDI implementation itself.

> 
> Many thanks,
> Emily
> ===
> Emily Jiang
> WebSphere Application Server, CDI & MicroProfile Development Lead
> 
> MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
> Phone:  +44 (0)1962 816278  Internal: 246278
> 
> Email: emiji...@uk.ibm.com
> Lotus Notes: Emily Jiang/UK/IBM@IBMGB
> 
> 
> 
> 
> From: Matej Novotny 
> To: Martin Kouba 
> Cc: "John D. Ament" , Emily Jiang 
> , Weld 
> Date: 17/10/2017 14:17
> Subject: Re: [weld-dev] CDI JavaSE tck
> 
> 
> 
> 
> Sorry for later answer, yea the only TCK test is the one which Martin 
> pointed to.
> However, I don't see much need to cover this particular case on EE part.
> The section of the spec which defines throwing ISE with multiple 
> providers belongs to SE part of the spec, so it feel natural that it's 
> tested there.
> 
> Though if you feel like we should have even EE test then by all means 
> feel free to create JIRA ticket for this and I'll eventually get to it.
> 
> Matej
> 
> - Original Message -
>  > From: "Martin Kouba" 
>  > To: "John D. Ament" , "Emily Jiang" 
> , "Weld" 
>  > Sent: Tuesday, October 17, 2017 8:53:26 AM
>  > Subject: Re: [weld-dev] CDI JavaSE tck
>  >
>  > Dne 16.10.2017 v 20:30 John D. Ament napsal(a):
>  > >
>  > >
>  > > On Mon, Oct 16, 2017 at 2:07 PM Martin Kouba   > > > wrote:
>  > >
>  > >     Hi Emily,
>  > >
>  > >     tests from TestGroups.SE should NOT be run in a Java EE 
> environment.
>  > >     Note that CDI Bootstrap API should not even work in a Java EE 
> container
>  > >     (SeContainerInitializer.newInstance() should throw
>  > >     IllegalStateException).
>  > >
>  > >
>  > > Isn't there a TCK test for that?
>  >
>  > I think not. There is a test in CDI API which verifies that
>  > IllegalStateException is thrown if none or multiple service providers
>  > are found [1]. But it's actually a good idea to create a new TCK test
>  > with TestGroups.INTEGRATION group to verify ISE is thrown in a Java EE
>  > container.
>  >
>  > M
>  >
>  > [1]
>  > 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cdi-2Dspec_cdi_blob_master_api_src_test_java_org_jboss_cdi_api_test_se_SeContainerInitializerTest.java=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=jt2y5_gH2oPaja8Vt6NzAZV-iEo6D2jiWeuVYs0H-1U=I-wCdin9dELdurPsIgviW7msB3rHLauyQkEtuCi92lY=a27X8Pl3e9WrQ7pr8wED7YuL4Jst6Px1uEBdmCUhxGg=
>  >
>  > >
>  > >
>  > >     Martin
>  > >
>  > >     Dne 16.10.2017 v 14:33 Emily Jiang napsal(a):
>  > >      > Hi Matej/Martin,
>  > >      >
>  > >      > I am looking at the CDI 2.0 tck on JavaSE. I saw they are 
> under the
>  > >      > groups of "SE". Should the tcks be exercised by JavaEE 
> runtime, e.g.
>  > >      > wildfly, glassfish, Liberty etc? Which profile did you 
> package the
>  > >      > JavaSE tck?
>  > >      >
>  > >      >
>  > >      > Many thanks,
>  > >      > Emily
>  > >      > ===
>  > >      > Emily Jiang
>  > >      > WebSphere Application Server, CDI & MicroProfile Development 
> Lead
>  > >      >
>  > >      > MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
>  > >      > Phone: +44 (0)1962 816278   Internal:
>  > >      > 246278
>  > >      >
>  > >      > Email: emiji...@uk.ibm.com 
>  > >      > Lotus Notes: Emily Jiang/UK/IBM@IBMGB
>  > >      >
>  > >      >
>  > >      > Unless stated otherwise above:
>  > >      > IBM United Kingdom Limited - Registered in England and Wales 
> with
>  > >     number
>  > >      > 741598.
>  > >      > Registered office: PO Box 41, North Harbour, Portsmouth,
>  > >     Hampshire PO6 3AU
>  > >      >
>  > >      >
>  > >      > ___
>  > >      > weld-dev mailing list
>  > >      > weld-dev@lists.jboss.org 
>  > >      > 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=jt2y5_gH2oPaja8Vt6NzAZV-iEo6D2jiWeuVYs0H-1U=I-wCdin9dELdurPsIgviW7msB3rHLauyQkEtuCi92lY=K9UrTNcmNV9c0fHxKjz3lv1vmZaVoutqhQam-ceyOoU=
>  > >      >
>  > >
>  > >     --
>  > >     Martin Kouba
>  > >     Senior 

Re: [weld-dev] CDI JavaSE tck

2017-10-17 Thread Emily Jiang
Back to my original question, TestGroups.SE is not supposed to be run by 
an application server such as Wildfly, Glassfish, Liberty, right? For 
certifying EE8, these tests are supposed to be excluded by JavaEE 
runtimes? Are these tests only for JavaSE runtime such as Hammock?

Many thanks,
Emily
===
Emily Jiang
WebSphere Application Server, CDI & MicroProfile Development Lead
 
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
Phone:  +44 (0)1962 816278  Internal: 246278

Email: emiji...@uk.ibm.com 
Lotus Notes: Emily Jiang/UK/IBM@IBMGB




From:   Matej Novotny 
To: Martin Kouba 
Cc: "John D. Ament" , Emily Jiang 
, Weld 
Date:   17/10/2017 14:17
Subject:Re: [weld-dev] CDI JavaSE tck



Sorry for later answer, yea the only TCK test is the one which Martin 
pointed to.
However, I don't see much need to cover this particular case on EE part.
The section of the spec which defines throwing ISE with multiple providers 
belongs to SE part of the spec, so it feel natural that it's tested there.

Though if you feel like we should have even EE test then by all means feel 
free to create JIRA ticket for this and I'll eventually get to it.

Matej

- Original Message -
> From: "Martin Kouba" 
> To: "John D. Ament" , "Emily Jiang" 
, "Weld" 
> Sent: Tuesday, October 17, 2017 8:53:26 AM
> Subject: Re: [weld-dev] CDI JavaSE tck
> 
> Dne 16.10.2017 v 20:30 John D. Ament napsal(a):
> > 
> > 
> > On Mon, Oct 16, 2017 at 2:07 PM Martin Kouba  > > wrote:
> > 
> > Hi Emily,
> > 
> > tests from TestGroups.SE should NOT be run in a Java EE 
environment.
> > Note that CDI Bootstrap API should not even work in a Java EE 
container
> > (SeContainerInitializer.newInstance() should throw
> > IllegalStateException).
> > 
> > 
> > Isn't there a TCK test for that?
> 
> I think not. There is a test in CDI API which verifies that
> IllegalStateException is thrown if none or multiple service providers
> are found [1]. But it's actually a good idea to create a new TCK test
> with TestGroups.INTEGRATION group to verify ISE is thrown in a Java EE
> container.
> 
> M
> 
> [1]
> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cdi-2Dspec_cdi_blob_master_api_src_test_java_org_jboss_cdi_api_test_se_SeContainerInitializerTest.java=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=jt2y5_gH2oPaja8Vt6NzAZV-iEo6D2jiWeuVYs0H-1U=I-wCdin9dELdurPsIgviW7msB3rHLauyQkEtuCi92lY=a27X8Pl3e9WrQ7pr8wED7YuL4Jst6Px1uEBdmCUhxGg=

> 
> > 
> > 
> > Martin
> > 
> > Dne 16.10.2017 v 14:33 Emily Jiang napsal(a):
> >  > Hi Matej/Martin,
> >  >
> >  > I am looking at the CDI 2.0 tck on JavaSE. I saw they are under 
the
> >  > groups of "SE". Should the tcks be exercised by JavaEE runtime, 
e.g.
> >  > wildfly, glassfish, Liberty etc? Which profile did you package 
the
> >  > JavaSE tck?
> >  >
> >  >
> >  > Many thanks,
> >  > Emily
> >  > ===
> >  > Emily Jiang
> >  > WebSphere Application Server, CDI & MicroProfile Development 
Lead
> >  >
> >  > MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
> >  > Phone: +44 (0)1962 816278   Internal:
> >  > 246278
> >  >
> >  > Email: emiji...@uk.ibm.com 
> >  > Lotus Notes: Emily Jiang/UK/IBM@IBMGB
> >  >
> >  >
> >  > Unless stated otherwise above:
> >  > IBM United Kingdom Limited - Registered in England and Wales 
with
> > number
> >  > 741598.
> >  > Registered office: PO Box 41, North Harbour, Portsmouth,
> > Hampshire PO6 3AU
> >  >
> >  >
> >  > ___
> >  > weld-dev mailing list
> >  > weld-dev@lists.jboss.org 
> >  > 
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=jt2y5_gH2oPaja8Vt6NzAZV-iEo6D2jiWeuVYs0H-1U=I-wCdin9dELdurPsIgviW7msB3rHLauyQkEtuCi92lY=K9UrTNcmNV9c0fHxKjz3lv1vmZaVoutqhQam-ceyOoU=

> >  >
> > 
> > --
> > Martin Kouba
> > Senior Software Engineer
> > Red Hat, Czech Republic
> > ___
> > weld-dev mailing list
> > weld-dev@lists.jboss.org 
> > 
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev=DwIFaQ=jf_iaSHvJObTbx-siA1ZOg=jt2y5_gH2oPaja8Vt6NzAZV-iEo6D2jiWeuVYs0H-1U=I-wCdin9dELdurPsIgviW7msB3rHLauyQkEtuCi92lY=K9UrTNcmNV9c0fHxKjz3lv1vmZaVoutqhQam-ceyOoU=

> > 
> 
> --
> Martin Kouba
> Senior Software Engineer
> Red Hat, Czech Republic
> 

Re: [weld-dev] CDI JavaSE tck

2017-10-17 Thread Matej Novotny
Sorry for later answer, yea the only TCK test is the one which Martin pointed 
to.
However, I don't see much need to cover this particular case on EE part.
The section of the spec which defines throwing ISE with multiple providers 
belongs to SE part of the spec, so it feel natural that it's tested there.

Though if you feel like we should have even EE test then by all means feel free 
to create JIRA ticket for this and I'll eventually get to it.

Matej

- Original Message -
> From: "Martin Kouba" 
> To: "John D. Ament" , "Emily Jiang" 
> , "Weld" 
> Sent: Tuesday, October 17, 2017 8:53:26 AM
> Subject: Re: [weld-dev] CDI JavaSE tck
> 
> Dne 16.10.2017 v 20:30 John D. Ament napsal(a):
> > 
> > 
> > On Mon, Oct 16, 2017 at 2:07 PM Martin Kouba  > > wrote:
> > 
> > Hi Emily,
> > 
> > tests from TestGroups.SE should NOT be run in a Java EE environment.
> > Note that CDI Bootstrap API should not even work in a Java EE container
> > (SeContainerInitializer.newInstance() should throw
> > IllegalStateException).
> > 
> > 
> > Isn't there a TCK test for that?
> 
> I think not. There is a test in CDI API which verifies that
> IllegalStateException is thrown if none or multiple service providers
> are found [1]. But it's actually a good idea to create a new TCK test
> with TestGroups.INTEGRATION group to verify ISE is thrown in a Java EE
> container.
> 
> M
> 
> [1]
> https://github.com/cdi-spec/cdi/blob/master/api/src/test/java/org/jboss/cdi/api/test/se/SeContainerInitializerTest.java
> 
> > 
> > 
> > Martin
> > 
> > Dne 16.10.2017 v 14:33 Emily Jiang napsal(a):
> >  > Hi Matej/Martin,
> >  >
> >  > I am looking at the CDI 2.0 tck on JavaSE. I saw they are under the
> >  > groups of "SE". Should the tcks be exercised by JavaEE runtime, e.g.
> >  > wildfly, glassfish, Liberty etc? Which profile did you package the
> >  > JavaSE tck?
> >  >
> >  >
> >  > Many thanks,
> >  > Emily
> >  > ===
> >  > Emily Jiang
> >  > WebSphere Application Server, CDI & MicroProfile Development Lead
> >  >
> >  > MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
> >  > Phone: +44 (0)1962 816278   Internal:
> >  > 246278
> >  >
> >  > Email: emiji...@uk.ibm.com 
> >  > Lotus Notes: Emily Jiang/UK/IBM@IBMGB
> >  >
> >  >
> >  > Unless stated otherwise above:
> >  > IBM United Kingdom Limited - Registered in England and Wales with
> > number
> >  > 741598.
> >  > Registered office: PO Box 41, North Harbour, Portsmouth,
> > Hampshire PO6 3AU
> >  >
> >  >
> >  > ___
> >  > weld-dev mailing list
> >  > weld-dev@lists.jboss.org 
> >  > https://lists.jboss.org/mailman/listinfo/weld-dev
> >  >
> > 
> > --
> > Martin Kouba
> > Senior Software Engineer
> > Red Hat, Czech Republic
> > ___
> > weld-dev mailing list
> > weld-dev@lists.jboss.org 
> > https://lists.jboss.org/mailman/listinfo/weld-dev
> > 
> 
> --
> Martin Kouba
> Senior Software Engineer
> Red Hat, Czech Republic
> ___
> weld-dev mailing list
> weld-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/weld-dev

___
weld-dev mailing list
weld-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-dev

Re: [weld-dev] CDI JavaSE tck

2017-10-17 Thread Martin Kouba
Dne 16.10.2017 v 20:30 John D. Ament napsal(a):
> 
> 
> On Mon, Oct 16, 2017 at 2:07 PM Martin Kouba  > wrote:
> 
> Hi Emily,
> 
> tests from TestGroups.SE should NOT be run in a Java EE environment.
> Note that CDI Bootstrap API should not even work in a Java EE container
> (SeContainerInitializer.newInstance() should throw
> IllegalStateException).
> 
> 
> Isn't there a TCK test for that?

I think not. There is a test in CDI API which verifies that 
IllegalStateException is thrown if none or multiple service providers 
are found [1]. But it's actually a good idea to create a new TCK test 
with TestGroups.INTEGRATION group to verify ISE is thrown in a Java EE 
container.

M

[1]
https://github.com/cdi-spec/cdi/blob/master/api/src/test/java/org/jboss/cdi/api/test/se/SeContainerInitializerTest.java

> 
> 
> Martin
> 
> Dne 16.10.2017 v 14:33 Emily Jiang napsal(a):
>  > Hi Matej/Martin,
>  >
>  > I am looking at the CDI 2.0 tck on JavaSE. I saw they are under the
>  > groups of "SE". Should the tcks be exercised by JavaEE runtime, e.g.
>  > wildfly, glassfish, Liberty etc? Which profile did you package the
>  > JavaSE tck?
>  >
>  >
>  > Many thanks,
>  > Emily
>  > ===
>  > Emily Jiang
>  > WebSphere Application Server, CDI & MicroProfile Development Lead
>  >
>  > MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
>  > Phone: +44 (0)1962 816278   Internal: 246278
>  >
>  > Email: emiji...@uk.ibm.com 
>  > Lotus Notes: Emily Jiang/UK/IBM@IBMGB
>  >
>  >
>  > Unless stated otherwise above:
>  > IBM United Kingdom Limited - Registered in England and Wales with
> number
>  > 741598.
>  > Registered office: PO Box 41, North Harbour, Portsmouth,
> Hampshire PO6 3AU
>  >
>  >
>  > ___
>  > weld-dev mailing list
>  > weld-dev@lists.jboss.org 
>  > https://lists.jboss.org/mailman/listinfo/weld-dev
>  >
> 
> --
> Martin Kouba
> Senior Software Engineer
> Red Hat, Czech Republic
> ___
> weld-dev mailing list
> weld-dev@lists.jboss.org 
> https://lists.jboss.org/mailman/listinfo/weld-dev
> 

-- 
Martin Kouba
Senior Software Engineer
Red Hat, Czech Republic
___
weld-dev mailing list
weld-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-dev