[weld-issues] [JBoss JIRA] (WELD-2387) BeanConfigurator.addBean without specified callback blows with NPE
Title: Message Title Martin Kouba updated WELD-2387 Weld / WELD-2387 BeanConfigurator.addBean without specified callback blows with NPE Change By: Martin Kouba Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title
Benjamin Confino commented on WELD-2381
Re: Set web application classloader as TCCL when calling observers
Well, it should work.
I just tested it by adding the following line to one of the BeforeBeanDiscovery observers
Class.forName("com.ibm.test.deltaspiketccl.wara.base.TestServlet", true, Thread.currentThread().getContextClassLoader());
When I installed the ear file on WildFly I got a ClassNotFound exception. While it is true that EE.8.2.5 says that I should have a catch block that makes a second attempt to load the Class without mentioning the TCCL. I'm not sure that this means that the requirement mentioned in EE.6.2.3.7, that the TCCL can load classes is lifted. It seems to me that the correct interpretation of the two sections in combinations is that class loading using the TCCL should work; but you should have a fallback option regardless. But under what circumstances will the TCCL be able to load classes during BeforeBeanDiscovery for an EAR with multiple WAR files on Wildfly?
Add Comment
This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title Benjamin Confino commented on WELD-2381 Re: Set web application classloader as TCCL when calling observers PS: I'm still with you that this is not a Weld fault but an integration issue! If there was a way to set the TCCL in the integration code so that it is correct during startup for all WARs when an EAR contains multiple WARs then I would be eager to investigate integrating that change on my end. But if there is a solution in the integration code that works for an EAR file with multiple WARs I haven't found it. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title Mark Struberg commented on WELD-2381 Re: Set web application classloader as TCCL when calling observers > and used to load classes But even this is not working, right? Try it out to load a class from your WAR with this TCCL. It will most likely not work. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title Martin Kouba commented on WELD-2381 Re: Set web application classloader as TCCL when calling observers Mark Struberg Mark nobody questions the usage of TCCL. However, I believe it's just wrong to rely on the TCCL identity. The only feature guaranteed is IMHO that it could be obtained from the current thread and used to load classes. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2390) BeanManager.isStereotype() should not throw DefinitionException
Title: Message Title
Martin Kouba created an issue
Weld / WELD-2390
BeanManager.isStereotype() should not throw DefinitionException
Issue Type:
Bug
Assignee:
Unassigned
Created:
23/May/17 9:06 AM
Fix Versions:
2.4.4.Final, 3.0.1.Final
Priority:
Minor
Reporter:
Martin Kouba
The DefinitionException is throw if the following Action qualifier class is used as a param:
@Qualifier
@Target({ TYPE, METHOD })
@Retention( RetentionPolicy.RUNTIME)
@Preferred
public @interface Action {
}
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title Mark Struberg commented on WELD-2381 Re: Set web application classloader as TCCL when calling observers Matej Novotny DeltaSpike is by far not the only framework which relies on the TCCL. Both MyFaces and Mojarra do as well. As do all JPA Implementations, and many other EE frameworks. So by not having the TCCL set up correctly you basically trash most of JavaEE in EARs if respective features get accessed during startup. That's the reason why the JavaEE umbrella spec explicitly defines that applications can rely that the TCCL has been set up. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2381) Set web application classloader as TCCL when calling observers
Title: Message Title Matej Novotny commented on WELD-2381 Re: Set web application classloader as TCCL when calling observers Thanks Benjamin, we went through the reproducer and did some debugging with DS. The final conclusion is that we do not think this is a CDI/Weld issue and that the assumption on which DS implementation works is in our opinion incorrect. As we stated several times above, the interpretation of TCCL does not imply this usage. If you wish to seek a solution to this, it would be best to raise it as DeltaSpike issue and suggest an alternative implementation which won't rely on TCCL as key to the map of config. sources. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
