[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated CDITCK-626 CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Git Pull Request: https://github.com/cdi-spec/cdi-tck/pull/183, https://github.com/cdi-spec/cdi-tck/pull/184 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Fix Version/s: 2.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny assigned an issue to Nikoleta Žiaková CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Assignee: Matej Novotny Nikoleta Žiaková Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2572) Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean
Title: Message Title Matej Novotny updated an issue Weld / WELD-2572 Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean Change By: Matej Novotny Labels: jdk12 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2572) Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean
Title: Message Title Matej Novotny updated an issue Weld / WELD-2572 Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean Change By: Matej Novotny Component/s: Servlet Container Support Component/s: Java SE Support Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2572) Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean
Title: Message Title Matej Novotny updated an issue Weld / WELD-2572 Java 12 triggers WeldException: WELD-001524: Unable to load proxy class for bean Implicit Bean Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Matej Novotny updated WELD-2566 Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2571) Investigate self-invocation of intercercepted private final method
Title: Message Title Matej Novotny created an issue Weld / WELD-2571 Investigate self-invocation of intercercepted private final method Issue Type: Bug Affects Versions: 3.1.0.Final Assignee: Unassigned Created: 19/Mar/19 2:57 AM Priority: Minor Reporter: Matej Novotny This issue is based on forum post which provides more in-depth description as well as a scenario that should reproduce the behaviour. In short, Weld only handles interception if method invocation goes through a contextual reference (in order for it to be business method invocation). Therefore, calls such as this.foo() shouldn't be intercepted. However, there seems to be some awkward behaviour when a method is private and final. Good starting point would be to dump the proxies created by Weld as private final methods will need to be handled differently. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2571) Investigate self-invocation of intercercepted private final method
Title: Message Title Matej Novotny updated an issue Weld / WELD-2571 Investigate self-invocation of intercercepted private final method Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2571) Investigate self-invocation of intercercepted private final method
Title: Message Title Matej Novotny updated an issue Weld / WELD-2571 Investigate self-invocation of intercercepted private final method Change By: Matej Novotny Forum Reference: https://developer.jboss.org/message/988443 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny resolved as Rejected Rejecting issue. This is about a custom deployment model that we do not support in a backward portable fashion. There is still a way to make it fully functional with newer versions of Weld and Tomcat, the only problem is with Weld 1 which is no longer actively developed. Weld / WELD-2570 WELD-ENV-33 error using Tomcat 8+ in Eclipse Change By: Matej Novotny Status: Open Resolved Resolution: Rejected Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny updated an issue Weld / WELD-2570 WELD-ENV-33 error using Tomcat 8+ in Eclipse Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny commented on WELD-2570 Re: WELD-ENV-33 error using Tomcat 8+ in Eclipse Regarding how the deployment is made, I make use of the Eclipse server option "Serve modules without publishing"[1], this way I'm serving the application directly from my workspace. I see, this explains it. The structure of files is then very different to what Weld expects from an actual archive (WAR). This Eclipse feature was never supported, at least not intentionally. I'd say that since you can make it work for newer Weld & Tomcat versions and Weld 1 is no longer being developed, we can close this issue. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2548) StackOverFlow when used with EL and JSF
Title: Message Title Matej Novotny resolved as Rejected I am rejecting this issue based on previous analysis. Weld / WELD-2548 StackOverFlow when used with EL and JSF Change By: Matej Novotny Status: Open Resolved Resolution: Rejected Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny updated WELD-2568 Weld / WELD-2568 Ordering of ProcessAnnotatedType events via @Priroty doesn't work Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2564) Make documentation buildable with up-to-date tooling
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1909 in GitHub Weld / WELD-2564 Make documentation buildable with up-to-date tooling Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2564) Make documentation buildable with up-to-date tooling
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2564 Make documentation buildable with up-to-date tooling Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2564) Make documentation buildable with up-to-date tooling
Title: Message Title Matej Novotny updated an issue Weld / WELD-2564 Make documentation buildable with up-to-date tooling Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1909 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1908 in GitHub Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Matej Novotny updated an issue Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1908 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title
Matej Novotny edited a comment on WELD-2570
Re: WELD-ENV-33 error using Tomcat 8+ in Eclipse
Looking at docs for older version (Weld 1), I can see following:bq. That means each archive that contains beans must include a file named beans.xml in the META-INF directory of the classpath or WEB-INF directory of the web root (for war archives). So I am quite surprised that it worked for you before on Tomcat 7 with Weld 1 under {{META-INF}}.When you are deploying via IDE, what does the deployment look like? It is an actual WAR at all? If it's not, then Weld might be going a different way in discovering {{beans.xml}} perhaps.Also noteworthy is that you are comparing Weld 1 and Weld 3 in this regards and there are likely some differences in this, especially given that servlet support isn't rooted in CDI spec at all.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny updated an issue Weld / WELD-2570 WELD-ENV-33 error using Tomcat 8+ in Eclipse Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny commented on WELD-2570 Re: WELD-ENV-33 error using Tomcat 8+ in Eclipse Looking at docs for older version (Weld 1), I can see following: That means each archive that contains beans must include a file named beans.xml in the META-INF directory of the classpath or WEB-INF directory of the web root (for war archives). So I am quite surprised that it worked for you before on Tomcat 7 with Weld 1 under META-INF. When you are deploying via IDE, what does the deployment look like? It is an actual WAR at all? Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2570) WELD-ENV-000033 error using Tomcat 8+ in Eclipse
Title: Message Title Matej Novotny commented on WELD-2570 Re: WELD-ENV-33 error using Tomcat 8+ in Eclipse Hello Carlos Aristu according to Weld specification, you should have your beans.xml under WEB-INF folder for WAR archives. See this bit of the documentation. Is there a specific reason why you cannot adhere to that? Having it in WEB-INF should rule out what default scanner finds. Note 2: this problem usually does not happen when deploying the applicaton in Tomcat without using Eclipse. In this case the beans.xml file is placed at WEB-INF/classes/META-INF/beans.xml. As this path contains the keyword "WEB-INF" the result found by the DefaultBeanArchiveScanner is discarded here. I am afraid I don't see how beans.xml placement depends on how you deploy the application? It should simply be packaged inside the WAR you are deploying, therefore it is in place before you get to deploying. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2569) BeanArchives can't be resolved in URL form
Title: Message Title Matej Novotny updated an issue Weld / WELD-2569 BeanArchives can't be resolved in URL form Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2569) BeanArchives can't be resolved in URL form
Title: Message Title Matej Novotny updated an issue Weld / WELD-2569 BeanArchives can't be resolved in URL form Change By: Matej Novotny Labels: Awaiting-Contribution Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2569) BeanArchives can't be resolved in URL form
Title: Message Title Matej Novotny commented on WELD-2569 Re: BeanArchives can't be resolved in URL form Hello Melvin Santos-Piza. thanks for the report. Currently we only support the common archive formats as you found out. That being said, I am not opposed to supporting more formats in case you feel like contributing to Weld? Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1907 in GitHub Weld / WELD-2568 Ordering of ProcessAnnotatedType events via @Priroty doesn't work Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny commented on WELD-2568 Re: Ordering of ProcessAnnotatedType events via @Priroty doesn't work Sent a PR that should fix it. Also, looking more carefully into CDI TCK, there is indeed a test that assert exactly this capability, but using ProcessBean as event. This kind of hid the bug here because Weld treats ProcessAnnotatedType somewhat differently (optimizations). Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2568 Ordering of ProcessAnnotatedType events via @Priroty doesn't work Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1907 Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny commented on WELD-2568 Re: Ordering of ProcessAnnotatedType events via @Priroty doesn't work So I've created an automated test for this, available on this branch. The problem seems to be manifesting only when Jandex is in play - in other words, it will show itself on WFLY (sometimes crashing, sometimes passing based on random order) but will work just fine in Weld SE (without manually enforcing Jandex OFC) or embedded container. The test reflects this by the ability to run with -Dincontainer on WFLY and without the parameter in embedded container. We should look into implementing ordering for when Jandex is in play. The relevant parts are (likely) - org.jboss.weld.bootstrap.events.ContainerLifecycleEvents.fireProcessAnnotatedType(BeanManagerImpl, SlimAnnotatedTypeContext) which handles the even firing and either fires it via fast events (unsorted) or delegates to ObserverNotifier which then has it sorted. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny updated an issue Weld / WELD-2568 Ordering of ProcessAnnotatedType events via @Priroty doesn't work Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny commented on WELD-2568 Re: Ordering of ProcessAnnotatedType events via @Priroty doesn't work I'm not 100% sure about that, but AFAIK this worked correctly in previous Wildfly versions (11 or 12?). CDI 1.2 didn't have this functionality for sure. Therefore, if this worked, it could have been incidental or you might have been using the EE 8 mode on WFLY 12 where Weld 3 was already present? Furthermore, in your code, those two observers have different @WithAnnotations. So I presume you have been observing this issue with PAT events which contained all the annotations required by both observers, am I correct? Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2568) Ordering of ProcessAnnotatedType events via @Priroty doesn't work
Title: Message Title Matej Novotny commented on WELD-2568 Re: Ordering of ProcessAnnotatedType events via @Priroty doesn't work Hello Christian, I think you misread how CDI supports ordering in CDI extensions. Just for reference, I am talking about this part of CDI specification. The notification order for observer methods within extensions follows the same ordering rule as defined in Observer ordering for non-extension observers. The priority of an observer method may be declared using the @Priority annotation. This means that you can order observers for the same event within one extension, not in between several extensions. CDI TCK supports that as it has tests for what I described above, but no tests for what you try to achieve. The behaviour is IMO desirable as you can never know what other CDI extensions are in play from 3rd party libraries and shouldn't depend on that. In the same time you are free to enforce ordering on stuff happening in your own code. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Fix Version/s: 2.0.6.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title
Matej Novotny commented on CDITCK-626
Re: EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Instead of using a tolerance mechanism we should perhaps operate on TCK-defined classes (create some {Foo}} and {{Bar}}s) where the bean types are JDK-agnostic.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title Matej Novotny commented on WELD-2567 Re: NPE when trying to get BeanManager after container was closed This issue is blocked by CDI-743 and unless a fix gets into CDI, we should not be fixing this on Weld side to avoid possible problems with multiple CDI providers on CP. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title Matej Novotny updated an issue Weld / WELD-2567 NPE when trying to get BeanManager after container was closed Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title Matej Novotny edited a comment on WELD-2567 Re: NPE when trying to get BeanManager after container was closed I am not sure we want to change this in our code before this gets resolved on CDI side.Like I said in CDI-743, the code doesn't account for providers throwing ISE albeit that case will likely be very rare. That being said I acknowledge that the contract is pretty clear about throwing ISE. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title Matej Novotny commented on WELD-2567 Re: NPE when trying to get BeanManager after container was closed I am not sure we want to change this in our code before this gets resolved on CDI side. Like I said in CDI-743, the code doesn't account for providers throwing ISE albeit that case will likely be very rare. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title
Matej Novotny updated an issue
Weld / WELD-2567
NPE when trying to get BeanManager after container was closed
Change By:
Matej Novotny
{{ CDI.current() }} should produce {{ IllegalStateException }} when there is no active container at the moment.Instead on the second call in the sample application {{ CDI.current() }} returns null and that results in NPE.The problem is in the implementation of {{ WeldSEProvider.getCDI() }} It should not return null if there is no active container. Instead it should produce {{ IllegalStateException }}
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2567) NPE when trying to get BeanManager after container was closed
Title: Message Title
Matej Novotny updated an issue
Weld / WELD-2567
NPE when trying to get BeanManager after container was closed
Change By:
Matej Novotny
Steps to Reproduce:
Try to run this application: {code} import javax.enterprise.inject.se.SeContainer;import javax.enterprise.inject.se.SeContainerInitializer;import javax.enterprise.inject.spi.CDI;public class NPEOnSecondGetBeanManager {public static void main(String[] args) {SeContainer container = SeContainerInitializer.newInstance() .disableDiscovery() .addBeanClasses(BeanClass.class) .initialize();CDI.current().getBeanManager();container.close();CDI.current().getBeanManager();}public static class BeanClass {}} {code}
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Matej Novotny updated an issue Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2566) WeldAlterableContext clearAndSet() needs to clear caches
Title: Message Title Matej Novotny created an issue Weld / WELD-2566 WeldAlterableContext clearAndSet() needs to clear caches Issue Type: Bug Affects Versions: 3.1.0.Final Assignee: Unassigned Created: 15/Feb/19 3:29 AM Priority: Major Reporter: Matej Novotny Implementations of clearAndSet() method from WeldAlterableContext have to invoke RequestScopedCache.invalidate(). This makes sure the ThreadLocal caches for request/session/conversation scopes are flushed. This isn't normally a problem if you propagate contexts into a different thread. However, if you temper with context states on the same (main) thread, you will now end up in a weird state where context storage is empty, but caches still return old references. This scenario is from MP Concurrency where there is no guarantee which thread will be used for execution. A workaround is to manually invoke RequestScopedCache.invalidate() whenever integrator deals with propagation as the method is static. Though this requires weld-core dependency. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2564) Make documentation buildable with up-to-date tooling
Title: Message Title Matej Novotny created an issue Weld / WELD-2564 Make documentation buildable with up-to-date tooling Issue Type: Task Affects Versions: 3.1.0.Final Assignee: Unassigned Components: Documentation Created: 12/Feb/19 7:34 AM Priority: Major Reporter: Matej Novotny We are using some pretty old artifacts around documentation. This should be revisited and updated accordingly. One of the problems is for sure building it with newer JDKs. The other is that during release we use Gradle to grab the whole distribution (docs included, see this repo) and that shows some additional problems. The task in this issue is to make sure it is buildable with JDK 8 and JDK 11 and via Maven as well as Gradle build script. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2564) Make documentation buildable with up-to-date tooling
Title: Message Title Matej Novotny updated an issue Weld / WELD-2564 Make documentation buildable with up-to-date tooling Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2563) In a CDI SE application, three instances of every Service loaded are created; only one is used
Title: Message Title Matej Novotny commented on WELD-2563 Re: In a CDI SE application, three instances of every Service loaded are created; only one is used Hmm, that's interesting point you have. Using only one obviously makes sense. Now, when I see this my thinking is... Loading it three times - I suppose this is because you are actually in SE and with flat classpath. If you were in EE then not all resource loaders would be able to load your implementation, hence you need one backed up by CL which loaded Weld itself and another which is bound to deployment. Third one with custom CL as parameter is probably to enforce some EE restrictions on visibility, as in for stuff shoveled on EAR/lib perhaps? This would totally deserve some testing to see why the choice was made. Nevertheless, I don't really see much harm in multiple initialization so long as only one instance is used over and over again. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2563) In a CDI SE application, three instances of every Service loaded are created; only one is used
Title: Message Title Matej Novotny updated an issue Weld / WELD-2563 In a CDI SE application, three instances of every Service loaded are created; only one is used Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2562) Revisit documentation generation process with newer tools
Title: Message Title Matej Novotny created an issue Weld / WELD-2562 Revisit documentation generation process with newer tools Issue Type: Task Affects Versions: 3.1.0.Final Assignee: Unassigned Components: Documentation Created: 06/Feb/19 5:51 AM Priority: Major Reporter: Matej Novotny While generating docs for the release, we leverage Gradle. Newer version of Gradle apparently require JDK 9+ but if provided, then our ancient asciidoctor-maven-plugin fails. Upgrading this plugin in turn yields errors in doc formatting. We should, in general, investigate generating docs on newer Javas and upgrade plugin and docs themselves accordingly. Note that you can generate docs regardless of Gradle of course and so it should be reproducible just by using JDK 9+.! Add Comment
[weld-issues] [JBoss JIRA] (WELD-2562) Revisit documentation generation process with newer tools
Title: Message Title Matej Novotny updated an issue Weld / WELD-2562 Revisit documentation generation process with newer tools Change By: Matej Novotny Fix Version/s: 3.1.1.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2553) Update specs versions to match EE8
Title: Message Title Matej Novotny updated WELD-2553 Weld / WELD-2553 Update specs versions to match EE8 Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2497) Weld API - make it possible to propagate built-in contexts
Title: Message Title Matej Novotny updated an issue Weld / WELD-2497 Weld API - make it possible to propagate built-in contexts Change By: Matej Novotny Git Pull Request: https://github.com/weld/api/pull/80, https://github.com/weld/core/pull/1877, https://github.com/weld/core/pull/1880 , https://github.com/weld/core/pull/1903 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny updated WELD-2550 Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2503) Create Exception handler for applications run using StartMain
Title: Message Title Matej Novotny commented on WELD-2503 Re: Create Exception handler for applications run using StartMain Defering to 3.1x as 3.1.0.Final is now too close and the PR went stale. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2503) Create Exception handler for applications run using StartMain
Title: Message Title Matej Novotny updated an issue Weld / WELD-2503 Create Exception handler for applications run using StartMain Change By: Matej Novotny Fix Version/s: 3.1.x Fix Version/s: 3.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces Xavier Dury just a friendly poke, the PR in this issue should resolve your troubles and will soon be merged and released. It is a first version capable of building proxies completely from interfaces borrowing from your original PR and adding bits here and there for corner cases. I'd be happy to hear your feedback so if you find the solution lacking something, please create new JIRA with details or add a comment here. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2561) Update tests to use the simplified JMS API
Title: Message Title Matej Novotny updated an issue Weld / WELD-2561 Update tests to use the simplified JMS API Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2560) Servlet testing on Jetty 10, Servlet 4.0
Title: Message Title Matej Novotny created an issue Weld / WELD-2560 Servlet testing on Jetty 10, Servlet 4.0 Issue Type: Bug Affects Versions: 3.1.0.Beta1 Assignee: Unassigned Components: Servlet Container Support Created: 04/Feb/19 3:38 AM Fix Versions: 3.1.x Priority: Major Reporter: Matej Novotny Follows up on WELD-2528; by the time that issue was resolved, Jetty 10 still wasn't released. Once it gets released, we want to make sure everything works for us. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2528) Revisit servlet testing on Jetty
Title: Message Title Matej Novotny updated WELD-2528 Weld / WELD-2528 Revisit servlet testing on Jetty Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2528) Revisit servlet testing on Jetty
Title: Message Title Matej Novotny commented on WELD-2528 Re: Revisit servlet testing on Jetty This issue only upgrades tested Jetty to 9.4 as that was the last release when this issue was resolved. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2517) Fix se/numberguess example with SecurityManager enabled
Title: Message Title Matej Novotny updated WELD-2517 Weld / WELD-2517 Fix se/numberguess example with SecurityManager enabled Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1896 in GitHub Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny updated an issue Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1896 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2533) Inspect limitations of InterceptionFactory usage on interfaces
Title: Message Title Matej Novotny updated an issue Weld / WELD-2533 Inspect limitations of InterceptionFactory usage on interfaces Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1873 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces So, one problematic thing is hierarchy of interfaces, the proxies currently only take methods from classes so the proxy end up lacking some. Other thing is combining this with annotations on interfaces - it is currently undefined whether we should respect existing annotations (and what if user adds already existing annotation) or even search super-interfaces for annotations. Currently, this approach will only "see" whatever is on the interface from which we build the InterceptionFactory. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated WELD-2556 Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2546) InterceptorLogger.unableToDetermineInterceptedBean() should be probably logged at the INFO level
Title: Message Title Matej Novotny updated WELD-2546 Weld / WELD-2546 InterceptorLogger.unableToDetermineInterceptedBean() should be probably logged at the INFO level Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2536) Make InjectableRequestContextController more robust
Title: Message Title Matej Novotny updated WELD-2536 After some discussion we concluded that using thread locals won't help to make the controller more robust on multi threaded environment. So for now we'll just go with fixing the bug I mentioned in the previous comment. Weld / WELD-2536 Make InjectableRequestContextController more robust Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org
[weld-issues] [JBoss JIRA] (WELD-2558) Remove @Deprecated methods in API/SPI
Title: Message Title Matej Novotny updated WELD-2558 Weld / WELD-2558 Remove @Deprecated methods in API/SPI Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2535) Weld handleJar does not handle packages with overlapping names correct
Title: Message Title Matej Novotny updated WELD-2535 Weld / WELD-2535 Weld handleJar does not handle packages with overlapping names correct Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2558) Remove @Deprecated methods in API/SPI
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #84 in GitHub Weld / WELD-2558 Remove @Deprecated methods in API/SPI Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2558) Remove @Deprecated methods in API/SPI
Title: Message Title Matej Novotny updated an issue Weld / WELD-2558 Remove @Deprecated methods in API/SPI Change By: Matej Novotny Git Pull Request: https://github.com/weld/api/pull/84 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2558) Remove @Deprecated methods in API/SPI
Title: Message Title Matej Novotny updated an issue Weld / WELD-2558 Remove @Deprecated methods in API/SPI Change By: Matej Novotny Git Pull Request: https://github.com/weld/api/pull/84 , https://github.com/weld/core/pull/1891 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2535) Weld handleJar does not handle packages with overlapping names correct
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1890 in GitHub Weld / WELD-2535 Weld handleJar does not handle packages with overlapping names correct Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2535) Weld handleJar does not handle packages with overlapping names correct
Title: Message Title Matej Novotny updated an issue Weld / WELD-2535 Weld handleJar does not handle packages with overlapping names correct Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1889, https://github.com/weld/core/pull/1890 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2535) Weld handleJar does not handle packages with overlapping names correct
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2535 Weld handleJar does not handle packages with overlapping names correct Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2559) Weld core cannot initialize class with Java 12
Title: Message Title
Matej Novotny edited a comment on WELD-2559
Re: Weld core cannot initialize class with Java 12
So the problem here is that JDK 12 changed our options around class defining again, namely disallowed us to use {{Unsafe}} to crack open {{ClassLoader}} methods.It's known problem, the issues you linked are part of it. Weld itself however does [ the same thing as classfilewriter |https://github.com/weld/core/blob/3.1.0.Beta1/impl/src/main/java/org/jboss/weld/util/bytecode/ClassFileUtils.java#L46-L73] hence is a source of these problems as well.There is a similar issue under WELD-2556 which I created and where I have a "fix" for this in EE servers.Though your problem is in SE or servlet where Weld has to define classes. In such case I do not yet know how to fix it. JDK 12 disallows us to anyhow use CL's {{defineClass()}} methods but using {{MethodHandles.Lookup}} isn't sufficient either. NOTE: What still works (but who knows how long) is using {{setAccessible()}} but in that case, warnings are shown which isn't nice. WELD-2556 actually does just that as a fallback. We need better solution though.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2559) Weld core cannot initialize class with Java 12
Title: Message Title Matej Novotny updated an issue Weld / WELD-2559 Weld core cannot initialize class with Java 12 Change By: Matej Novotny Fix Version/s: 3.1.x Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2559) Weld core cannot initialize class with Java 12
Title: Message Title Matej Novotny commented on WELD-2559 Re: Weld core cannot initialize class with Java 12 So the problem here is that JDK 12 changed our options around class defining again, namely disallowed us to use Unsafe to crack open ClassLoader methods. It's known problem, the issues you linked are part of it. Weld itself however does the same thing as classfilewriter hence is a source of these problems as well. There is a similar issue under WELD-2556 which I created and where I have a "fix" for this in EE servers. Though your problem is in SE or servlet where Weld has to define classes. In such case I do not yet know how to fix it. JDK 12 disallows us to anyhow use CL's defineClass() methods but using MethodHandles.Lookup isn't sufficient either. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2557) Not all events are fired
Title: Message Title Matej Novotny commented on WELD-2557 Re: Not all events are fired I could try to create a minimal example but I don't know if it will trigger the same behavior. Please let me know if I should do that. Yes, that would be great. We have tests for those events fired but obviously those are working. ... "Weld Thread Pool – x" Yea, those are actual Weld threads. ... "MSC service thread x-x" ... And that's JBoss MSC threads bootstrapping WildFly (and Weld inside it). As as site note: It never failed with WildFly 10.0.1.Final Have you tried anything in between 10.0.1.Final and 15.0.1.Final? I am aware of some changes done in Weld's services inside WildFly, but those were quite numerous. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #83 in GitHub Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2557) Not all events are fired
Title: Message Title Matej Novotny commented on WELD-2557 Re: Not all events are fired Hello Ste Gr thanks for reporting the issue. Would you be able to share the example app you were using? I know it's not a reproducer but it may still be a good starting point. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2557) Not all events are fired
Title: Message Title Matej Novotny updated an issue Weld / WELD-2557 Not all events are fired Change By: Matej Novotny Component/s: Servlet Container Support Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Git Pull Request: https://github.com/weld/api/pull/83, https://github.com/weld/core/pull/1888 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2422) Revisit Weld SPI so that integrators are not required to depend on Weld internals
Title: Message Title Matej Novotny commented on WELD-2422 Re: Revisit Weld SPI so that integrators are not required to depend on Weld internals Moving this issue away from 3.1.0.Final release as the implementation is too time consuming to meet the deadline. Once implemented, this issue should be part of a Weld release which bumps minor version due to the API/SPI changes it will bring. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2422) Revisit Weld SPI so that integrators are not required to depend on Weld internals
Title: Message Title Matej Novotny updated an issue Weld / WELD-2422 Revisit Weld SPI so that integrators are not required to depend on Weld internals Change By: Matej Novotny Fix Version/s: 3.1.x Fix Version/s: 3.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2555) ConcurrentModificationException while destroying context
Title: Message Title Matej Novotny commented on WELD-2555 Re: ConcurrentModificationException while destroying context By not supported I meant mainly undefined. While we could look into the cause of this, it would still be bad practice to use it. I'll close the issue then. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2555) ConcurrentModificationException while destroying context
Title: Message Title Matej Novotny resolved as Rejected Weld / WELD-2555 ConcurrentModificationException while destroying context Change By: Matej Novotny Status: Open Resolved Resolution: Rejected Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2555) ConcurrentModificationException while destroying context
Title: Message Title
Matej Novotny edited a comment on WELD-2555
Re: ConcurrentModificationException while destroying context
Hi [~munzi82] First of all, thanks for the report. I would start by pointing out that what you are trying isn't exactly good practice and in fact neither is this supported.I am talking about invoking one request scoped bean from within {{@PreDestroy}} callback of another request scoped bean.Since CDI spec doesn't define any order in which to handle these callbacks, you cannot rely on it.To demonstrate this - it can easily happen that the bean you are referencing in the callback no longer exists as it was destroyed prior to your bean. The callback will still execute but the bean will be created anew which will likely have side-effects you don't want (as no state would be preserved).You can quite reliably call other beans with "wider" scope than the one you are destroying, e.g. referencing application scoped bean in pre-destroy callback of request scoped bean should be safe.With the above in mind, I am not sure whether we should look into fixing this rare glitch or rather advice you to restructure the original code as it cannot be relied upon. WDYT?
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2555) ConcurrentModificationException while destroying context
Title: Message Title Matej Novotny commented on WELD-2555 Re: ConcurrentModificationException while destroying context Hi Daniel Munzinger I would start by pointing out that what you are trying isn't exactly good practice and in fact neither is this supported. I am talking about invoking one request scoped bean from within @PreDestroy callback of another request scoped bean. Since CDI spec doesn't define any order in which to handle these callbacks, you cannot rely on it. To demonstrate this - it can easily happen that the bean you are referencing in the callback no longer exists as it was destroyed prior to your bean. The callback will still execute but the bean will be created anew which will likely have side-effects you don't want (as no state would be preserved). You can quite reliably call other beans with "wider" scope than the one you are destroying, e.g. referencing application scoped bean in pre-destroy callback of request scoped bean should be safe. With the above in mind, I am not sure whether we should look into fixing this rare glitch or rather advice you to restructure the original code as it cannot be relied upon. WDYT? Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Labels: jdk12 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title
Matej Novotny updated an issue
Weld / WELD-2556
Draft new SPI for defining classes that will delegate to integrator implementations
Change By:
Matej Novotny
We need to introduce new SPI that integrators implement and that will allow us to delegate class creation to them as opposed to current state where we just ask for proper {{ClassLoader}}.Current approach requires us to crack open CL's {{defineClass()}} methods which won't really work on JDK 12. Integrators can provide their own privileged CLs which won't have these problems.The idea is to introduce a new interface {{WeldClassDefiner}} (name is just a suggestion) which would have several methods with same signature as seen on CL. Namely we need two variations of {{defineClass()}} plus {{loadClass()}}. With that in place, {{ProxyServives}} could have a {{getClassDefiner()}} method returning the implementation. This approach will likely be requires on JDK 12.On WFLY side, the implementation will leverage [ {{ClassDefiner}} |https://github.com/jboss-modules/jboss-modules/blob/1.x/src/main/java/org/jboss/modules/ClassDefiner.java] which is part of jboss-modules.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Fix Version/s: 3.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny created an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Issue Type: Enhancement Affects Versions: 3.1.0.Beta1 Assignee: Unassigned Components: Proxies Created: 09/Jan/19 9:44 AM Priority: Major Reporter: Matej Novotny We need to introduce new SPI that integrators implement and that will allow us to delegate class creation to them as opposed to current state where we just ask for proper ClassLoader. Current approach requires us to crack open CL's defineClass() methods which won't really work on JDK 12. Integrators can provide their own privileged CLs which won't have these problems. The idea is to introduce a new interface WeldClassDefiner (name is just a suggestion) which would have several methods with same signature as seen on CL. Namely we need two variations of defineClass() plus loadClass(). With that in place, ProxyServives could have a getClassDefiner() method returning the implementation. This approach will likely be requires on JDK 12. On WFLY side, the implementation will leverage ClassDefiner which is part of jboss-modules.
[weld-issues] [JBoss JIRA] (CDITCK-625) RequestContextTest test fails on fast computer ; -)
Title: Message Title Matej Novotny updated CDITCK-625 CDI TCK / CDITCK-625 RequestContextTest test fails on fast computer ;-) Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-613) Forwarding util classes should not delegate toString()
Title: Message Title Matej Novotny updated CDITCK-613 CDI TCK / CDITCK-613 Forwarding util classes should not delegate toString() Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-625) RequestContextTest test fails on fast computer ; -)
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-625 RequestContextTest test fails on fast computer ;-) Change By: Matej Novotny Git Pull Request: https://github.com/cdi-spec/cdi-tck/pull/181, https://github.com/cdi-spec/cdi-tck/pull/182 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
