[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated CDITCK-626 CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Git Pull Request: https://github.com/cdi-spec/cdi-tck/pull/183, https://github.com/cdi-spec/cdi-tck/pull/184 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Fix Version/s: 2.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny assigned an issue to Nikoleta Žiaková CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Assignee: Matej Novotny Nikoleta Žiaková Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Issue was automatically transitioned when Nikoleta Ziakova created pull request #183 in GitHub CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Nikoleta Ziakova Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Xiao Ou Sun commented on CDITCK-626 Re: EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 That sounds good. Thanks. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title Matej Novotny updated an issue CDI TCK / CDITCK-626 EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12 Change By: Matej Novotny Fix Version/s: 2.0.6.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title
Matej Novotny commented on CDITCK-626
Re: EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Instead of using a tolerance mechanism we should perhaps operate on TCK-defined classes (create some {Foo}} and {{Bar}}s) where the bean types are JDK-agnostic.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-626) EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Title: Message Title
Xiao Ou Sun created an issue
CDI TCK / CDITCK-626
EnvInjectionTest.testResourceBeanTypes() doesn't work with JDK12
Issue Type:
Bug
Affects Versions:
2.0.5.SP1
Assignee:
Matej Novotny
Components:
Tests
Created:
19/Feb/19 7:59 PM
Environment:
Linux x86_64, Weblogic 12c with JDK12
Priority:
Major
Reporter:
Xiao Ou Sun
Error message is: java.lang.AssertionError at org.jboss.cdi.tck.tests.implementation.simple.resource.env.EnvInjectionTest.testResourceBeanTypes(EnvInjectionTest.java:83) The case fails in bean types counting: package org.jboss.cdi.tck.tests.implementation.simple.resource.env; ... public class EnvInjectionTest extends AbstractTest { ... public void testResourceBeanTypes() { @SuppressWarnings("serial") Bean greeting = getBeans(String.class, new AnnotationLiteral() { }).iterator().next(); assert greeting.getTypes().size() == 5; # Line83, assertionError occurs here assert rawTypeSetMatches(greeting.getTypes(), String.class, Object.class, Serializable.class, Comparable.class, CharSequence.class); } } The reason of the issue should be: Before JDK12, class java.lang.String in JavaDoc looks like: Class String java.lang.Object java.lang.String All Implemented Interfaces: Serializable, CharSequence, Comparable But it changed in JDK12: Class String java.lang.Object java.lang.String All Implemented Interfaces: Serializable, CharSequence, Comparable, Constable, ConstantDesc So with JDK12, "greeting.getTypes().size()" is 7 instead of 5, which causes the assertion. Could we add tolerance mechanic for this? Thanks. -X.O.
