[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Ariel Carrera edited a comment on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces I have some problems related to this issue using Java Interfaces on InterfaceFactory.Maybe it can be improved.Check this: [ https://developer.jboss.org/thread/280113 forum link |https://developer.jboss.org/thread/280113] Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Ariel Carrera commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces I have some problems related to this issue using Java Interfaces on InterfaceFactory. Maybe it can be improved. Check this: [https://developer.jboss.org/thread/280113 https://developer.jboss.org/thread/280113] Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Xavier Dury commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces Matej Novotny I've tested your change and found it good enough for the use-cases I had in mind. It also proves that the concept is viable and that it could be further debated/refined by the EG. Thanks! Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny updated WELD-2550 Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces Xavier Dury just a friendly poke, the PR in this issue should resolve your troubles and will soon be merged and released. It is a first version capable of building proxies completely from interfaces borrowing from your original PR and adding bits here and there for corner cases. I'd be happy to hear your feedback so if you find the solution lacking something, please create new JIRA with details or add a comment here. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1896 in GitHub Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny updated an issue Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1896 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny commented on WELD-2550 Re: InterceptionFactory with loosened limitation on interfaces So, one problematic thing is hierarchy of interfaces, the proxies currently only take methods from classes so the proxy end up lacking some. Other thing is combining this with annotations on interfaces - it is currently undefined whether we should respect existing annotations (and what if user adds already existing annotation) or even search super-interfaces for annotations. Currently, this approach will only "see" whatever is on the interface from which we build the InterceptionFactory. Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title
Xavier Dury commented on WELD-2550
Re: InterceptionFactory with loosened limitation on interfaces
Nice! I'd like to point out that while you lose interceptor bindings (declared on the instance's class) when using an interface on the InterceptionFactory, you still retain the possibility to parameterize the InterceptionFactory with the target instance's class (and not losing anything). This makes me think that all interceptor bindings could maybe come from the parameter type (+ configurator) and the proxyability requirement could also be on that parameter type rather than on the instance's type... but that would be a change in the current spec. After all, a producer method returning an interface does not seem to take into account the concrete type of the returned object (nor all other interfaces it might implement). This can be tweaked with @Typed. Alternatively and thinking out loud, we could maybe control what type(s) a proxy should be made of with something like this:
@Produces
SomeInterface bean(@Typed({SomeInterface.class, SomeOtherInterface.class}) InterceptionFactory factory) { ... }
or with a new method on InterceptionFactory like setProxyTypes(Class...)... but these are just ideas thrown in there.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny created an issue Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Issue Type: Bug Affects Versions: 3.1.0.Beta1 Assignee: Unassigned Components: Interceptors and Decorators, Producers (Methods, Fields and Disposers) Created: 29/Nov/18 4:14 AM Priority: Major Reporter: Matej Novotny After some lengthy discussion in WELD-2533, and thanks to Xavier Dury, I think it is possible to enhance the capabilities of InterceptionFactory on interfaces by not enforcing the proxyability (and constructor) requirements while staying aligned with CDI spec. As it stands: CDI spec says that If the type of the instance is not proxyable as defined in Unproxyable bean types an UnproxyableResolutionException exception is thrown. I found no CDI TCK test that would cover this specifically But CDI spec also says that If an injection point of type InterceptionFactory has a type parameter that is not a Java class, non-portable behavior results. This in theory negates the previous sentence and loosens the requirements Currently (Weld 3.1.0.Beta1) we allow to have interface as parameter of
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2550) InterceptionFactory with loosened limitation on interfaces
Title: Message Title Matej Novotny updated an issue Weld / WELD-2550 InterceptionFactory with loosened limitation on interfaces Change By: Matej Novotny Fix Version/s: 3.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
