[weld-issues] [JBoss JIRA] (WELD-2629) ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations
Title: Message Title Matěj Novotný created an issue Weld / WELD-2629 ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations Issue Type: Task Affects Versions: 4.0.0.Alpha2, 3.1.4.Final, 2.4.8.Final Assignee: Unassigned Created: 08/Jun/20 4:24 AM Priority: Major Reporter: Matěj Novotný ConversationContextDestroyedOnSessionTimeoutTest now expect session to timeout asynchronously while performing a simulated long running action on a conversation bean. In newer WFLY versions, this is not the case. Checking on servlet specification, this shouldn't be relied upon and session should timeout if the time period between requests is bigger then x (the number you set it to be). Therefore the test assertion that pre destroy callback and session timeout will trigger sooner then bean's business logic method is plain wrong. We need to rework the test to only verify that pre-destroy gets called in case of timeout. See notes in this PR for more information on this test. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2629) ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations
Title: Message Title Matěj Novotný assigned an issue to Matěj Novotný Weld / WELD-2629 ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations Change By: Matěj Novotný Assignee: Matěj Novotný Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2629) ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations
Title: Message Title Matěj Novotný updated an issue Weld / WELD-2629 ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations Change By: Matěj Novotný Fix Version/s: 3.1.5.Final Fix Version/s: 4.0.0.Alpha3 Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2629) ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations
Title: Message Title Issue was automatically transitioned when Matěj Novotný created pull request #2000 in GitHub Weld / WELD-2629 ConversationContextDestroyedOnSessionTimeoutTest goes against servlet spec expectations Change By: Matěj Novotný Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-590) Add a test for Bean Discovery which asserts lifecycle event ordering
Title: Message Title Romain Manni-Bucau commented on CDITCK-590 Re: Add a test for Bean Discovery which asserts lifecycle event ordering Hi, Can it be revised? Spec lists the needed events but it is not written the order must be this one + it is more logical to add PBA at the beginning, next to PAT since it has veto data, does not make sense to do it at the end cause it is already too late. Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-590) Add a test for Bean Discovery which asserts lifecycle event ordering
Title: Message Title Mark Struberg commented on CDITCK-590 Re: Add a test for Bean Discovery which asserts lifecycle event ordering Plus it is wrong. The correct order is > ProcessAnnotatedType -> ProcessBeanAttributes -> ProcessInjectionPoint -> ProcessInjectionTarget -> ProcessBean Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-590) Add a test for Bean Discovery which asserts lifecycle event ordering
Title: Message Title Mark Struberg commented on CDITCK-590 Re: Add a test for Bean Discovery which asserts lifecycle event ordering Note also, that this TCK test is not part of the official CDI-2.0 JSR but added at a random later point. Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (CDITCK-590) Add a test for Bean Discovery which asserts lifecycle event ordering
Title: Message Title Mark Struberg edited a comment on CDITCK-590 Re: Add a test for Bean Discovery which asserts lifecycle event ordering Plus it is wrong. The correct order - as far as I remember it has been discussed originally - is> ProcessAnnotatedType -> ProcessBeanAttributes -> ProcessInjectionPoint -> ProcessInjectionTarget -> ProcessBean Add Comment This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
