[Wesnoth-bugs] [bug #24559] Local Game scrollbar misaligned

[Pentarctagon]

Follow-up Comment #2, bug #24559 (project wesnoth):

Works for me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Daniel]

Follow-up Comment #4, bug #24568 (project wesnoth):

> unless the intention is to make the feature available and fully-supported
for a broader audience (e.g. people on GCC 5 and later). 

This is suppoerted for gcc5 and later. The check in the cude is currently like
"#if _MSC_VER >= 1900 || __cplusplus >= 201402L" where the second check is for
the gcc/clang case.

> You could just add a PPA that includes the right GCC version..

Hmm yes the problems is that i really don't know much about this stuff, i
tried to find some other github porjestcs that use gcc5 for their travis build
to copy from their travis.yml but that didn't work eigher.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Ignacio R. Morelle]

Follow-up Comment #3, bug #24568 (project wesnoth):

It seems rather excessive to optimize this early for a compiler that only a
couple of people's private builds (and no production builds) can benefit from,
unless the intention is to make the feature available and fully-supported for
a broader audience (e.g. people on GCC 5 and later
).

The issue with Travis is that last time I checked they did not provide build
environments running anything newer than Ubuntu trusty, which only includes
gcc 4.8 at most. You could just add a PPA that includes the right GCC version,
but it's up to you to figure out what to do if the PPA maintainers decide to
switch versions/close it down/drop support for trusty/insert malware in the
compiler binaries; the rest should be relatively simple. I'm sure an actual
Ubuntu user could give some recommendations here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24559] Local Game scrollbar misaligned

[Charles Dang]

Update of bug #24559 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => vultraz

___

Follow-up Comment #1:

Fixed in
https://github.com/wesnoth/wesnoth/commit/692502f441cd80b8df8424c4cedc1d5f813a5946

I had changed the images for the new GUI2 style, so I readded the old ones so
GUI1 still works.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24569] remove readline/history dependency

[Daniel]

Follow-up Comment #2, bug #24569 (project wesnoth):

> Has anyone tried contacting upstream about these issues?

Not that i know of. The point problem here is that you cannot archieve good
windows compaility by just using standard c libarires like fopen. you have to
eigher use the wchar_t api or use another libarires that does this conversion
for you.


>  It wasn't too long ago that the same could be said about Wesnoth and OS X.

You mean point (2) and (3) in paticular or is this jsut about generally bad
macosx compability.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Daniel]

Follow-up Comment #2, bug #24568 (project wesnoth):

> Why does there need to be any C++14-specific code paths in the first place?

For optimisation, similar to the 
#if c++11
config::config(config&& c)
#endif
constrcutor we had previously.

Note however that we don't use any c++14 core features just the c++14 standard
libary so it is theroretically possible to use it in c++11 too for example by
copying  parts of the c++14 standart libary from libc++ in our code. Since
standard libariers are usually quite compilcated becasue they make heavy use
of templates and use cryptic variablenames i didn't do that.

Also note, that even without those codes reason1 related to msvc is still
true.


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #22527] planning mode issue when attacked by AI

[Wedge009]

Follow-up Comment #2, bug #22527 (project wesnoth):

gfgtdf's commit resolves this. This can be marked as fixed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24552] Missing zoom scroll on mini-map (Windows)

[Wedge009]

Follow-up Comment #2, bug #24552 (project wesnoth):

I didn't know that was the intention. I've wondered why it only showed in
Windows as well.

Anyway, thanks for letting me know. Go ahead and close this if it's not going
to be resolved.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs