[Wesnoth-bugs] [bug #25139] UtBS lua error in final scenario

[krishna e bera]

Follow-up Comment #4, bug #25139 (project wesnoth):

yes it does fix the problem. tested fix. can close bug. thanks to
GregoryLundberg.

note: i submitted incorrect save file (after the error message instead of
before it).  correct one added for completeness.

(file #28866)
___

Additional Item Attachment:

File name: UtBS-The_Final_Confrontation.gz Size:21 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25146] Crash to desktop when campaigns selected

[Charles Dang]

Follow-up Comment #1, bug #25146 (project wesnoth):

As far as I know, none of us have observed this issue :/

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25142] mp_staging: reference binding to nullptr (UB)

[Daniel]

Follow-up Comment #1, bug #25142 (project wesnoth):

This mostlikeley needs a 


if (wesnothd_connection_ != nullptr) {
  chat.set_wesnothd_connection(*wesnothd_connection_);
}
else {
  chat.set_visible(invisible);
}


in
'https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_staging.cpp#L256'

I think this would not only fix this bug but also imporve the mp staging ui
for local mp games when the chatbox is hidden in this case.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25139] UtBS lua error in final scenario

[Daniel]

Update of bug #25139 (project wesnoth):

  Status:None => Fixed  

___

Follow-up Comment #3:

https://github.com/wesnoth/wesnoth/commit/3809a69a42a22839eea1238ef77db1e23577a0c5
looks like it fixes this issue.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25146] Crash to desktop when campaigns selected

[Dan Gerhards]

URL:
  

 Summary: Crash to desktop when campaigns selected
 Project: Battle for Wesnoth
Submitted by: beetlenaut
Submitted on: Mon 03 Oct 2016 11:15:53 AM PDT
Category: Bug
Severity: 5 - Blocker
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13..5+dev
Operating System: Linux

___

Details:

The game instantly crashes to the desktop when the campaign button or its
hotkey is pressed on the main screen. This has been happening for a couple
weeks, but I assumed it was obvious enough that it would be fixed quickly. It
must not be happening to everyone though. Running from the terminal shows this
error:

Caught general exception:
Failed to convert string "" to type CAMPAIGN_TYPE





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25139] UtBS lua error in final scenario

[krishna e bera]

Follow-up Comment #2, bug #25139 (project wesnoth):

Loading is okay for me, the error occurs after the dialogs but just before i
get to move.  
I didnt see any statistics.
I will grab a copy of master to check.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25144] LoW: crash when trying to start campaign

[Matthias Krüger]

Follow-up Comment #2, bug #25144 (project wesnoth):

Added crashlog of normal campaign.

The tutorial still works for some reason.

(file #28849)
___

Additional Item Attachment:

File name: offline_campaign_crash.log Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25144] LoW: crash when trying to start campaign

[Ignacio R. Morelle]

Update of bug #25144 (project wesnoth):

 Summary: LoW: crash when trying to launch multiplayer
campaign. => LoW: crash when trying to start campaign


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25144] LoW: crash when trying to launch multiplayer campaign.

[Matthias Krüger]

Follow-up Comment #1, bug #25144 (project wesnoth):

Update: this also happens when launching a regular offline campaign game. 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25144] LoW: crash when trying to launch multiplayer campaign.

[Matthias Krüger]

URL:
  

 Summary: LoW: crash when trying to launch multiplayer
campaign.
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 03 Oct 2016 10:03:03 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

There is a heap use after free before the slot-selection screen is reached.


(Multplayer -> Local Game -> Campaigns (select LOW) -> Create Game -> select
middle difficulty -> boom

Wesnoth 99e114a-Clean



___

File Attachments:


---
Date: Mon 03 Oct 2016 10:03:03 UTC  Name: LoW_online.log  Size: 12kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25143] MP: buffer overflow while assigning slots

[Matthias Krüger]

URL:
  

 Summary: MP: buffer overflow while assigning slots
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 03 Oct 2016 09:56:05 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Multiplayer Lobby
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Wesnot 99e114a-Clean

Get to the player-assigning screen of a MP game with 2 player map and play
around with the slots a bit. Unfortunately I failed to come up with a
reproducible patter, it just seemed to just fail after a few tries to assign
things.

crash log attached.







___

File Attachments:


---
Date: Mon 03 Oct 2016 09:56:05 UTC  Name: slotcrash.log  Size: 13kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25142] mp_staging: reference binding to nullptr (UB)

[Matthias Krüger]

URL:
  

 Summary: mp_staging: reference binding to nullptr (UB)
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 03 Oct 2016 09:45:37 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Multiplayer Lobby
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

wesnoth 99e114a-Clean

running with UBSAN_OPTIONS=print_stacktrace=1 ./build/wesnoth 

Multiplayer -> Local game -> Create Game
This was showing up:

/home/matthias/vcs/github/wesnoth/src/gui/dialogs/multiplayer/mp_staging.cpp:256:30:
runtime error: reference binding to null pointer of type 'struct
twesnothd_connection'
#0 0x3f0d578 in gui2::tmp_staging::pre_show(gui2::twindow&)
/home/matthias/vcs/github/wesnoth/src/gui/dialogs/multiplayer/mp_staging.cpp:256
#1 0x38f7338 in gui2::tdialog::show(CVideo&, unsigned int)
/home/matthias/vcs/github/wesnoth/src/gui/dialogs/dialog.cpp:64
#2 0x45f23ad in enter_connect_mode
/home/matthias/vcs/github/wesnoth/src/game_initialization/multiplayer.cpp:500
#3 0x45f3513 in enter_create_mode
/home/matthias/vcs/github/wesnoth/src/game_initialization/multiplayer.cpp:575
#4 0x45f3b73 in mp::start_local_game(CVideo&, config const&, saved_game&)
/home/matthias/vcs/github/wesnoth/src/game_initialization/multiplayer.cpp:782
#5 0x366f2ff in
game_launcher::play_multiplayer(game_launcher::mp_selection)
/home/matthias/vcs/github/wesnoth/src/game_launcher.cpp:839
#6 0x7e5708 in do_gameloop
/home/matthias/vcs/github/wesnoth/src/wesnoth.cpp:807
#7 0x7e5708 in main
/home/matthias/vcs/github/wesnoth/src/wesnoth.cpp:1053
#8 0x7f923b913730 in __libc_start_main (/lib64/libc.so.6+0x20730)
#9 0x85ae98 in _start
(/home/matthias/vcs/github/wesnoth/build/wesnoth+0x85ae98)




___

File Attachments:


---
Date: Mon 03 Oct 2016 09:45:37 UTC  Name: UB.log  Size: 2kB   By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25140] create game: crash when selecting same era twice

[Matthias Krüger]

URL:
  

 Summary: create game: crash when selecting same era twice
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 03 Oct 2016 09:37:46 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Game crashes when selecting the same era twice.

Log attached.



___

File Attachments:


---
Date: Mon 03 Oct 2016 09:37:46 UTC  Name: select_era_twice.log  Size: 14kB  
By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs