[Wesnoth-bugs] [bug #25523] addon manger is slow

2017-02-23 Thread Wedge009 
Follow-up Comment #4, bug #25523 (project wesnoth):

It's hard to quantify slowness because everyone's system is different. But
even on my system there seems to be a slight delay in bringing up a
newly-clicked list entry.

At the menu screen CPU usage is negligible. When I go to the add-on screen it
jumps to 50-75% of a single core. So it looks like there's something funny
going on there. Reminds me of the issue with the ocean animation filling up
the majority of the grid (like in the mermen campaign) but there's no
animation here...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25361] scrollbar in advance dialog

2017-02-23 Thread Charles Dang 
Update of bug #25361 (project wesnoth):

 Assigned to:None => vultraz


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25361] scrollbar in advance dialog

2017-02-23 Thread Charles Dang 
Update of bug #25361 (project wesnoth):

  Status:   Confirmed => Ready For Test 

___

Follow-up Comment #6:

Should be fixed here https://github.com/wesnoth/wesnoth/commit/e206586

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25504] heap use after free in new addon manager (downloading addon)

2017-02-23 Thread Matthias Krüger 
Follow-up Comment #3, bug #25504 (project wesnoth):

Ok, it looks like this is still present / present again.
It seems I can reproduce more or less reliably when downloading an addon of
very small size (sort by size, select something that is <10 kb).

New trace attached.

(file #29850)
___

Additional Item Attachment:

File name: addon_manager_crash_update.log Size:45 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25535] hex grid offset sometimes?

2017-02-23 Thread Lari Nieminen 
Update of bug #25535 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => zookeeper  

___

Follow-up Comment #2:

Commit 9fc1e497e1ed should fix this by making the grid be drawn even on the
off-map hexes (again).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25219] UB: left shift of -1000 on AI turn

2017-02-23 Thread Charles Dang 
Update of bug #25219 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => gfgtdf 

___

Follow-up Comment #2:

https://github.com/wesnoth/wesnoth/commit/73b1d79

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25393] heap use after free in MP map selection

2017-02-23 Thread Daniel 
Follow-up Comment #1, bug #25393 (project wesnoth):

same casue as https://gna.org/bugs/index.php?25534 not sure whether i shodul
make this is 'fixed' or 'dublicate' hmm.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25088] Random map generation: non-numerical seeds yield different maps

2017-02-23 Thread Daniel 
Update of bug #25088 (project wesnoth):

  Status:   Confirmed => Ready For Test 

___

Follow-up Comment #4:

I changed the text at the label:
https://github.com/wesnoth/wesnoth/commit/f693dbd8c22870b039b694840880ff1f41b69391
. Not the perfect fix but i hope its clearer now.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25217] unit moves on impassible terrain

2017-02-23 Thread Lari Nieminen 
Follow-up Comment #1, bug #25217 (project wesnoth):

For some reason, the spawns are given some altered movement costs, which
specifically includes impassable=3. It seems to have always been that way,
although I don't know the exact reasoning, as it can certainly lead to
unpredictable weirdness like that and the back mountains/wall are the only
impassable terrains anyway.

So, while it's not a technical bug, I don't think it'd be inappropriate to
call it a bug in the scenario design... even if it's intentional.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25535] hex grid offset sometimes?

2017-02-23 Thread Lari Nieminen 
Follow-up Comment #1, bug #25535 (project wesnoth):

It's not a problem with offsetting as such, it just happens due to the way the
grid images are drawn; no images are drawn on the off-map edge hexes, which
leaves the lines at the bottom row very dark and faint, which leads them to be
almost invisible against a dark background like void/cavewall/etc.

However, it's of course a legit problem and it'd be great if it could be
fixed. Seeing how terrains draw correctly at the edges, it might not even be
particularly hard.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25536] MP: exiting from start scenario screen in multiplayer campaign overflows buffer

2017-02-23 Thread Charles Dang 
Follow-up Comment #2, bug #25536 (project wesnoth):

Actually, better fix:
https://github.com/wesnoth/wesnoth/commit/0474c2eb1f7e05942ff0b1abf45290e672cfb93d

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25536] MP: exiting from start scenario screen in multiplayer campaign overflows buffer

2017-02-23 Thread Charles Dang 
Update of bug #25536 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => vultraz

___

Follow-up Comment #1:

https://github.com/wesnoth/wesnoth/commit/bd47e75d32e07a29c204ceb71dd7a837486ad73a
should fix it. Esc canceling shouldn't be allowed in the first place.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25473] OOS when redoing certain action that use synced choices

2017-02-23 Thread Daniel 
Update of bug #25473 (project wesnoth):

  Status: Invalid => None   

___

Follow-up Comment #2:

My bad i didnt see the first_time_only=no in my exampel code bloew, marking as
'none'

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25473] OOS when redoing certain action that use synced choices

2017-02-23 Thread Daniel 
Update of bug #25473 (project wesnoth):

  Status:None => Invalid

___

Follow-up Comment #1:

After looking at this again i think this code is not meant to be OOS safe. Its
actually the same code that is meantioned as an oos-causing example at
https://wiki.wesnoth.org/DirectActionsWML#.5Ballow_undo.5D. Makrin as invlid

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25536] MP: exiting from start scenario screen in multiplayer campaign overflows buffer

2017-02-23 Thread Matthias Krüger 
URL:
  

 Summary: MP: exiting from start scenario screen in
multiplayer campaign overflows buffer
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Thu 23 Feb 2017 06:03:34 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Multiplayer
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

wesnoth e985315-Clean

multiplayer
local game
select campaigns and LOW
create game 
difficulty: Lord
when choosing the start scenario, press escape
=> heap buffer overflow

log attached



___

File Attachments:


---
Date: Thu 23 Feb 2017 06:03:34 PM UTC  Name: LOW_multiplayer_escape.log  Size:
6kB   By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25534] crash (use after free); assign side to map position (north/south etc)

2017-02-23 Thread Jyrki Vesterinen 
Update of bug #25534 (project wesnoth):

  Status:None => Fixed  

___

Follow-up Comment #1:

Fixed:
https://github.com/wesnoth/wesnoth/commit/e98531541de78317e088ecd96d849a57087fd503

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25535] hex grid offset sometimes?

2017-02-23 Thread Matthias Krüger 
URL:
  

 Summary: hex grid offset sometimes?
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Thu 23 Feb 2017 02:41:21 PM UTC
Category: Bug
Severity: 2 - Minor
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Multiplayer
Local Game
Map: 2p - Den of Onis

game resolution was 1034x861

The hex grid looks kinda offset.

Screenshot attached.



___

File Attachments:


---
Date: Thu 23 Feb 2017 02:41:21 PM UTC  Name: grid.png  Size: 1007kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25534] crash (use after free); assign side to map position (north/south etc)

2017-02-23 Thread Matthias Krüger 
URL:
  

 Summary: crash (use after free); assign side to map position
(north/south etc)
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Thu 23 Feb 2017 02:33:24 PM UTC
Category: Bug
Severity: 4 - Important
Priority: 5 - Normal
  Item Group: Multiplayer Lobby
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Battle for Wesnoth v1.13.6+dev (e24336a-Clean)

Muliplayer
Local Game
select any map
Create Game
now, click on "north" or "south" or whatever position of any player and click
somewhere on the screen again
=> heap use after free

ASAN log attached.



___

File Attachments:


---
Date: Thu 23 Feb 2017 02:33:24 PM UTC  Name: mp_side_crash.log  Size: 26kB  
By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs