[Wesnoth-bugs] [bug #25539] Assertion Failed - toggle_button usage

2017-02-24 Thread Jyrki Vesterinen 
Follow-up Comment #1, bug #25539 (project wesnoth):

Fixed:
https://github.com/wesnoth/wesnoth/commit/0dbf686c4ffdac2421059d3e3be14b165aa06ef0

There were two bugs here. The first, caught by the assertion, was that the
value change callback was called too early, before the listbox had swapped the
internal grid. As a result, when the callback tried to find the containing
listbox, it couldn't find it and the game crashed. I added a check to prevent
the callback from being called too early.

The second problem was that a different value change callback toggled the
value of the checkbox. As a result, when the checkbox was initially set, the
callback cleared it, and clearing it fired the same callback, which then went
on to set the checkbox, firing the same callback, which cleared the checkbox,
etc. I fixed that bug as well.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25539] Assertion Failed - toggle_button usage

2017-02-24 Thread Jyrki Vesterinen 
Update of bug #25539 (project wesnoth):

  Status:None => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25540] Add-on list randomly disappears when filter excludes all add-ons

2017-02-24 Thread Jyrki Vesterinen 
Follow-up Comment #1, bug #25540 (project wesnoth):

The screenshot exceeds the attachment size limit, so I uploaded it here:
https://s19.postimg.org/sjo3c7skj/Add_on_list_gone.png

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25540] Add-on list randomly disappears when filter excludes all add-ons

2017-02-24 Thread Jyrki Vesterinen 
URL:
  

 Summary: Add-on list randomly disappears when filter excludes
all add-ons
 Project: Battle for Wesnoth
Submitted by: jyrkive
Submitted on: Sat 25 Feb 2017 05:10:39 AM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.6+dev
Operating System: Windows

___

Details:

Steps to reproduce:

0 Open add-on manager
0 Write "debug" to the search field
0 If the bug doesn't appear, clear the field and write "debug" again

Actual result:

The add-on list disappears and the description of whichever add-on is selected
fills the entire window. Screenshot attached.

The bug doesn't occur 100 % of the time.

Clearing the search field makes the list appear again.

Additional information:

I ran into this bug because I tried to find Gui Debug Tools
 from the add-on server in
order to reproduce bug #25539. The add-on appears to not be in the server yet;
thus, my search triggered the bug.

I tested with a debug build. The bug may be timing related, and therefore it
may not be reproducible with release builds.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25539] Assertion Failed - toggle_button usage

2017-02-24 Thread Charles Dang 
Update of bug #25539 (project wesnoth):

 Assigned to:None => jyrkive


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25539] Assertion Failed - toggle_button usage

2017-02-24 Thread SigurdFireDragon 
URL:
  

 Summary: Assertion Failed - toggle_button usage
 Project: Battle for Wesnoth
Submitted by: sigurdfdragon
Submitted on: Fri 24 Feb 2017 09:30:30 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.6+dev
Operating System: Win 7 x64

___

Details:

The commit (bisected):
https://github.com/wesnoth/wesnoth/commit/8be7de39f90493ff5955c663f78361c23460282d

Introduced an:

Assertion Failed
File: src\gui\auxiliary\find_widget.hpp, Line 45
Expression: result

To reproduce, use the the Unit or Side Debug right-click commands in the
add-on Gui Debug Tools (https://github.com/sigurdfdragon/Gui_Debug_Tools/)

From looking at the commit, it seems possible this may affect any other add-on
that uses toggle_button via lua, but at the moment, GDT is the only one that
I'm aware of using toggle_button. It may be helpful to test if this bug occurs
with another add-on.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25538] attack prediction: division by zero (test scenario)

2017-02-24 Thread Daniel 
Follow-up Comment #1, bug #25538 (project wesnoth):

The division by zero is intenational there.

The integer overflow might not be though, maybe we should change that ai code
to use floats instead.


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25538] attack prediction: division by zero (test scenario)

2017-02-24 Thread Jyrki Vesterinen 
Update of bug #25538 (project wesnoth):

 Assigned to:None => jyrkive


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25538] attack prediction: division by zero (test scenario)

2017-02-24 Thread Matthias Krüger 
URL:
  

 Summary: attack prediction: division by zero (test scenario)
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Fri 24 Feb 2017 12:17:39 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

UBSAN_OPTIONS=print_stacktrace=1 ./build/wesnoth -t
end turn
(on dialogs, just confirm the first preselected option)

/home/matthias/vcs/github/wesnoth/src/attack_prediction.cpp:1282:59: runtime
error: division by zero
/home/matthias/vcs/github/wesnoth/src/attack_prediction.cpp:1284:59: runtime
error: division by zero
/home/matthias/vcs/github/wesnoth/src/ai/contexts.cpp:1136:44: runtime error:
signed integer overflow: 153900 * 2 cannot be represented in type 'int'


I attached full backtraces of the errors.




___

File Attachments:


---
Date: Fri 24 Feb 2017 12:17:39 PM UTC  Name: attack_prediction.log  Size: 22kB
  By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25504] heap use after free in new addon manager (downloading addon)

2017-02-24 Thread Wedge009 
Update of bug #25504 (project wesnoth):

  Status:   Fixed => Confirmed  
 Assigned to:None => vultraz

___

Follow-up Comment #4:

Reverting status at mk's request.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25088] Random map generation: non-numerical seeds yield different maps

2017-02-24 Thread Wedge009 
Update of bug #25088 (project wesnoth):

  Status:  Ready For Test => Fixed  

___

Follow-up Comment #7:

Righty-o, then!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25088] Random map generation: non-numerical seeds yield different maps

2017-02-24 Thread Matthias Krüger 
Follow-up Comment #6, bug #25088 (project wesnoth):

Yeah, can be closed as resolved IMO :)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25088] Random map generation: non-numerical seeds yield different maps

2017-02-24 Thread Wedge009 
Follow-up Comment #5, bug #25088 (project wesnoth):

I suppose that helps.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25361] scrollbar in advance dialog

2017-02-24 Thread Wedge009 
Update of bug #25361 (project wesnoth):

  Status:  Ready For Test => Fixed  

___

Follow-up Comment #7:

Confirming fixed for at least Elvish Shaman in recruit dialogue and Troll
Whelp in advance dialogue.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs