[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Ignacio R. Morelle]

Update of bug #24568 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Sebastia Kölle]

Update of bug #24568 (project wesnoth):

Category: Bug => Feature Request
  Status:None => Fixed  
 Assigned to:None => aquileia   

___

Follow-up Comment #6:

Implemented as of 23abf97f36.

As the build currently fails due to a conflict between make_reverse_iterator
from std:: and boost::, the build is marked as an allowed failure.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Pentarctagon]

Follow-up Comment #5, bug #24568 (project wesnoth):

There is this 
ppa which has up to gcc 5.3.0 for Trusty/14.04.  It even has a gcc 6, if you
really want to get ahead of the game :P

Also, not sure how related this is, but there was also this
 previous issue between std and boost.  Though
based on the boost issue report, that's more a c++11 than c++14 problem.

Another solution would be to just wait for travis to support Xenial/16.04,
which will have gcc 5.3.1 by default  as
well as boost  1.58, though
that apparently won't be happening soon
.  There does seem to be a
feature to use your own OS image, however that sounds like it would probably
be more trouble than it's worth.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Daniel]

Follow-up Comment #4, bug #24568 (project wesnoth):

> unless the intention is to make the feature available and fully-supported
for a broader audience (e.g. people on GCC 5 and later). 

This is suppoerted for gcc5 and later. The check in the cude is currently like
"#if _MSC_VER >= 1900 || __cplusplus >= 201402L" where the second check is for
the gcc/clang case.

> You could just add a PPA that includes the right GCC version..

Hmm yes the problems is that i really don't know much about this stuff, i
tried to find some other github porjestcs that use gcc5 for their travis build
to copy from their travis.yml but that didn't work eigher.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Ignacio R. Morelle]

Follow-up Comment #3, bug #24568 (project wesnoth):

It seems rather excessive to optimize this early for a compiler that only a
couple of people's private builds (and no production builds) can benefit from,
unless the intention is to make the feature available and fully-supported for
a broader audience (e.g. people on GCC 5 and later
).

The issue with Travis is that last time I checked they did not provide build
environments running anything newer than Ubuntu trusty, which only includes
gcc 4.8 at most. You could just add a PPA that includes the right GCC version,
but it's up to you to figure out what to do if the PPA maintainers decide to
switch versions/close it down/drop support for trusty/insert malware in the
compiler binaries; the rest should be relatively simple. I'm sure an actual
Ubuntu user could give some recommendations here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Daniel]

Follow-up Comment #2, bug #24568 (project wesnoth):

> Why does there need to be any C++14-specific code paths in the first place?

For optimisation, similar to the 
#if c++11
config::config(config&& c)
#endif
constrcutor we had previously.

Note however that we don't use any c++14 core features just the c++14 standard
libary so it is theroretically possible to use it in c++11 too for example by
copying  parts of the c++14 standart libary from libc++ in our code. Since
standard libariers are usually quite compilcated becasue they make heavy use
of templates and use cryptic variablenames i didn't do that.

Also note, that even without those codes reason1 related to msvc is still
true.


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Ignacio R. Morelle]

Follow-up Comment #1, bug #24568 (project wesnoth):

Why does there need to be any C++14-specific code paths in the first place?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

[Daniel]

URL:
  

 Summary: Travis needs a c++14 build
 Project: Battle for Wesnoth
Submitted by: gfgtdf
Submitted on: Do 07 Apr 2016 23:06:28 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13+dev
Operating System: linux

___

Details:

Travis needs a c++14 build. 

There are multiple reaons for this:
- msvc doesn't have different c++ modes (it always uses all featutes available
in that msvc version) so it usualyl complies as c++14.
- Some or our codes are c++14 specific and are not tested by travis currently

This sepcially requires newer version of gcc/clang and specially newer
versions of libstdc++ to be installed on our travis build. But non of the
currently active devs knows how to do this. So we currently have no c++14
build.





___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs