[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Charles Dang]

Update of bug #24978 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Wedge009]

Update of bug #24978 (project wesnoth):

 Assigned to:None => wedge009   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Charles Dang]

Update of bug #24978 (project wesnoth):

  Status:None => Fixed  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Wedge009]

Follow-up Comment #3, bug #24978 (project wesnoth):

Have submitted PR #750 to resolve this. Works for me, at least.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Wedge009]

Follow-up Comment #2, bug #24978 (project wesnoth):

Sorry, my mistake. I forgot to take into account the damage resistances of the
defending unit. So 1.12 is correct in all cases, and 1.13 is only incorrect
with respect to the number of attacks (in the attack window). The damage
points are correct because it's taking resistances into account.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Wedge009]

Follow-up Comment #1, bug #24978 (project wesnoth):

Confirmed, although at least the damage calculation graphs show the correct
number of attacks.

The strange thing is that a similar but distinct problem exists for 1.12:
side-bar, attack window and and damage calculations all show different numbers
(damage points and number of attacks). Without yet looking at the code this
suggests to me that there are different functions involved, all perhaps using
different rounding methods which result in different values.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Alessandro]

Additional Item Attachment, bug #24978 (project wesnoth):

File name: rsz_3swarm.png Size:466 KB


___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24978] Wrong number of hits for swarm attack in attack window

[Alessandro]

URL:
  

 Summary: Wrong number of hits for swarm attack in attack
window
 Project: Battle for Wesnoth
Submitted by: zepko
Submitted on: lun 15 ago 2016 16:56:55 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Units
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.5
Operating System: Ubuntu 16.04

___

Details:

The number of hits of a swarm attack must be decreased according to the unit's
hitpoints. This does not appear in the attack window, where the number of hits
is fixed to the maximum.

See the attached screenshot, where the attacked unit has 1 HP, so it should
have 0 hits (as correctly appears in the sidebar), but has instead 10 hits.




___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs