[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-11-07 Thread Charles Dang 
Update of bug #25089 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-10-20 Thread Daniel 
Update of bug #25089 (project wesnoth):

  Status:  Ready For Test => Fixed  


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-10-20 Thread Matthias Krüger 
Follow-up Comment #4, bug #25089 (project wesnoth):

I could not longer reproduce; resizing seems to work now.

Here and there the editor still crashed due to invalid terrain being accessed
but this is a different issue (  https://gna.org/bugs/index.php?25161 ).



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-10-20 Thread Daniel 
Update of bug #25089 (project wesnoth):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

https://github.com/wesnoth/wesnoth/commit/7b44cee405f1cbbcf5515f6fee1540b55c48dd36

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-10-20 Thread Wedge009 
Follow-up Comment #2, bug #25089 (project wesnoth):

Whoops, sorry, was looking at the wrong part of the log.


void editor_map::expand_right(int count, const t_translation::t_terrain &
filler)
{
t_translation::t_map tiles_new(tiles_.w + count, tiles_.h);
w_ += count;
for (int x = 0, x_end = tiles_.w; x != x_end; ++x) {
for (int y = 0, y_end = tiles_.h; y != y_end; ++y) {
tiles_new.get(x, y) = tiles_.get(x, y);
}
}
for (int x = tiles_.w, x_end = tiles_.w + count; x != x_end; ++x) {
for (int y = 0, y_end = tiles_.h; y != y_end; ++y) {
tiles_new.get(x, y) = filler == 
t_translation::NONE_TERRAIN ?
tiles_.get(count - 1, y) : filler;
}
}
tiles_ = tiles_new;
}


I suppose it's possible for something to go out of bounds here, but I really
can't really see what's going on and I didn't find anything obviously bad
while debugging.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-10-20 Thread Wedge009 
Update of bug #25089 (project wesnoth):

 Release: git => 1.13.5+dev 

___

Follow-up Comment #1:

This looks like the same as bug #25079 and bug #25080.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25089] editor: buffer overflow while expanding map

2016-09-20 Thread Matthias Krüger 
URL:
  

 Summary: editor: buffer overflow while expanding map
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Tue 20 Sep 2016 02:27:14 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Editor
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

wesnoth f3e9540-Clean
Start editor
expand the default map to 200x200 with
copy edge terrain == true
click the middle grid field of the 9x9 grid.
When resizing the map now, ASAN reports a buffer oveflow

log attached.



___

File Attachments:


---
Date: Tue 20 Sep 2016 02:27:14 PM UTC  Name: editor_buffer_overflow.log  Size:
6kB   By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs