[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Charles Dang]

Update of bug #25106 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Daniel]

Update of bug #25106 (project wesnoth):

  Status:  Ready For Test => Fixed  


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Matthias Krüger]

Follow-up Comment #4, bug #25106 (project wesnoth):

Looks good, thanks.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Daniel]

Follow-up Comment #3, bug #25106 (project wesnoth):

wrong link.
https://github.com/wesnoth/wesnoth/commit/ac9729f6127fc5c3548553b2cafdf389db1081e9

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Daniel]

Update of bug #25106 (project wesnoth):

  Status:   Confirmed => Ready For Test 

___

Follow-up Comment #2:

https://github.com/wesnoth/wesnoth/blob/master/src/pathfind/pathfind.cpp

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25106] assertion failure when shroud/FoW update undelayed

[Wedge009]

Update of bug #25106 (project wesnoth):

  Status:None => Confirmed  
 Release: git => 1.13.5+dev 
Operating System:   linux => All

___

Follow-up Comment #1:

vision_path() in pathfind/pathfind.cpp:592 is trying to grab a pointer to the
unit that's just moved. But when units/map.hpp tries to validate the unit for
dereferencing (line 242), it returns false. I'm really not sure why this is,
but it looks like another case of references not carrying through with the
game resources restructuring.


wesnoth.exe!unit_map::iterator_base::operator*()
Line 186C++
wesnoth.exe!pathfind::vision_path::vision_path(const movetype::terrain_costs &
view_costs, bool slowed, int sight_range, const map_location & loc, const
std::map > & jamming_map) Line 591 C++
wesnoth.exe!actions::shroud_clearer::clear_unit(const map_location & view_loc,
team & view_team, unsigned int viewer_id, int sight_range, bool slowed, const
movetype::terrain_costs & costs, const map_location & real_loc, const
std::set *
known_units, unsigned int * enemy_count, unsigned int * friend_count,
actions::move_unit_spectator * spectator, bool instant) Line 362C++
wesnoth.exe!actions::shroud_clearer::clear_unit(const map_location & view_loc,
team & view_team, const actions::clearer_info & viewer, bool instant) Line
442 C++
wesnoth.exe!actions::undo_list::apply_shroud_changes() Line 473 C++
wesnoth.exe!actions::undo_list::commit_vision() Line 247C++
wesnoth.exe!synced_command_func_update_shroud(const config & __formal, bool
use_undo, bool __formal, std::function,std::allocator >
const &,bool)> error_handler) Line 386  C++
wesnoth.exe!synced_context::run(const
std::basic_string &
commandname, const config & data, bool use_undo, bool show, std::function,std::allocator >
const &,bool)> error_handler) Line 75   C++
wesnoth.exe!synced_context::run_and_store(const
std::basic_string &
commandname, const config & data, bool use_undo, bool show, std::function,std::allocator >
const &,bool)> error_handler) Line 100  C++
wesnoth.exe!synced_context::run_and_throw(const
std::basic_string &
commandname, const config & data, bool use_undo, bool show, std::function,std::allocator >
const &,bool)> error_handler) Line 110  C++
wesnoth.exe!events::menu_handler::update_shroud_now(int __formal) Line
465 C++
wesnoth.exe!events::menu_handler::toggle_shroud_updates(int side_num) Line
460 C++
wesnoth.exe!playsingle_controller::hotkey_handler::toggle_shroud_updates()
Line 67 C++
wesnoth.exe!hotkey::command_executor::execute_command(const
hotkey::hotkey_command & cmd, int __formal, bool press) Line 233C++
wesnoth.exe!play_controller::hotkey_handler::execute_command(const
hotkey::hotkey_command & cmd, int index, bool press) Line 263   C++
wesnoth.exe!hotkey::execute_command(const hotkey::hotkey_command & command,
hotkey::command_executor * executor, int index, bool press) Line 581C++
wesnoth.exe!hotkey::command_executor::show_menu(const
std::vector,std::allocator > > & items_arg, int xloc, int yloc, bool __formal, display & gui) Line
386 C++
wesnoth.exe!play_controller::hotkey_handler::show_menu(const
std::vector,std::allocator > > & items_arg, int xloc, int yloc, bool context_menu, display & disp) Line
471 C++
wesnoth.exe!controller_base::show_menu(const
std::vector,std::allocator > > & items_arg, int xloc, int yloc, bool context_menu, display & disp) Line
309 C++
wesnoth.exe!controller_base::play_slice(bool is_delay_enabled) Line 221 C++
wesnoth.exe!play_controller::play_slice_catch() Line 1068   C++
wesnoth.exe!playmp_controller::play_human_turn() Line 166   C++
wesnoth.exe!playsingle_controller::play_side_impl() Line 388C++
wesnoth.exe!playmp_controller::play_side_impl() Line 85 C++
wesnoth.exe!play_controller::play_side() Line 1158  C++
wesnoth.exe!play_controller::play_turn() Line 1197  C++
wesnoth.exe!playsingle_controller::play_scenario_main_loop() Line 183   C++
wesnoth.exe!playsingle_controller::play_scenario(const config & level) Line
264 C++
wesnoth.exe!campaign_controller::playmp_scenario(end_level_data & end_level)
Line 231C++
wesnoth.exe!campaign_controller::play_game() Line 290   C++