[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-31 Thread Gregory A Lundberg 
Update of bug #25214 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Daniel 
Update of bug #25214 (project wesnoth):

  Status:None => Fixed  

___

Follow-up Comment #7:

https://github.com/wesnoth/wesnoth/commit/806a388b9d39707fa293b6747598d04bf2633a36

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Wedge009 
Follow-up Comment #6, bug #25214 (project wesnoth):

As mentioned on #wesnoth-dev, this seems to let Lua catch the division by zero
instead of making Wesnoht crash.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Daniel 
Follow-up Comment #5, bug #25214 (project wesnoth):

please test whetehr this commit
https://github.com/wesnoth/wesnoth/commit/de96f8c042698f7e73389c0bfe13173c067618f6
(not yet im master!) fixes the issue.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Daniel 
Follow-up Comment #4, bug #25214 (project wesnoth):

I think he problem here is not that this gives an error, the problem is that
this error makes wesnoth crash instead of giving a proper error message. If
such an erro mkaes wewsnoth crash, thats an bug of the c++ side of the lua api
that shoduld be fixed.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Wedge009 
Update of bug #25214 (project wesnoth):

 Assigned to:wedge009 => None   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Wedge009 
Update of bug #25214 (project wesnoth):

  Status:   Fixed => None   

___

Follow-up Comment #3:

Then it begs the question of how far do you want to go in accounting for every
single illegal possibility in something that is obviously not meant for normal
user operation. Happy for someone else to take care of this if it's deemed
necessary.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-22 Thread Matthias Krüger 
Follow-up Comment #2, bug #25214 (project wesnoth):

It is still possible to cheat around the fix by doing something like

x / (1-1)


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-21 Thread Wedge009 
Update of bug #25214 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => wedge009   
 Release: git => 1.13.5+dev 
Operating System:   linux => All

___

Follow-up Comment #1:

Uh, it's a test scenario. Probably can get away with it not being polished.
:p

Regardless:
https://github.com/wesnoth/wesnoth/commit/50146bc509b18c9d9b5ab584a45497495af591a0

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25214] crashes when dividing by 0 in test scenario

2016-10-21 Thread Matthias Krüger 
URL:
  

 Summary: crashes when dividing by 0 in test scenario
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Fri 21 Oct 2016 22:57:19 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

launch wesnoth -t
move unit to "open sesame" to unlock math foo
move unit to "math test"
hit enter to set number to 0
select "divide by something" in the dialog
enter 0
=> crash



___

File Attachments:


---
Date: Fri 21 Oct 2016 22:57:19 UTC  Name: zeroDiv.log  Size: 3kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs