[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Charles Dang]

Update of bug #25292 (project wesnoth):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Hironori Fujimoto]

Follow-up Comment #9, bug #25292 (project wesnoth):

bug #25334 is not fixed. It seems that there is another cause.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Wedge009]

Update of bug #25292 (project wesnoth):

  Status:   Confirmed => Fixed  

___

Follow-up Comment #8:

Appears to be resolved via PR #917. Thanks!

Didn't appear to help with bug #25334, though. Are you still getting crashes
on that one?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Hironori Fujimoto]

Follow-up Comment #7, bug #25292 (project wesnoth):

I found a resolution.
Simply, add_text_item() is not supported scaled font.
In add_text_item(), font::get_rendered_text() and font::line_width() are not
use preferences::scaled_font() inside, so we should change their font size
argument to use scaled_font() value.

I will commit patch.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Wedge009]

Follow-up Comment #6, bug #25292 (project wesnoth):

It's been a while since I looked at this one. It sounds to me that the font
scaling function never worked fully as intended. Do you have any idea what
changes with scaling > 115% to cause the excessive recursion?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Hironori Fujimoto]

Follow-up Comment #5, bug #25292 (project wesnoth):

I am debugging this bug now, and I noticed size of texts in help pages are not
changed if font scaling is not 100%.
help_text_area::add_text_item() uses split_in_width() and render_text().
In add_text_item(), split_in_width() uses font scale but render_text()
doesn't, so word wrapping position is wrong if font scale is not 100%.

And, if font scale is more than 115%, add_text_item() is called recursively
many many times.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Wedge009]

Follow-up Comment #4, bug #25292 (project wesnoth):

It appears this affects bug #25334 too.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Wedge009]

Update of bug #25292 (project wesnoth):

  Status:None => Confirmed  
Operating System:  Windows 10 => All

___

Follow-up Comment #3:

Oh I see, I hadn't noticed that feature.

For me the crash in Help happens at 115% or above (didn't try shrinking the
font). It happens in the vcruntime.dll from attribute_value [](const
string ) in Windows, but I also get a segmentation fault in Linux. Going
through the debugger, I'm not sure why it would complain - the
value['font_scale'] appears to be valid.

I find the comment at preferences.cpp:437 (font_scaling()) interesting: 'Clip
at 80 because if it's too low it'll cause crashes'. It implies to me that the
interaction of the font scaling factor with the GUI might not be reliable.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Inky]

Follow-up Comment #2, bug #25292 (project wesnoth):

No, I mean changing font size in-game using the slider under Preferences ->
Display.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25292] Crash when viewing in-game Help with large font size.

[Wedge009]

Follow-up Comment #1, bug #25292 (project wesnoth):

I gather font size means what you have set the OS to render fonts? I thought
high DPI fonts were supposed to be improved in Windows 10, but I'm running at
114% in Windows 7 without issues.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs