[Wesnoth-bugs] [bug #25523] addon manger is slow

[Wedge009]

Follow-up Comment #9, bug #25523 (project wesnoth):

Seems okay to me, thanks!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Jyrki Vesterinen]

Update of bug #25523 (project wesnoth):

  Status:None => Fixed  

___

Follow-up Comment #7:

Fixed. Vultraz merged the pull request. (Thanks!)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Jyrki Vesterinen]

Follow-up Comment #6, bug #25523 (project wesnoth):

https://github.com/wesnoth/wesnoth/pull/963

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Jyrki Vesterinen]

Update of bug #25523 (project wesnoth):

 Assigned to:None => jyrkive


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Charles Dang]

Follow-up Comment #5, bug #25523 (project wesnoth):

Really good way to repro is just use the arrow keys to scroll quickly through
the list. Certain entries take longer to come up than others, though the
difference on my system is pretty negligible.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Wedge009]

Follow-up Comment #4, bug #25523 (project wesnoth):

It's hard to quantify slowness because everyone's system is different. But
even on my system there seems to be a slight delay in bringing up a
newly-clicked list entry.

At the menu screen CPU usage is negligible. When I go to the add-on screen it
jumps to 50-75% of a single core. So it looks like there's something funny
going on there. Reminds me of the issue with the ocean animation filling up
the majority of the grid (like in the mermen campaign) but there's no
animation here...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Daniel]

Follow-up Comment #3, bug #25523 (project wesnoth):

Hmm i think you are right, when i tested it now again it wasn't as related to
the feedback rl as it seemed when i tested it the first time.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Daniel]

Follow-up Comment #2, bug #25523 (project wesnoth):

> Just throwing a out guess that it's the various scroll labels, esp Author,
Version, and Description.

Hmm but this slowness does not happen when i just switch selection between
addons that don't specify a feedback url. It only happens if i switch
selection bettwen two addons that have a differnet feeback url

If i could debug here i would just put a brakpount in
window::invalidate_layout and look at the callstack.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Charles Dang]

Follow-up Comment #1, bug #25523 (project wesnoth):

Just throwing a out guess that it's the various scroll labels, esp Author,
Version, and Description.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #25523] addon manger is slow

[Daniel]

URL:
  

 Summary: addon manger is slow
 Project: Battle for Wesnoth
Submitted by: gfgtdf
Submitted on: So 19 Feb 2017 14:31:38 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.6+dev
Operating System: windows

___

Details:

The addon manager is currently quite slow when selecting new list entries.
This doesn't happen on all entries though, i suspect that is somehow related
to the feedback url textbox since is seems not to happen if the feedback url
of the next addon is the same as the feedbackurl of the previous addon. I
further suspect that someting is calling window->invalidate_layout() i
couldn't firgue out how exactly though.




___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs