Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen"

2012-12-04 Thread Ian Hickson

On Tue, 31 Jul 2012, Adam Barth wrote:
>
> It's not clear to me from the spec how the allowfullscreen attribute 
> works.  It appears to be mentioned only in the security and privacy 
> considerations section.

It wasn't specced. Finally got around to fixing that.


> For example, suppose I have three frames:
>
> Main frame: a.html
>   -> 
> -> 
> 
> Can c.html go full screen?  Where is that specified?

HTML (if I got it right) says no.


On Tue, 31 Jul 2012, Adam Barth wrote:
> 
> Even if we don't use the iframe@sandbox syntax, it might be worth 
> re-using the spec machinery because it's good at solving problems like 
> the above.

Please do take a look at the patch and see if it does what you think it 
should. Some of the machinery is indeed re-used:

   http://html5.org/tools/web-apps-tracker?from=7563&to=7564

-- 
Ian Hickson   U+1047E)\._.,--,'``.fL
http://ln.hixie.ch/   U+263A/,   _.. \   _\  ;`._ ,.
Things that are impossible just take longer.   `._.-(,_..'--(,_..'`-.;.'


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-08-01 Thread Vincent Scheib
Thank you Adam, ROC, Anne. I commented on issue.


On Wed, Aug 1, 2012 at 2:05 AM, Anne van Kesteren  wrote:

> On Wed, Aug 1, 2012 at 11:04 AM, Anne van Kesteren 
> wrote:
> > https://www.w3.org/Bugs/Public/show_bug.cgi?id=17838
> >
> > I did not want to define new HTML features in a separate draft.
>
> So Vincent, if you want to argue for a different design, that bug
> would be the place I think. I do not really care either way, I just
> went with what roc came up with.
>
>
> --
> http://annevankesteren.nl/
>


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-08-01 Thread Anne van Kesteren
On Wed, Aug 1, 2012 at 11:04 AM, Anne van Kesteren  wrote:
> https://www.w3.org/Bugs/Public/show_bug.cgi?id=17838
>
> I did not want to define new HTML features in a separate draft.

So Vincent, if you want to argue for a different design, that bug
would be the place I think. I do not really care either way, I just
went with what roc came up with.


-- 
http://annevankesteren.nl/


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-08-01 Thread Anne van Kesteren
On Wed, Aug 1, 2012 at 12:33 AM, Adam Barth  wrote:
> Main frame: a.html
>   -> 
> -> 
>
> Can c.html go full screen?  Where is that specified?

https://www.w3.org/Bugs/Public/show_bug.cgi?id=17838

I did not want to define new HTML features in a separate draft.


-- 
http://annevankesteren.nl/


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Adam Barth
On Tue, Jul 31, 2012 at 10:24 PM, Robert O'Callahan
 wrote:
> On Wed, Aug 1, 2012 at 10:33 AM, Adam Barth  wrote:
>> It's not clear to me from the spec how the allowfullscreen attribute
>> works.  It appears to be mentioned only in the security and privacy
>> considerations section.  For example, suppose I have three frames:
>>
>> Main frame: a.html
>>   -> 
>> -> 
>>
>> Can c.html go full screen?  Where is that specified?
>
> The intent is that no, it can't. You're right that this is currently
> unspecified.

Even if we don't use the iframe@sandbox syntax, it might be worth
re-using the spec machinery because it's good at solving problems like
the above.

Adam


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Robert O'Callahan
On Wed, Aug 1, 2012 at 10:33 AM, Adam Barth  wrote:

> It's not clear to me from the spec how the allowfullscreen attribute
> works.  It appears to be mentioned only in the security and privacy
> considerations section.  For example, suppose I have three frames:
>
> Main frame: a.html
>   -> 
> -> 
>
> Can c.html go full screen?  Where is that specified?
>

The intent is that no, it can't. You're right that this is currently
unspecified.

Rob
-- 
“You have heard that it was said, ‘Love your neighbor and hate your enemy.’
But I tell you, love your enemies and pray for those who persecute you,
that you may be children of your Father in heaven. ... If you love those
who love you, what reward will you get? Are not even the tax collectors
doing that? And if you greet only your own people, what are you doing more
than others?" [Matthew 5:43-47]


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Adam Barth
It's not clear to me from the spec how the allowfullscreen attribute
works.  It appears to be mentioned only in the security and privacy
considerations section.  For example, suppose I have three frames:

Main frame: a.html
  -> 
-> 

Can c.html go full screen?  Where is that specified?

Adam


On Tue, Jul 31, 2012 at 3:26 PM, Adam Barth  wrote:
> It looks like the ability to go full screen is off-by-default and then
> enabled via the attribute.  If we used iframe@sandbox, the ability
> would be on-by-default for non-sandboxed iframes.
>
> Adam
>
>
> On Tue, Jul 31, 2012 at 3:11 PM, Vincent Scheib  wrote:
>> [correcting Anne van Kesteren's email]
>>
>>
>> On Tue, Jul 31, 2012 at 3:03 PM, Vincent Scheib  wrote:
>>
>>> I'm currently implementing Pointer Lock [1] in WebKit, which was adjusted
>>> recently to mimic Fullscreen [2].
>>>
>>> Why does the Fullscreen specification use an iframe attribute
>>> allowfullscreen to permit/restrict iframe capabilities instead of using
>>> iframe sandbox="allow-fullscreen"?
>>>
>>> [1] http://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html
>>> [2] http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
>>>
>>>


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Adam Barth
It looks like the ability to go full screen is off-by-default and then
enabled via the attribute.  If we used iframe@sandbox, the ability
would be on-by-default for non-sandboxed iframes.

Adam


On Tue, Jul 31, 2012 at 3:11 PM, Vincent Scheib  wrote:
> [correcting Anne van Kesteren's email]
>
>
> On Tue, Jul 31, 2012 at 3:03 PM, Vincent Scheib  wrote:
>
>> I'm currently implementing Pointer Lock [1] in WebKit, which was adjusted
>> recently to mimic Fullscreen [2].
>>
>> Why does the Fullscreen specification use an iframe attribute
>> allowfullscreen to permit/restrict iframe capabilities instead of using
>> iframe sandbox="allow-fullscreen"?
>>
>> [1] http://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html
>> [2] http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
>>
>>


Re: [whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Vincent Scheib
[correcting Anne van Kesteren's email]


On Tue, Jul 31, 2012 at 3:03 PM, Vincent Scheib  wrote:

> I'm currently implementing Pointer Lock [1] in WebKit, which was adjusted
> recently to mimic Fullscreen [2].
>
> Why does the Fullscreen specification use an iframe attribute
> allowfullscreen to permit/restrict iframe capabilities instead of using
> iframe sandbox="allow-fullscreen"?
>
> [1] http://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html
> [2] http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
>
>


[whatwg] allowfullscreen vs sandbox="allow-fullscreen", and mimicking for pointer lock

2012-07-31 Thread Vincent Scheib
I'm currently implementing Pointer Lock [1] in WebKit, which was adjusted
recently to mimic Fullscreen [2].

Why does the Fullscreen specification use an iframe attribute
allowfullscreen to permit/restrict iframe capabilities instead of using
iframe sandbox="allow-fullscreen"?

[1] http://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html
[2] http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html