svn commit: r537516 - in /incubator/wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/markup/html/image/resource/ main/java/org/apache/wicket/util/resource/locator/ test/java/org/apache/wic
Author: jdonnerstag
Date: Sat May 12 14:01:09 2007
New Revision: 537516
URL: http://svn.apache.org/viewvc?view=rev&rev=537516
Log:
partly solving wicket-513: Example "pub" doesn't work any more. The images are
no longer localized
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/link/AutolinkPageExpectedResult_1.html
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/link/AutolinkPageExpectedResult_4.html
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/link/AutolinkPage_4.html
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?view=diff&rev=537516&r1=537515&r2=537516
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Sat May 12 14:01:09 2007
@@ -67,18 +67,21 @@
*
* Finally, if there is no SRC attribute and no VALUE attribute, the Image
* component's model is inspected. If the model contains a resource or resource
- * reference, this image is used, otherwise the model is converted to a
- * String and that value is used as a path to load the image.
+ * reference, this image is used, otherwise the model is converted to a String
+ * and that value is used as a path to load the image.
*
* @author Jonathan Locke
*/
public final class LocalizedImageResource implements IClusterable,
IResourceListener
{
private static final long serialVersionUID = 1L;
-
- /** What kind of resource it is. TRUE==Resource is set,
FALSE==ResourceReference is set, null none */
+
+ /**
+* What kind of resource it is. TRUE==Resource is set,
+* FALSE==ResourceReference is set, null none
+*/
private Boolean resourceKind;
-
+
/** The component that is referencing this image resource */
private Component component;
@@ -88,8 +91,8 @@
/** The resource reference */
private ResourceReference resourceReference;
- /** The resource parameters */
- private ValueMap resourceParameters;
+ /** The resource parameters */
+ private ValueMap resourceParameters;
/** The locale of the image resource */
private transient Locale locale;
@@ -212,7 +215,7 @@
{
setResourceReference(resourceReference, null);
}
-
+
/**
* @return If it is stateless (if resource is null)
*/
@@ -220,18 +223,19 @@
{
return this.resource == null;
}
-
+
/**
* @param resourceReference
*The resource to set.
-* @param resourceParameters
-*The resource parameters for the shared
resource
+* @param resourceParameters
+*The resource parameters for the shared resource
*/
- public final void setResourceReference(final ResourceReference
resourceReference,final ValueMap resourceParameters)
+ public final void setResourceReference(final ResourceReference
resourceReference,
+ final ValueMap resourceParameters)
{
resourceKind = Boolean.FALSE;
this.resourceReference = resourceReference;
- this.resourceParameters = resourceParameters;
+ this.resourceParameters = resourceParameters;
bind();
}
@@ -247,9 +251,11 @@
{
// If locale has changed from the initial locale used to attach
image
// resource, then we need to reload the resource in the new
locale
- if ( resourceKind == null &&
- (!Objects.equal(locale, component.getLocale())
- || !Objects.equal(style, component.getStyle(
+ Locale l = component.getLocale();
+ String s = component.getStyle();
+ if (resourceKind == null &&
+ (!Objects.equal(locale, component.getLocale())
|| !Objects.equal(style, component
+ .getStyle(
{
// Get new component locale and style
[jira] Resolved: (WICKET-559) LocalizedImageResource escapes ampersands twice (regression)
[ https://issues.apache.org/jira/browse/WICKET-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-559. --- Resolution: Fixed Assignee: Juergen Donnerstag patch applied. Thanks. > LocalizedImageResource escapes ampersands twice (regression) > > > Key: WICKET-559 > URL: https://issues.apache.org/jira/browse/WICKET-559 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Nathan Hamblen > Assigned To: Juergen Donnerstag >Priority: Critical > Fix For: 1.3 > > Attachments: loc-img-res.patch > > > urlFor returns escaped ampersands (apparently, a change) so > LocalizedImageResource should not do it a second time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r537494 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Author: jdonnerstag
Date: Sat May 12 10:34:56 2007
New Revision: 537494
URL: http://svn.apache.org/viewvc?view=rev&rev=537494
Log:
wicket-559: LocalizedImageResource escapes ampersands twice (regression)
provided patch applied
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?view=diff&rev=537494&r1=537493&r2=537494
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Sat May 12 10:34:56 2007
@@ -317,7 +317,7 @@
}
// Set the SRC attribute to point to the component or shared
resource
- tag.put("src",
Strings.replaceAll(RequestCycle.get().getOriginalResponse().encodeURL(url),
"&", "&"));
+ tag.put("src",
RequestCycle.get().getOriginalResponse().encodeURL(url));
}
/**
[jira] Commented: (WICKET-519) remove page versions from the second level cache when explicitly removed
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495311 ] Eelco Hillenius commented on WICKET-519: Just makes sense API wise though. > remove page versions from the second level cache when explicitly removed > > > Key: WICKET-519 > URL: https://issues.apache.org/jira/browse/WICKET-519 > Project: Wicket > Issue Type: Bug > Components: wicket >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3 > > > Someone at Matej's session had an interesting question about how pages can be > removed from the history when you explictly want to avoid users being able to > go back to that version (i.e. expire them). Removing the page from the page > map works fine with the HttpSessionStore, but doesn't with > SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage > just removes from pending but once it is serialized to disk, it will always > be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) > should remove it from second level cache so that it is in effect expired. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-515) Serialization exception in hangman example
[ https://issues.apache.org/jira/browse/WICKET-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-515. --- Resolution: Fixed Fix Version/s: 1.3 seems to be fixed > Serialization exception in hangman example > -- > > Key: WICKET-515 > URL: https://issues.apache.org/jira/browse/WICKET-515 > Project: Wicket > Issue Type: Bug > Components: wicket, wicket-examples >Affects Versions: 1.3 >Reporter: Juergen Donnerstag > Assigned To: Johan Compagner > Fix For: 1.3 > > > ERROR - Objects- Error serializing object class > org.apache.wicket.examples.hangman.Guess [object=[Page class = > org.apache.wicket.examples.hangman.Guess, id = 1, version = 0]] > org.apache.wicket.util.io.WicketSerializeableException: No Serializable > constructor found for class sun.font.AttributeMap > org.apache.wicket.examples.hangman.Guess->children->org.apache.wicket.Component[5]->org.apache.wicket.examples.hangman.Guess$2->children->org.apache.wicket.Component[26]->org.apache.wicket.markup.html.list.ListItem->children->org.apache.wicket.examples.hangman.Guess$2$1->children->org.apache.wicket.markup.html.image.Image->localizedImageResource->org.apache.wicket.markup.html.image.resource.LocalizedImageResource->resource->org.apache.wicket.markup.html.image.resource.DefaultButtonImageResource->fontAttributes > NOTE: if you feel Wicket is at fault with this exception, please report to > the mailing list. You can switch to JDK based serialization by calling: > org.apache.wicket.util.lang.Objects.setObjectStreamFactory(new > IObjectStreamFactory.DefaultObjectStreamFactory()) e.g. in the init method of > your application > at > org.apache.wicket.util.io.ClassStreamHandler.(ClassStreamHandler.java:252) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-517) encoding of AttributeModifier's model left unescaped
[
https://issues.apache.org/jira/browse/WICKET-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag closed WICKET-517.
-
Resolution: Won't Fix
Fix Version/s: 1.3
Assignee: Juergen Donnerstag
Please use WebRequestEncoder to properly encode your handcrafted url.
> encoding of AttributeModifier's model left unescaped
>
>
> Key: WICKET-517
> URL: https://issues.apache.org/jira/browse/WICKET-517
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.2.6, 1.3
>Reporter: Ludovic Orban
> Assigned To: Juergen Donnerstag
>Priority: Minor
> Fix For: 1.3
>
>
> If you do something looking like this:
> String url = "http://www.somewhere.com?param1=a¶m2=b";;
> component.add(new AttributeModifier("href", true, new Model(url)));
> After rendering the component will look like this:
> http://www.somewhere.com?param1=a¶m2=b"/>
> My template is not in HTML but XML and this is obviously not valid XML (the
> '&' should be escaped).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-407) Browser version in ClientProperties should be an Integer
[ https://issues.apache.org/jira/browse/WICKET-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag closed WICKET-407. - Resolution: Won't Fix Fix Version/s: 1.3 ClientProperties has been completely reworked. The new version should not have the problem. > Browser version in ClientProperties should be an Integer > > > Key: WICKET-407 > URL: https://issues.apache.org/jira/browse/WICKET-407 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.5 > Environment: Wicket 1.2.5 > JDK 5 > Jetty 6 >Reporter: Rüdiger Schulz >Priority: Minor > Fix For: 1.3 > > > When calling > ClientProperties.getInt(ClientProperties.BROWSER_VERSION_MAJOR, 0) or > ClientProperties.getInt(ClientProperties.BROWSER_VERSION_MINOR, 0) > an Exception is thrown: > java.lang.ClassCastException: java.lang.String cannot be cast to > java.lang.Integer > at > wicket.protocol.http.ClientProperties.getInt(ClientProperties.java:402) > Looking at WebClientInfo, I see that both of these values are converted from > int to String. getInt() then just tries to cast to Integer. > I think both values should be stored as an Integer, so that easy number > comparisons can be made. > Otherwise, one would have to convert the String to an int again. > Diff for WebClientInfo: > 156,157c156,157 > < > properties.setProperty(ClientProperties.BROWSER_VERSION_MAJOR, Integer > < .toString(majorVersion)); > --- > > > > properties.setProperty(ClientProperties.BROWSER_VERSION_MAJOR, new Integer > > (majorVersion)); > 162,163c162,163 > < > properties.setProperty(ClientProperties.BROWSER_VERSION_MINOR, Integer > < .toString(minorVersion)); > --- > > > > properties.setProperty(ClientProperties.BROWSER_VERSION_MINOR, new Integer > > (minorVersion)); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-556) Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its contributing component has been replaced
[
https://issues.apache.org/jira/browse/WICKET-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495303
]
Matej Knopp commented on WICKET-556:
I fixed this for 1.3 (added a simple precondition mechanism).
> Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its
> contributing component has been replaced
> ---
>
> Key: WICKET-556
> URL: https://issues.apache.org/jira/browse/WICKET-556
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Reporter: Jim McLaughlin
> Assigned To: Matej Knopp
>
> Currently, the setTimeout for an AjaxTimerBehavior will fire after the
> contributing component has been replaced or removed through an ajax request.
> This will result in an exception server side and a full page refresh client
> side.
> One possible solution is to override getCallbackScript() to enclose the ajax
> callback in another function that will only execute the ajax request if the
> markup for the contributing component is still in the dom tree:
> protected CharSequence getCallbackScript(boolean
> recordPageVersion)
> {
> String mId = getComponent().getMarkupId();
> StringBuilder sb = new StringBuilder("exec_func(function() {
> ");
> sb.append("var el = wicketGet('" + mId + "'); ");
> sb.append("if(null != el) {");
> sb.append(super.getCallbackScript(recordPageVersion));
> sb.append("}");
> sb.append("})");
>
> return sb.toString ();
> }
> Other options are to have the request cycle swallow the "component not found"
> exception for timer behaviors (since they will only fire 1 extra time)
> or
> a more complicated scheme would involve wicket actively managing javascript
> timer tokens client side so that they can be removed with clearTimeout when
> their contributing component is removed through an ajax request. The
> javascript to do this would be trivial (a simple container object mapping dom
> id to timer token), but the wicket lifecycle would need to support an
> onRemove callback for components to perform cleanup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r537474 - in /incubator/wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/ajax/ test/java/org/apache/wicket/ajax/markup/html/componentMap/
Author: knopp
Date: Sat May 12 09:02:23 2007
New Revision: 537474
URL: http://svn.apache.org/viewvc?view=rev&rev=537474
Log:
WICKET-556 Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing
after its contributing component has been replaced
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/wicket-ajax.js
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/ajax/markup/html/componentMap/SimpleTestPageExpectedResult.html
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java?view=diff&rev=537474&r1=537473&r2=537474
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
Sat May 12 09:02:23 2007
@@ -74,10 +74,23 @@
protected final String getJsTimeoutCall(final Duration updateInterval)
{
// this might look strange, but it is necessary for IE not to
leak :(
- return "setTimeout(\"" + getCallbackScript(true) + "\", "
+ return "setTimeout(\"" + getCallbackScript() + "\", "
+ updateInterval.getMilliseconds() + ");";
}
+ protected CharSequence getCallbackScript()
+ {
+ String componentId = getComponent().getMarkupId();
+ String precondition = "var c = Wicket.$('" + componentId + "');
return typeof(c) != 'undefined' && c != null";
+
+ return getCallbackScript("wicketAjaxGet('"
+ + getCallbackUrl(onlyTargetActivePage()) + "'",
null, null, precondition);
+ }
+
+ protected boolean onlyTargetActivePage() {
+ return true;
+ }
+
/**
*
* @see
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#respond(org.apache.wicket.ajax.AjaxRequestTarget)
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java?view=diff&rev=537474&r1=537473&r2=537474
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
Sat May 12 09:02:23 2007
@@ -136,6 +136,36 @@
protected CharSequence getCallbackScript(final CharSequence partialCall,
final CharSequence onSuccessScript, final CharSequence
onFailureScript)
{
+ return getCallbackScript(partialCall, onSuccessScript,
onFailureScript, null);
+ }
+
+ /**
+* Returns javascript that performs an ajax callback to this behavior.
The
+* script is decorated by the ajax callback decorator from
+* [EMAIL PROTECTED]
AbstractDefaultAjaxBehavior#getAjaxCallDecorator()}.
+*
+* @param partialCall
+*Javascript of a partial call to the function performing
the
+*actual ajax callback. Must be in format
+*function(params, with signature
+*function(params, onSuccessHandler,
onFailureHandler.
+*Example: wicketAjaxGet('callbackurl'
+* @param onSuccessScript
+*javascript that will run when the ajax call finishes
+*successfully
+* @param onFailureScript
+*javascript that will run when the ajax call finishes with
an
+*error status
+* @param precondition
+*optional javacript expression that determines
whether the request
+*will actually execute (in form of return XXX;);
+*
+* @return script that peforms ajax callback to this behavior
+*/
+ protected CharSequence getCallbackScript(final CharSequence partialCall,
+ final CharSequence onSuccessScript, final CharSequence
onFailureScript,
+ final CharSequence precondition)
+ {
final IAjaxCallDecorator decorator = getAjaxCallDecorator();
[jira] Commented: (WICKET-176) Introduce AjaxFormElementValidatingBehavior
[ https://issues.apache.org/jira/browse/WICKET-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495301 ] Erik van Oosten commented on WICKET-176: As this class validates a field on the server as soon as it is changed, this class would be ideal for the currently discussed HibernateValidator. > Introduce AjaxFormElementValidatingBehavior > --- > > Key: WICKET-176 > URL: https://issues.apache.org/jira/browse/WICKET-176 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 1.2.3 >Reporter: Erik van Oosten > Assigned To: Eelco Hillenius > Fix For: 1.3, 2.0 > > Attachments: AjaxFormComponentValidatingBehavior.java, > AjaxFormComponentValidatingBehavior.java > > > There is currently no easy way to validate a single form element using Ajax. > Please add attached code to the Wicket-core. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-214) Call all behaviors attached to the same event
[ https://issues.apache.org/jira/browse/WICKET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495299 ] Erik van Oosten commented on WICKET-214: The situation would already be improved a lot if the javadoc would make it clear that it is not possible to add multiple behaviors to the same event. Yet another option is to provide an aggregation behavior. Something that would allow you to merge 2 behaviors into 1. I am not sure how this could work. I am not familiar with Wicket.Event (a 1.3 feature?). > Call all behaviors attached to the same event > - > > Key: WICKET-214 > URL: https://issues.apache.org/jira/browse/WICKET-214 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.2.4, 1.3, 2.0 >Reporter: Erik van Oosten > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > If one adds 2 AjaxFormComponentUpdatingBehaviors with event "onchange" to the > same form component, only the behavior that was added last will actually be > called. Please make it so that both are called. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-176) Introduce AjaxFormElementValidatingBehavior
[ https://issues.apache.org/jira/browse/WICKET-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495300 ] Erik van Oosten commented on WICKET-176: There is nothing that does this in Wicket 1.2. Unfortunately I am not yet familiar with the new features of Wicket 1.3. > Introduce AjaxFormElementValidatingBehavior > --- > > Key: WICKET-176 > URL: https://issues.apache.org/jira/browse/WICKET-176 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 1.2.3 >Reporter: Erik van Oosten > Assigned To: Eelco Hillenius > Fix For: 1.3, 2.0 > > Attachments: AjaxFormComponentValidatingBehavior.java, > AjaxFormComponentValidatingBehavior.java > > > There is currently no easy way to validate a single form element using Ajax. > Please add attached code to the Wicket-core. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r537459 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
Author: knopp
Date: Sat May 12 08:23:28 2007
New Revision: 537459
URL: http://svn.apache.org/viewvc?view=rev&rev=537459
Log:
Error message clarification
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java?view=diff&rev=537459&r1=537458&r2=537459
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
Sat May 12 08:23:28 2007
@@ -248,7 +248,7 @@
{
throw new MarkupException("Markup of component class `"
+
providerMarkupStream.getContainerClass().getName()
- + "` does not contain a fragment with
id `" + markupId + "`. Context: "
+ + "` does not contain a fragment with
wicket:id `" + markupId + "`. Context: "
+ toString());
}
[jira] Created: (WICKET-559) LocalizedImageResource escapes ampersands twice (regression)
LocalizedImageResource escapes ampersands twice (regression) Key: WICKET-559 URL: https://issues.apache.org/jira/browse/WICKET-559 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3 Reporter: Nathan Hamblen Priority: Critical Fix For: 1.3 Attachments: loc-img-res.patch urlFor returns escaped ampersands (apparently, a change) so LocalizedImageResource should not do it a second time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-559) LocalizedImageResource escapes ampersands twice (regression)
[ https://issues.apache.org/jira/browse/WICKET-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Hamblen updated WICKET-559: -- Attachment: loc-img-res.patch Patch to not escape amps a second time. > LocalizedImageResource escapes ampersands twice (regression) > > > Key: WICKET-559 > URL: https://issues.apache.org/jira/browse/WICKET-559 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Nathan Hamblen >Priority: Critical > Fix For: 1.3 > > Attachments: loc-img-res.patch > > > urlFor returns escaped ampersands (apparently, a change) so > LocalizedImageResource should not do it a second time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r537455 - /incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java
Author: jdonnerstag
Date: Sat May 12 08:09:44 2007
New Revision: 537455
URL: http://svn.apache.org/viewvc?view=rev&rev=537455
Log:
added test for wicket-528: StringResourceModel does not use defaultValue
properly
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java?view=diff&rev=537455&r1=537454&r2=537455
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest.java
Sat May 12 08:09:44 2007
@@ -16,6 +16,7 @@
*/
package org.apache.wicket;
+import java.util.HashMap;
import java.util.Locale;
import java.util.MissingResourceException;
@@ -23,6 +24,7 @@
import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.model.Model;
+import org.apache.wicket.model.PropertyModel;
import org.apache.wicket.resource.DummyApplication;
import org.apache.wicket.resource.loader.ComponentStringResourceLoader;
import org.apache.wicket.settings.IResourceSettings;
@@ -160,6 +162,21 @@
assertEquals("value 1", drop1);
assertEquals("value 2", drop2);
+ }
+
+ /**
+*
+*/
+ public void testGetStringUseModel()
+ {
+ HashMap model = new HashMap();
+ model.put("user", "juergen");
+
+ Assert.assertEquals("Expected string should be returned",
"Welcome, juergen", localizer
+ .getString("test.substitute", null, new
PropertyModel(model, null), "DEFAULT {user}"));
+
+ Assert.assertEquals("Expected string should be returned",
"DEFAULT juergen", localizer
+ .getString("test.substituteDoesNotExist", null,
new PropertyModel(model, null), "DEFAULT ${user}"));
}
/**
[jira] Commented: (WICKET-556) Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its contributing component has been replaced
[
https://issues.apache.org/jira/browse/WICKET-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495296
]
Matej Knopp commented on WICKET-556:
Well. While this can certainly solve this problem for most cases, there can
still be an invalid request.
wicketAjaxGet doesn't fire AJAX request immediately. Rather than that, it puts
the request in a queue. If another requests in queue that was executed before
this one removes the component, the exception will be thrown again.
What we probably need is some kind of precondition, that would be evaluated
immediately before firing the request.
> Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its
> contributing component has been replaced
> ---
>
> Key: WICKET-556
> URL: https://issues.apache.org/jira/browse/WICKET-556
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Reporter: Jim McLaughlin
> Assigned To: Matej Knopp
>
> Currently, the setTimeout for an AjaxTimerBehavior will fire after the
> contributing component has been replaced or removed through an ajax request.
> This will result in an exception server side and a full page refresh client
> side.
> One possible solution is to override getCallbackScript() to enclose the ajax
> callback in another function that will only execute the ajax request if the
> markup for the contributing component is still in the dom tree:
> protected CharSequence getCallbackScript(boolean
> recordPageVersion)
> {
> String mId = getComponent().getMarkupId();
> StringBuilder sb = new StringBuilder("exec_func(function() {
> ");
> sb.append("var el = wicketGet('" + mId + "'); ");
> sb.append("if(null != el) {");
> sb.append(super.getCallbackScript(recordPageVersion));
> sb.append("}");
> sb.append("})");
>
> return sb.toString ();
> }
> Other options are to have the request cycle swallow the "component not found"
> exception for timer behaviors (since they will only fire 1 extra time)
> or
> a more complicated scheme would involve wicket actively managing javascript
> timer tokens client side so that they can be removed with clearTimeout when
> their contributing component is removed through an ajax request. The
> javascript to do this would be trivial (a simple container object mapping dom
> id to timer token), but the wicket lifecycle would need to support an
> onRemove callback for components to perform cleanup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-528) StringResourceModel does not use defaultValue properly
[
https://issues.apache.org/jira/browse/WICKET-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-528.
---
Resolution: Fixed
Fix Version/s: 1.3
Assignee: Juergen Donnerstag
fixed
> StringResourceModel does not use defaultValue properly
> --
>
> Key: WICKET-528
> URL: https://issues.apache.org/jira/browse/WICKET-528
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.2.6
>Reporter: Ryan Crumley
> Assigned To: Juergen Donnerstag
>Priority: Minor
> Fix For: 1.3
>
> Attachments: stringresourcemodel.patch
>
>
> The construction in StringResourceModel that takes an argument 'defaultValue'
> does not pass it to Localizer.getString (called from
> StringResourceModel.getString()) so the default value never has the
> opportunity to be used.
> In addition Localizer.getString(...) did not substitute property expressions
> if the specified key was not found and defaultValue was used instead.
> @see
> public String getString(final String key, final Component component,
> final IModel model,
> final Locale locale, final String style, final String
> defaultValue)
> throws MissingResourceException
> This was a problem for me because I wanted my default value to be provided by
> the model (instead of being resolved statically at construction time) so I
> passed the string "${modelValue}" as my default value.
> The provided patch fixes both these issues in 1.2.6.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r537451 - in /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket: Localizer.java model/StringResourceModel.java
Author: jdonnerstag
Date: Sat May 12 07:58:46 2007
New Revision: 537451
URL: http://svn.apache.org/viewvc?view=rev&rev=537451
Log:
wicket-528: StringResourceModel does not use defaultValue properly
fixed
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Localizer.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/model/StringResourceModel.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Localizer.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Localizer.java?view=diff&rev=537451&r1=537450&r2=537451
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Localizer.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Localizer.java
Sat May 12 07:58:46 2007
@@ -114,10 +114,10 @@
{
return getString(key, component, null, defaultValue);
}
-
+
/**
* This method is now deprecated.
-*
+*
* @param key
* @param component
* @param model
@@ -127,7 +127,8 @@
* @return String
* @throws MissingResourceException
*
-* @Deprecated please use [EMAIL PROTECTED] #getString(String,
Component, IModel, String)}
+* @Deprecated please use
+* [EMAIL PROTECTED] #getString(String, Component, IModel,
String)}
*/
public String getString(final String key, final Component component,
final IModel model,
final Locale locale, final String style, final String
defaultValue)
@@ -135,7 +136,7 @@
{
return null;
}
-
+
/**
* Get the localized string using all of the supplied parameters. This
* method is left public to allow developers full control over string
@@ -162,8 +163,9 @@
// Iterate over all registered string resource loaders until the
// property has been found
String string = null;
-
- Iterator iter =
Application.get().getResourceSettings().getStringResourceLoaders().iterator();
+
+ final IResourceSettings resourceSettings =
Application.get().getResourceSettings();
+ Iterator iter =
resourceSettings.getStringResourceLoaders().iterator();
while (iter.hasNext())
{
IStringResourceLoader loader =
(IStringResourceLoader)iter.next();
@@ -174,25 +176,27 @@
}
}
- // If a property value has been found, than replace the
placeholder
- // and we are done
- if (string != null)
+ if ((string == null) && (defaultValue != null))
{
- return substitutePropertyExpressions(component, string,
model);
+ // Resource not found, so handle missing resources
based on
+ // application configuration and try the default value
+ if (resourceSettings.getUseDefaultOnMissingResource())
+ {
+ string = defaultValue;
+ }
}
- // Resource not found, so handle missing resources based on
application
- // configuration
- final IResourceSettings resourceSettings =
Application.get().getResourceSettings();
- if (resourceSettings.getUseDefaultOnMissingResource() &&
(defaultValue != null))
+ // If a property value has been found, or a default value was
given,
+ // than replace the placeholder and we are done
+ if (string != null)
{
- return defaultValue;
+ return substitutePropertyExpressions(component, string,
model);
}
if (resourceSettings.getThrowExceptionOnMissingResource())
{
- AppendingStringBuffer message = new
AppendingStringBuffer("Unable to find resource: "
- + key);
+ AppendingStringBuffer message = new
AppendingStringBuffer("Unable to find resource: " +
+ key);
if (component != null)
{
message.append(" for component: ");
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/model/StringResourceModel.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/model/StringResourceModel.java?view=diff&rev=537451&r1=537450&r2=537451
[jira] Resolved: (WICKET-527) Panel header contribution breaks AJAX update in Internet Explorer
[ https://issues.apache.org/jira/browse/WICKET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-527. Resolution: Invalid Of course this doesn't work. Markup for header contribution must be well formed (xhtml valid). In your example you have Which is wrong - without closing tag. If you change it to Everything works. > Panel header contribution breaks AJAX update in Internet Explorer > - > > Key: WICKET-527 > URL: https://issues.apache.org/jira/browse/WICKET-527 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.6 >Reporter: John Krasnay > Assigned To: Matej Knopp > Attachments: quickstart.zip > > > If a Panel subclass makes a header contribution via , and the > panel code attempts to refresh itself in response to an AjaxLink click, the > refresh does not work on IE. The debug window shows the following error: > INFO: > INFO: Initiating Ajax GET request on > /arp/?wicket:interface=:0:subComponent:link::IBehaviorListener&wicket:behaviorId=0&random=0.8818904450460203 > INFO: Invoking pre-call handler(s)... > INFO: Received ajax response (656 characters) > INFO: > encoding="UTF-8"?> > > ERROR: Error while parsing response: Object required > INFO: Invoking post-call handler(s)... > INFO: Invoking failure handler(s)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-491) problem with browser back-button and links after ajax replace
[ https://issues.apache.org/jira/browse/WICKET-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Thomas closed WICKET-491. --- It works. This is fantastic, the ajax replace / back button / link problems have gone now. Thank you and all those who have been working hard on Ajax versioning etc. This is a big one. I am thrilled! > problem with browser back-button and links after ajax replace > - > > Key: WICKET-491 > URL: https://issues.apache.org/jira/browse/WICKET-491 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp > Fix For: 1.3 > > Attachments: test-quickstart.zip > > > I'm having this problem when I back-button to a page with a panel that > replaced itself with another panel containing a link - and re-try the link: > WicketMessage: Method onLinkClicked of interface > org.apache.wicket.markup.html.link.ILinkListener targeted at component > [MarkupContainer [Component id = link, page = test.HomePage, path = > 0:panel:link.FirstPanel$1, isVisible = true, isVersioned = true]] threw an > exception > Root cause: > java.lang.IllegalArgumentException: object is not an instance of declaring > class > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:39) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:186) > at > org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents > (ListenerInterfaceRequestTarget.java:73) > at > org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:90) > at org.apache.wicket.RequestCycle.processEventsAndRespond > (RequestCycle.java:975) > at org.apache.wicket.RequestCycle.step(RequestCycle.java:1048) > at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1127) > at org.apache.wicket.RequestCycle.request(RequestCycle.java :489) > at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248) > I'm attaching a quickstart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-192) make it easier to customize node icons in the tree
[
https://issues.apache.org/jira/browse/WICKET-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495289
]
Matej Knopp commented on WICKET-192:
I think the current way is not difficult :) This is okay for open / close
leaves icons, but what if you have different icon for each node type? (e.g.
file browser). Then it's much better IMHO to do it in java.
> make it easier to customize node icons in the tree
> --
>
> Key: WICKET-192
> URL: https://issues.apache.org/jira/browse/WICKET-192
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.2.4, 1.3, 2.0
>Reporter: Igor Vaynberg
> Assigned To: Matej Knopp
> Fix For: 1.3
>
>
> looking at how the tree works now, we are inlining the url to the node icon
> into the markup in newNodeIcon(). so if the user wants to customize the icon
> images they have to do it through code which is a pita imho. it would be
> better if instead of inlining resource urls we would set a css class
> attribute, then users can provide their own stylesheet.
> then we need to figure out a way to make it easy to silence the tree's own
> css contribution so the user can override it with their own.
> make sense?
> its a lot easier for me to do div.my-nav-tree div.wicket-tree
> span.node-expanded { background-url: {foo.png}} then have to register
> my own wicket resource, override getNodeIcon(), etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-431) Modal window can not be closed after session timeout
[ https://issues.apache.org/jira/browse/WICKET-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp updated WICKET-431: --- Priority: Minor (was: Major) > Modal window can not be closed after session timeout > > > Key: WICKET-431 > URL: https://issues.apache.org/jira/browse/WICKET-431 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.2.5 > Environment: tested on Linux FF / Windows FF >Reporter: francisdb > Assigned To: Matej Knopp >Priority: Minor > Fix For: 1.3 > > > After session timeout, clicking on the close button (X) generates a warning > message: > 'Are you sure you want to Reloading this page will cause the modal > window to disappear' > --> Maybe something about session timeout might be more meaningful? > If you click 'Cancel' you are stuck with an unclosable modal window, the > previous message won't be shown again. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-431) Modal window can not be closed after session timeout
[ https://issues.apache.org/jira/browse/WICKET-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495287 ] Matej Knopp commented on WICKET-431: I don't see how i can fix it. If you click ok, the modal dialog will disappear. Also you can disable the entire message if you want. I'm postponing this with lowering the priority, as this certainly isn't a major one. > Modal window can not be closed after session timeout > > > Key: WICKET-431 > URL: https://issues.apache.org/jira/browse/WICKET-431 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.2.5 > Environment: tested on Linux FF / Windows FF >Reporter: francisdb > Assigned To: Matej Knopp > Fix For: 1.3 > > > After session timeout, clicking on the close button (X) generates a warning > message: > 'Are you sure you want to Reloading this page will cause the modal > window to disappear' > --> Maybe something about session timeout might be more meaningful? > If you click 'Cancel' you are stuck with an unclosable modal window, the > previous message won't be shown again. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-470) AjaxFormComponentUpdatingBehavior won't work for RadioChoices
[
https://issues.apache.org/jira/browse/WICKET-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp reassigned WICKET-470:
--
Assignee: Johan Compagner (was: Matej Knopp)
I believe you are working on this now?
> AjaxFormComponentUpdatingBehavior won't work for RadioChoices
> -
>
> Key: WICKET-470
> URL: https://issues.apache.org/jira/browse/WICKET-470
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3
>Reporter: Carlos Pita
> Assigned To: Johan Compagner
> Attachments: AjaxFormChoiceComponentUpdatingBehavior.java
>
>
> Below is the generated html and js for a simple RadioChoice("sex",
> Arrays.asList("M", "F")) with an attached behavior. Notice how
> wicketSerialize will take the else branch for span elements, so it will
> always return "". Maybe the behavior should be patched, maybe the js, maybe
> there is a need for another behavior, I don't know.
>
> for="sex_0">M
> for="sex_1">F
>
> wicketSerialize = Wicket.Form.serializeElement;
> Wicket.Form.serializeElement = function(e) {
> var tag = e.tagName.toLowerCase();
> if (tag == "select") {
> return Wicket.Form.serializeSelect(e);
> } else if (tag == "input" || tag == "textarea") {
> return Wicket.Form.serializeInput(e);
> } else {
> return "";
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-444) src attribute path not processed by wicket for INPUT type=image and any IMG with wicket:message in it
[ https://issues.apache.org/jira/browse/WICKET-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Thomas reopened WICKET-444: - Matej - I think this came back in the latest SNAPSHOT. For img tags having a wicket:message attribute I have to use the relative path "../resources/foo.gif" and this was working fine in last weeks SNAPSHOT. > src attribute path not processed by wicket for INPUT type=image and any IMG > with wicket:message in it > - > > Key: WICKET-444 > URL: https://issues.apache.org/jira/browse/WICKET-444 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Fix For: 1.3 > > > I'm using wicket-1.3.0-incubating-SNAPSHOT.jar Sun, 01 Apr 2007 19:21:01 GMT > Wicket appears to pre-process and modify the value of the SRC attribute in > most cases (e.g. IMG tags) so that at run time, the path is absolute path. > This works fine for IMG tags. So with wicket filter mapped to /app/* and > static files in /resources : > The following HTML: > becomes at runtime: > Problem: > Ever since 1.3 I noticed that fixing of the SRC attribute was not happening > for tags. I worked around this by prepending "../" - > but obviously this is not a good idea. For example this is what I am using > which works: > > What prompted me to raise this JIRA now is that I just switched to the latest > SNAPSHOT and I find that any IMG tag that has a "wicket:message" attribute > also does not get the SRC value "fixed". This used to work in 1.2.X > I have a feeling this is related to the changes made as per > https://issues.apache.org/jira/browse/WICKET-440 > So to summarize, wicket does not change SRC values to absolute paths for the > following tags: > a) any tag with a wicket:message attribute present > b) any tag -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates
[ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag closed WICKET-456. - Resolution: Fixed Fix Version/s: 1.3 > wicket:head contributions from panel markup should be parsed to remove > duplicates > -- > > Key: WICKET-456 > URL: https://issues.apache.org/jira/browse/WICKET-456 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp >Priority: Minor > Fix For: 1.3 > > > When using wicket:head to contribute head entries, when multiple panels are > used in a page, the HTML head section ends up with duplicate entries if some > of the panels share common resources. > Of course there is no problem if you use HeaderContributor in the code > instead. > Nabble discussion link: > http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates
[ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495284 ] Peter Thomas commented on WICKET-456: - I'm okay with not fixing this, HeaderContributor is working fine for me. > wicket:head contributions from panel markup should be parsed to remove > duplicates > -- > > Key: WICKET-456 > URL: https://issues.apache.org/jira/browse/WICKET-456 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp >Priority: Minor > > When using wicket:head to contribute head entries, when multiple panels are > used in a page, the HTML head section ends up with duplicate entries if some > of the panels share common resources. > Of course there is no problem if you use HeaderContributor in the code > instead. > Nabble discussion link: > http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1) dynamic treetable with a real model
[ https://issues.apache.org/jira/browse/WICKET-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-1. -- Resolution: Won't Fix Fix Version/s: 2.0 I have different implementation of file browser. However, I'm not sure it's the best example. > dynamic treetable with a real model > --- > > Key: WICKET-1 > URL: https://issues.apache.org/jira/browse/WICKET-1 > Project: Wicket > Issue Type: New Feature > Components: wicket-extensions >Affects Versions: 2.0 > Environment: any >Reporter: omprakash > Assigned To: Matej Knopp > Fix For: 2.0 > > Attachments: treetable.zip, TreeTable2-II.zip, TreeTable2-III.zip, > TreeTable2.zip > > > The treetable extension at present shows a dummy model with hardcoded data. > As such it is not very useful. The TreeTable2 component however uses a live > model with dynamic data. The modelbean class that the existing TreeTable > component is not very scaleable and TreeTable2 component attempts to change > that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-328) Link#setAnchor return Link instead of void
[
https://issues.apache.org/jira/browse/WICKET-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-328.
---
Resolution: Fixed
Fix Version/s: 1.3
done
> Link#setAnchor return Link instead of void
> --
>
> Key: WICKET-328
> URL: https://issues.apache.org/jira/browse/WICKET-328
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 1.2.5
>Reporter: Nick Johnson
>Priority: Trivial
> Fix For: 1.3
>
>
> It would be nice for Link#setAnchor(Component) to return Link instead of
> void, so you can be super lazy and say things like this:
> add(new AjaxFallbackLink("foo") { onClick(...) {...}}.setAnchor(bar));
> Might be nice to do that for various other methods on Link as well to allow
> for other wacky chaining possibilities.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r537434 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java
Author: jdonnerstag
Date: Sat May 12 07:19:21 2007
New Revision: 537434
URL: http://svn.apache.org/viewvc?view=rev&rev=537434
Log:
wicket-328: Link#setAnchor return Link instead of void
fixed
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java?view=diff&rev=537434&r1=537433&r2=537434
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/Link.java
Sat May 12 07:19:21 2007
@@ -36,25 +36,25 @@
* You can use a link like:
*
*
- *add(new Link("myLink")
- *{
- *public void onClick(RequestCycle cycle)
- *{
- *// do something here...
- *}
- *);
+ * add(new Link("myLink")
+ * {
+ * public void onClick(RequestCycle cycle)
+ * {
+ * // do something here...
+ * }
+ * );
*
*
* and in your HTML file:
*
*
- *click here
+ * click
here
*
*
* or:
*
*
- *my clickable
column
+ * my clickable column
*
*
*
@@ -62,13 +62,13 @@
* the Page to the Page responded by the Link.
*
*
- *add(new Link("link", listItem.getModel())
- *{
- *public void onClick()
- *{
- *MyObject obj = (MyObject)getModelObject();
- *setResponsePage(new MyPage(obj.getId(), ...
));
- *}
+ * add(new Link("link", listItem.getModel())
+ * {
+ * public void onClick()
+ * {
+ * MyObject obj = (MyObject)getModelObject();
+ * setResponsePage(new MyPage(obj.getId(), ... ));
+ * }
*
*
* @author Jonathan Locke
@@ -222,7 +222,6 @@
onClick();
}
-
/**
* Sets an anchor component. An anchor (form
* 'http://server/app/etc#someAnchor') will be appended to the link so
that
@@ -234,11 +233,13 @@
*
* @param anchor
*The anchor
+* @return this
*/
- public void setAnchor(Component anchor)
+ public Link setAnchor(Component anchor)
{
addStateChange(new AnchorChange(this.anchor));
this.anchor = anchor;
+ return this;
}
/**
@@ -468,5 +469,4 @@
}
}
-
}
[jira] Resolved: (WICKET-534) Add a parameter to toggle an AJAX call between asynchronous and synchronous
[
https://issues.apache.org/jira/browse/WICKET-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp resolved WICKET-534.
Resolution: Won't Fix
Won't fix as synchronous ajax requests are pure evil :)
> Add a parameter to toggle an AJAX call between asynchronous and synchronous
> ---
>
> Key: WICKET-534
> URL: https://issues.apache.org/jira/browse/WICKET-534
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.2.6
>Reporter: James Renfro
> Assigned To: Matej Knopp
>Priority: Minor
>
> When using AJAX in certain special cases it may be helpful to make
> XMLHttpRequest calls with the async parameter set to 'false'. This can be
> accomplished by modifying the code under wicket-ajax.js -- but it would be
> nice to have a parameter in the Java code that set the request to synchronous
> for the length of that call.
>
> Wicket.Ajax.Request.prototype = {
>initialize: function(url, loadedCallback, parseResponse, randomURL,
> failureHandler, channel) {
>this.url = url;
>this.loadedCallback = loadedCallback;
>this.parseResponse = parseResponse != null ? parseResponse : true;
>this.randomURL = randomURL != null ? randomURL : true;
>this.failureHandler = failureHandler != null ? failureHandler :
> function() { };
>this.async = true;
>this.channel = channel;
>this.suppressDone = false;
>this.instance = Math.random();
>this.debugContent = true;
>},
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-534) Add a parameter to toggle an AJAX call between asynchronous and synchronous
[
https://issues.apache.org/jira/browse/WICKET-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495280
]
Matej Knopp commented on WICKET-534:
Okay. I'm strongly against this. You can always put the javascript together by
yourself.
You can do make your own
function wicketAjaxGeSync(url, successHandler, failureHandler, channel) {
var call = new Wicket.Ajax.Call(url, successHandler, failureHandler,
channel);
call.request.async = false;
return call.call();
}
And use AbstractAjaxBehavior.getCallbacUrl to get the URL you need to pass to
your wicketAjaxGetSync method.
> Add a parameter to toggle an AJAX call between asynchronous and synchronous
> ---
>
> Key: WICKET-534
> URL: https://issues.apache.org/jira/browse/WICKET-534
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.2.6
>Reporter: James Renfro
> Assigned To: Matej Knopp
>Priority: Minor
>
> When using AJAX in certain special cases it may be helpful to make
> XMLHttpRequest calls with the async parameter set to 'false'. This can be
> accomplished by modifying the code under wicket-ajax.js -- but it would be
> nice to have a parameter in the Java code that set the request to synchronous
> for the length of that call.
>
> Wicket.Ajax.Request.prototype = {
>initialize: function(url, loadedCallback, parseResponse, randomURL,
> failureHandler, channel) {
>this.url = url;
>this.loadedCallback = loadedCallback;
>this.parseResponse = parseResponse != null ? parseResponse : true;
>this.randomURL = randomURL != null ? randomURL : true;
>this.failureHandler = failureHandler != null ? failureHandler :
> function() { };
>this.async = true;
>this.channel = channel;
>this.suppressDone = false;
>this.instance = Math.random();
>this.debugContent = true;
>},
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-494) id attribute is not preserved
[ https://issues.apache.org/jira/browse/WICKET-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495279 ] Matej Knopp commented on WICKET-494: I believe this is intentional. Igor? > id attribute is not preserved > - > > Key: WICKET-494 > URL: https://issues.apache.org/jira/browse/WICKET-494 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.7, 1.3, 2.0 >Reporter: Iulian Costan >Priority: Minor > Attachments: id_attribute.patch > > > i think id attribute of a script tag that is added using ajax response needs > to be preserved, right now it doenst. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates
[ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495278 ] Matej Knopp commented on WICKET-456: I'm -1 on this and if noone objects I'll close this as won't fix. We already filter duplicate contribution for panels of the same class. If anyone needs to filter contributions from component of different classes there is IHeaderReponse for that. > wicket:head contributions from panel markup should be parsed to remove > duplicates > -- > > Key: WICKET-456 > URL: https://issues.apache.org/jira/browse/WICKET-456 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas >Priority: Minor > > When using wicket:head to contribute head entries, when multiple panels are > used in a page, the HTML head section ends up with duplicate entries if some > of the panels share common resources. > Of course there is no problem if you use HeaderContributor in the code > instead. > Nabble discussion link: > http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates
[ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp reassigned WICKET-456: -- Assignee: Matej Knopp > wicket:head contributions from panel markup should be parsed to remove > duplicates > -- > > Key: WICKET-456 > URL: https://issues.apache.org/jira/browse/WICKET-456 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp >Priority: Minor > > When using wicket:head to contribute head entries, when multiple panels are > used in a page, the HTML head section ends up with duplicate entries if some > of the panels share common resources. > Of course there is no problem if you use HeaderContributor in the code > instead. > Nabble discussion link: > http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r537428 - in /incubator/wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/protocol/http/request/ main/java/org/apache/wicket/request/target/coding/ test/java/org/apache/wicket/r
Author: jdonnerstag
Date: Sat May 12 07:10:17 2007
New Revision: 537428
URL: http://svn.apache.org/viewvc?view=rev&rev=537428
Log:
wicket-293: PackageRequestTargetUrlCodingStrategy should sends a 404 when a
page/class cannot be found.
fixed
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/request/target/coding/PackageRequestTargetUrlCodingStrategy.java
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/request/target/coding/UrlMountingTest.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java?view=diff&rev=537428&r1=537427&r2=537428
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
Sat May 12 07:10:17 2007
@@ -24,6 +24,8 @@
import java.util.TreeSet;
import java.util.Map.Entry;
+import javax.servlet.http.HttpServletResponse;
+
import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IPageMap;
@@ -361,7 +363,27 @@
{
IRequestTargetUrlCodingStrategy encoder =
urlCodingStrategyForPath(requestParameters
.getPath());
- return (encoder != null) ? encoder.decode(requestParameters) :
null;
+ if (encoder == null)
+ {
+ return null;
+ }
+ try
+ {
+ return encoder.decode(requestParameters);
+ }
+ catch (WicketRuntimeException ex)
+ {
+ if (log.isDebugEnabled())
+ {
+ log.debug(ex.toString());
+
+ return new
WebErrorCodeResponseTarget(HttpServletResponse.SC_NOT_FOUND,
+ "Unable to load Page: " + ex.toString());
+ }
+
+ return new
WebErrorCodeResponseTarget(HttpServletResponse.SC_NOT_FOUND,
+ "Unable to load Page");
+ }
}
/**
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/request/target/coding/PackageRequestTargetUrlCodingStrategy.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/request/target/coding/PackageRequestTargetUrlCodingStrategy.java?view=diff&rev=537428&r1=537427&r2=537428
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/request/target/coding/PackageRequestTargetUrlCodingStrategy.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/request/target/coding/PackageRequestTargetUrlCodingStrategy.java
Sat May 12 07:10:17 2007
@@ -38,7 +38,9 @@
*/
public class PackageRequestTargetUrlCodingStrategy extends
AbstractRequestTargetUrlCodingStrategy
{
- private static final Logger log =
LoggerFactory.getLogger(PackageRequestTargetUrlCodingStrategy.class);
+ private static final Logger log = LoggerFactory
+ .getLogger(PackageRequestTargetUrlCodingStrategy.class);
+
/** package for this mount. */
private final PackageName packageName;
@@ -61,9 +63,9 @@
*/
public IRequestTarget decode(RequestParameters requestParameters)
{
- log.debug("path="+requestParameters.getPath());
+ log.debug("path=" + requestParameters.getPath());
String remainder =
requestParameters.getPath().substring(getMountPath().length());
- log.debug("remainder="+remainder);
+ log.debug("remainder=" + remainder);
final String parametersFragment;
int ix = remainder.indexOf('/', 1);
if (ix == -1)
@@ -87,8 +89,8 @@
return null;
}
- log.debug("remainder="+remainder);
- log.debug("parametersFragment="+parametersFragment);
+ log.debug("remainder=" + remainder);
+ log.debug("parametersFragment=" + parametersFragment);
final String bookmarkablePageClassName = packageName + "." +
remainder.substring(0, ix);
Class bookmarkablePag
[jira] Resolved: (WICKET-293) PackageRequestTargetUrlCodingStrategy should interrupts the cycle and sends a 404 when a page/class cannot be found.
[
https://issues.apache.org/jira/browse/WICKET-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-293.
---
Resolution: Fixed
Fix Version/s: 1.3
Assignee: Juergen Donnerstag
fixed
> PackageRequestTargetUrlCodingStrategy should interrupts the cycle and sends a
> 404 when a page/class cannot be found.
>
>
> Key: WICKET-293
> URL: https://issues.apache.org/jira/browse/WICKET-293
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3, 2.0
>Reporter: Stephane Bailliez
> Assigned To: Juergen Donnerstag
> Fix For: 1.3
>
>
> Using PackageRequestTargetUrlCodingStrategy and manually hacking the url in
> the browser will throw up a RuntimeException if it cannot load a
> corresponding page class. Same could happen if the bookmarkable page does not
> exist anymore, etc... see stacktrace below.
> The expected behavior is to interrupt the cycle and sends a 404.
> {noformat}
> wicket.WicketRuntimeException: Unable to load class with name:
> com.mycompany.wicket.pages.xyzw
> at
> wicket.application.DefaultClassResolver.resolveClass(DefaultClassResolver.java:70)
> at
> wicket.request.target.coding.PackageRequestTargetUrlCodingStrategy.decode(PackageRequestTargetUrlCodingStrategy.java:80)
> at
> wicket.protocol.http.request.WebRequestCodingStrategy.targetForRequest(WebRequestCodingStrategy.java:363)
> at
> wicket.protocol.http.request.CryptedUrlWebRequestCodingStrategy.targetForRequest(CryptedUrlWebRequestCodingStrategy.java:154)
> at
> wicket.request.compound.DefaultRequestTargetResolverStrategy.resolve(DefaultRequestTargetResolverStrategy.java:84)
> at
> wicket.request.compound.AbstractCompoundRequestCycleProcessor.resolve(AbstractCompoundRequestCycleProcessor.java:47)
> at wicket.RequestCycle.step(RequestCycle.java:1008)
> at wicket.RequestCycle.steps(RequestCycle.java:1100)
> at wicket.RequestCycle.request(RequestCycle.java:454)
> at wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:243)
> at wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-480) IHeaderResponse.renderOnUnLoadJavascript(String javascript);
[
https://issues.apache.org/jira/browse/WICKET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp resolved WICKET-480.
Resolution: Won't Fix
Fix Version/s: 1.3
Sorry, I'm closing this as won't fix. OnUnload works as expected only in FF and
IE. We need to support other browsers as well.
> IHeaderResponse.renderOnUnLoadJavascript(String javascript);
>
>
> Key: WICKET-480
> URL: https://issues.apache.org/jira/browse/WICKET-480
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 1.3
>Reporter: Martin Funk
>Priority: Minor
> Fix For: 1.3
>
>
> Where there is a renderOnLoadJavascript there ought to be a
> renderOnUnLoadJavascript too.
> This is all just copy past, so it's a little smelly.
> Beyond that I wouldn't mind to be able to specify which element an event
> should be added.
> Index:
> wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===
> ---
> wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> (Revision 529942)
> +++
> wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> (Arbeitskopie)
> @@ -197,4 +197,19 @@
> }
> }
>
> + /**
> +* @see
> org.apache.wicket.markup.html.IHeaderResponse#renderOnUnLoadJavascript(java.lang.String)
> +*/
> + public void renderOnUnLoadJavascript(String javascript)
> + {
> + List token = Arrays.asList(new Object[] { "javascript-event",
> "unload", javascript });
> + if (wasRendered(token) == false)
> + {
> +
> renderJavascriptReference(WicketEventReference.INSTANCE);
> + JavascriptUtils.writeJavascript(getResponse(),
> + "Wicket.Event.add(window, \"unload\",
> function() { " + javascript + ";});");
> + markRendered(token);
> + }
> + }
> +
> }
> Index: wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> ===
> --- wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> (Revision 529942)
> +++ wicket/src/main/java/org/apache/wicket/markup/html/IHeaderResponse.java
> (Arbeitskopie)
> @@ -174,4 +174,11 @@
> * @param javascript
> */
> public void renderOnLoadJavascript(String javascript);
> +
> + /**
> +* Renders javascript that is executed after the page is unloaded.
> +*
> +* @param javascript
> +*/
> + public void renderOnUnLoadJavascript(String javascript);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-394) [Patch] do not serialize choices and select in palette.
[ https://issues.apache.org/jira/browse/WICKET-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp reassigned WICKET-394: -- Assignee: Matej Knopp > [Patch] do not serialize choices and select in palette. > > > Key: WICKET-394 > URL: https://issues.apache.org/jira/browse/WICKET-394 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Vincent Demay > Assigned To: Matej Knopp >Priority: Minor > Attachments: AbstractOptions.java.394.patch.txt, > AbstractOptions.java.394.patch.txt, palette.component.394.txt, > wicket-ajax.js.394.patch.txt, wicket-ajax.js.394.patch.txt, > wicket-ajax.js.394.txt > > > It takes a long useless time -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-406) form fields are reset when a file upload fails
[ https://issues.apache.org/jira/browse/WICKET-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495273 ] Matej Knopp commented on WICKET-406: I'm not sure if it's possible to process the fields in this case. When the request size exceeds limit, the multipart request shouldn't be processed at all. > form fields are reset when a file upload fails > -- > > Key: WICKET-406 > URL: https://issues.apache.org/jira/browse/WICKET-406 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.2, 1.2.3, 1.2.4, 1.2.5 > Environment: Tomcat 5.5.9 , windows 2000 SP2 >Reporter: Jaime De La Jara >Priority: Minor > > If a form contains some fields and a file field, when an uploads fails (for > example exceeds the maximum size) the form fields are reset. A better > behaviour would be to group all failed validations and show all the messages > at once. The relevant code is in class wicket.markup.html.form.Form in method > onFormSubmitted, where the condition of handleMultipart is first checked and > if it has not been completed the method returns, without processing the rest > of the fields. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-393) [Patch]Improve ajax form serialization and allows nested from serialization
[ https://issues.apache.org/jira/browse/WICKET-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-393. Resolution: Fixed > [Patch]Improve ajax form serialization and allows nested from serialization > --- > > Key: WICKET-393 > URL: https://issues.apache.org/jira/browse/WICKET-393 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Vincent Demay >Priority: Minor > Attachments: wicket-ajax.js.txt > > > On our application the form serialization took 313ms now with this new > serialisation it take 24ms. > I also add support of nested form (in order to submit parent form when you > submit a nested form). > I don't know if I test all use cases with that but I test nested form in a > window and simple nested form. > Matej_k : WDYT? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-152) Automatic multi window support and XHTML validation
[ https://issues.apache.org/jira/browse/WICKET-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-152. Resolution: Won't Fix > Automatic multi window support and XHTML validation > --- > > Key: WICKET-152 > URL: https://issues.apache.org/jira/browse/WICKET-152 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 2.0 >Reporter: John Major >Priority: Minor > Attachments: wicket2.0-152.patch > > > With automatic multi window support enabled, Wicket is adding an id attribute > to the script element that contains a character that prevents XHTML > validation. For example, > id="wicket.markup.html.WebPage$PageMapChecker">]]>*/ > exhibits the problem as valid XHTML disallows the $ within the id attribute. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-556) Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its contributing component has been replaced
[
https://issues.apache.org/jira/browse/WICKET-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp reassigned WICKET-556:
--
Assignee: Matej Knopp
> Prevent setTimeout for AjaxSelfUpdatingTimerBehavior from firing after its
> contributing component has been replaced
> ---
>
> Key: WICKET-556
> URL: https://issues.apache.org/jira/browse/WICKET-556
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Reporter: Jim McLaughlin
> Assigned To: Matej Knopp
>
> Currently, the setTimeout for an AjaxTimerBehavior will fire after the
> contributing component has been replaced or removed through an ajax request.
> This will result in an exception server side and a full page refresh client
> side.
> One possible solution is to override getCallbackScript() to enclose the ajax
> callback in another function that will only execute the ajax request if the
> markup for the contributing component is still in the dom tree:
> protected CharSequence getCallbackScript(boolean
> recordPageVersion)
> {
> String mId = getComponent().getMarkupId();
> StringBuilder sb = new StringBuilder("exec_func(function() {
> ");
> sb.append("var el = wicketGet('" + mId + "'); ");
> sb.append("if(null != el) {");
> sb.append(super.getCallbackScript(recordPageVersion));
> sb.append("}");
> sb.append("})");
>
> return sb.toString ();
> }
> Other options are to have the request cycle swallow the "component not found"
> exception for timer behaviors (since they will only fire 1 extra time)
> or
> a more complicated scheme would involve wicket actively managing javascript
> timer tokens client side so that they can be removed with clearTimeout when
> their contributing component is removed through an ajax request. The
> javascript to do this would be trivial (a simple container object mapping dom
> id to timer token), but the wicket lifecycle would need to support an
> onRemove callback for components to perform cleanup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-139) DefaultTreeState allowSelectMultiple == false not evaluated when selecting node already selected
[ https://issues.apache.org/jira/browse/WICKET-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp reassigned WICKET-139: -- Assignee: Matej Knopp > DefaultTreeState allowSelectMultiple == false not evaluated when selecting > node already selected > > > Key: WICKET-139 > URL: https://issues.apache.org/jira/browse/WICKET-139 > Project: Wicket > Issue Type: Bug > Components: wicket >Reporter: Jim McLaughlin > Assigned To: Matej Knopp >Priority: Minor > Attachments: defaulttreestate.patch > > > selectNode will not process the change from allowSelectMultiple == true to > allowSelectMultiple == false when selectNode is called on a TreeNode that is > already in the selectedNodes set -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-527) Panel header contribution breaks AJAX update in Internet Explorer
[ https://issues.apache.org/jira/browse/WICKET-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp reassigned WICKET-527: -- Assignee: Matej Knopp > Panel header contribution breaks AJAX update in Internet Explorer > - > > Key: WICKET-527 > URL: https://issues.apache.org/jira/browse/WICKET-527 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.6 >Reporter: John Krasnay > Assigned To: Matej Knopp > Attachments: quickstart.zip > > > If a Panel subclass makes a header contribution via , and the > panel code attempts to refresh itself in response to an AjaxLink click, the > refresh does not work on IE. The debug window shows the following error: > INFO: > INFO: Initiating Ajax GET request on > /arp/?wicket:interface=:0:subComponent:link::IBehaviorListener&wicket:behaviorId=0&random=0.8818904450460203 > INFO: Invoking pre-call handler(s)... > INFO: Received ajax response (656 characters) > INFO: > encoding="UTF-8"?> > > ERROR: Error while parsing response: Object required > INFO: Invoking post-call handler(s)... > INFO: Invoking failure handler(s)... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-491) problem with browser back-button and links after ajax replace
[ https://issues.apache.org/jira/browse/WICKET-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-491. Resolution: Fixed Fix Version/s: 1.3 Works well with latest wicket > problem with browser back-button and links after ajax replace > - > > Key: WICKET-491 > URL: https://issues.apache.org/jira/browse/WICKET-491 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp > Fix For: 1.3 > > Attachments: test-quickstart.zip > > > I'm having this problem when I back-button to a page with a panel that > replaced itself with another panel containing a link - and re-try the link: > WicketMessage: Method onLinkClicked of interface > org.apache.wicket.markup.html.link.ILinkListener targeted at component > [MarkupContainer [Component id = link, page = test.HomePage, path = > 0:panel:link.FirstPanel$1, isVisible = true, isVersioned = true]] threw an > exception > Root cause: > java.lang.IllegalArgumentException: object is not an instance of declaring > class > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:39) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:186) > at > org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents > (ListenerInterfaceRequestTarget.java:73) > at > org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:90) > at org.apache.wicket.RequestCycle.processEventsAndRespond > (RequestCycle.java:975) > at org.apache.wicket.RequestCycle.step(RequestCycle.java:1048) > at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1127) > at org.apache.wicket.RequestCycle.request(RequestCycle.java :489) > at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248) > I'm attaching a quickstart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-491) problem with browser back-button and links after ajax replace
[ https://issues.apache.org/jira/browse/WICKET-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp reassigned WICKET-491: -- Assignee: Matej Knopp > problem with browser back-button and links after ajax replace > - > > Key: WICKET-491 > URL: https://issues.apache.org/jira/browse/WICKET-491 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Peter Thomas > Assigned To: Matej Knopp > Attachments: test-quickstart.zip > > > I'm having this problem when I back-button to a page with a panel that > replaced itself with another panel containing a link - and re-try the link: > WicketMessage: Method onLinkClicked of interface > org.apache.wicket.markup.html.link.ILinkListener targeted at component > [MarkupContainer [Component id = link, page = test.HomePage, path = > 0:panel:link.FirstPanel$1, isVisible = true, isVersioned = true]] threw an > exception > Root cause: > java.lang.IllegalArgumentException: object is not an instance of declaring > class > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:39) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:186) > at > org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents > (ListenerInterfaceRequestTarget.java:73) > at > org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:90) > at org.apache.wicket.RequestCycle.processEventsAndRespond > (RequestCycle.java:975) > at org.apache.wicket.RequestCycle.step(RequestCycle.java:1048) > at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1127) > at org.apache.wicket.RequestCycle.request(RequestCycle.java :489) > at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:248) > I'm attaching a quickstart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-418) Ajax requests don't detach component models
[ https://issues.apache.org/jira/browse/WICKET-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-418. Resolution: Fixed Fix Version/s: 1.3 > Ajax requests don't detach component models > --- > > Key: WICKET-418 > URL: https://issues.apache.org/jira/browse/WICKET-418 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 >Reporter: Matej Knopp > Assigned To: Matej Knopp > Fix For: 1.3 > > > After ajax request the component models are not detached. Page onDetach > should detach those models, but since the page itself is not attached, the > onDetach method is not called. > It's necessary to always call page.detachModels after request. And we should > only call page.detach from the request target. The ajax request target should > not page.detach, as the behaviorrequesttarget should do that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-116) Within a ModalWindow, mouse cursor incorrectly appears as an arrow when over text
[
https://issues.apache.org/jira/browse/WICKET-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp resolved WICKET-116.
Resolution: Fixed
Fix Version/s: 1.3
Fixed for 1.3
> Within a ModalWindow, mouse cursor incorrectly appears as an arrow when over
> text
> -
>
> Key: WICKET-116
> URL: https://issues.apache.org/jira/browse/WICKET-116
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
>Affects Versions: 1.2.3
> Environment: WinXP, Firefox 2.0
>Reporter: Charlie Dobbie
> Assigned To: Matej Knopp
> Fix For: 1.3
>
> Attachments: modal-window-cursor-testcase.html
>
>
> modal.css includes the following:
> div.wicket-modal div.w_content_1 {
> margin-right: 10px;
> cursor: default;
> }
> The "default" cursor is an arrow. If this instead uses the directive
> "cursor: auto;" the browser is free to pick the appropriate mouse cursor, so
> it will appear as a text-selection cursor when over text, for example. I
> have a hacked-up HTML test case, to be added shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r537413 - /incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css
Author: knopp
Date: Sat May 12 06:14:48 2007
New Revision: 537413
URL: http://svn.apache.org/viewvc?view=rev&rev=537413
Log:
WICKET-525
Modified:
incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css
Modified:
incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css?view=diff&rev=537413&r1=537412&r2=537413
==
---
incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.css
Sat May 12 06:14:48 2007
@@ -106,7 +106,7 @@
div.wicket-modal div.w_content_1 {
margin-right: 10px;
- cursor: default;
+ cursor: auto;
}
[jira] Commented: (WICKET-175) Page.onDetach is called by each ComponentResourceRequestTarget
[ https://issues.apache.org/jira/browse/WICKET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495267 ] Matej Knopp commented on WICKET-175: I think we can close this too,. > Page.onDetach is called by each ComponentResourceRequestTarget > -- > > Key: WICKET-175 > URL: https://issues.apache.org/jira/browse/WICKET-175 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3, 2.0 >Reporter: Alastair Maw > Fix For: 1.3, 2.0 > > > ComponentResourceRequestTarget#detach(RequestCycle) calls > page#internalDetach() > This results in Page#onDetach() being called as many times as there are > images or whatever on your page, which seems entirely wrong. Mentioned this > to ivaynberg on IRC and he said: "we should have theadlocal guards". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-519) remove page versions from the second level cache when explicitly removed
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495265 ] Matej Knopp commented on WICKET-519: Sure we can do that. But thinking of it, there are so many simple ways of making the page no longer available in wicket (e.g add a obsolete flag and check it in onatach)... > remove page versions from the second level cache when explicitly removed > > > Key: WICKET-519 > URL: https://issues.apache.org/jira/browse/WICKET-519 > Project: Wicket > Issue Type: Bug > Components: wicket >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3 > > > Someone at Matej's session had an interesting question about how pages can be > removed from the history when you explictly want to avoid users being able to > go back to that version (i.e. expire them). Removing the page from the page > map works fine with the HttpSessionStore, but doesn't with > SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage > just removes from pending but once it is serialized to disk, it will always > be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) > should remove it from second level cache so that it is in effect expired. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-278) Error pages for HeaderContributor errors are broken
[
https://issues.apache.org/jira/browse/WICKET-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Knopp resolved WICKET-278.
Resolution: Fixed
I believe this is fixed already
> Error pages for HeaderContributor errors are broken
> ---
>
> Key: WICKET-278
> URL: https://issues.apache.org/jira/browse/WICKET-278
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3
>Reporter: Alastair Maw
> Fix For: 1.3
>
>
> This manifests itself with lots of java.io.NotSerializableException:
> wicket.response.StringResponse and errors like this:
> 08:58:09,083 WARN Objects:1287 - Size of failed of object:
> wicket.markup.html.HeaderPartContainer
> Al says:
> The errors are caused by the Wicket exception page (which is why there are a
> million components - they're all the Labels for the various
> components/traces/whatever).
> This is what I think goes wrong:
> HtmlHeaderContainer throws an exception while rendering, or something, such
> that its onDetach() is never called on it. This causes the reference it has
> to headerResponse to never be set to null. It therefore has a ref to a
> HeaderResponse, which has a ref to the Response object itself.
> We need to fix it so that onDetach() is always called, I guess. Probably need
> to work out where to put the try {} finally {}, essentially.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-433) improved reporting on locked page maps
[ https://issues.apache.org/jira/browse/WICKET-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495262 ] Matej Knopp commented on WICKET-433: Even more useful would be to have the stack-strace. I think we can do that, but only for java 5. So what we should do is an extension point where user could plug in a class that would write a stacktrace for him (if he uses 1.5). > improved reporting on locked page maps > -- > > Key: WICKET-433 > URL: https://issues.apache.org/jira/browse/WICKET-433 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3 >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3 > > > It would be cool if we could log some more information on which request is > locking another request when it times out. Currently, we get an error like: > exception: After 1 minute the Pagemap null is still locked by: Thread[Jetty > thread-105,5,main], giving up trying to get the page for path: 0:1 > but Thread[Jetty thread-105,5,main] is hardly useful in a log. More useful > would be e.g. the request target. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-214) Call all behaviors attached to the same event
[ https://issues.apache.org/jira/browse/WICKET-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495261 ] Matej Knopp commented on WICKET-214: I don't really like this. We could use Wicket.Event for attaching events on to component instead of the attributes, but this would result in multiple ajax calls. I doubt that this is desirable. > Call all behaviors attached to the same event > - > > Key: WICKET-214 > URL: https://issues.apache.org/jira/browse/WICKET-214 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.2.4, 1.3, 2.0 >Reporter: Erik van Oosten > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > If one adds 2 AjaxFormComponentUpdatingBehaviors with event "onchange" to the > same form component, only the behavior that was added last will actually be > called. Please make it so that both are called. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-176) Introduce AjaxFormElementValidatingBehavior
[ https://issues.apache.org/jira/browse/WICKET-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495260 ] Matej Knopp commented on WICKET-176: Is this still relevant? Do we want/need this in core? > Introduce AjaxFormElementValidatingBehavior > --- > > Key: WICKET-176 > URL: https://issues.apache.org/jira/browse/WICKET-176 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 1.2.3 >Reporter: Erik van Oosten > Assigned To: Eelco Hillenius > Fix For: 1.3, 2.0 > > Attachments: AjaxFormComponentValidatingBehavior.java, > AjaxFormComponentValidatingBehavior.java > > > There is currently no easy way to validate a single form element using Ajax. > Please add attached code to the Wicket-core. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-343) AbstractAjaxTimerBehavior only trigger one request
[ https://issues.apache.org/jira/browse/WICKET-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Knopp resolved WICKET-343. Resolution: Fixed Won't fix this for 2.0, as it's no longer maintained. > AbstractAjaxTimerBehavior only trigger one request > -- > > Key: WICKET-343 > URL: https://issues.apache.org/jira/browse/WICKET-343 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3 > Environment: Firefox 2.0.0.2 >Reporter: Xavier Hanin > Assigned To: Johan Compagner > Fix For: 1.3 > > > AbstractAjaxTimerBehavior only triggers one request and then stop. The clock > example in wicket-examples show the problem. Reverting to revision 511893 > fixes the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-549) should be accessible in wicket
[ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-549. --- Resolution: Fixed Fix Version/s: 1.3 Assignee: Juergen Donnerstag It should now be possible. See SimplePageTest_13 > should be accessible in wicket > - > > Key: WICKET-549 > URL: https://issues.apache.org/jira/browse/WICKET-549 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Peter Ertl > Assigned To: Juergen Donnerstag > Fix For: 1.3 > > > --- issue copy-pasted from mailing list --- > On 5/9/07, Peter Ertl <[EMAIL PROTECTED]> wrote: > Hi folks, > I try to setup a multi-language website like that: > > http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";> > http://www.w3.org/1999/xhtml"; > xmlns:lang=[current language] lang=[current language]> > > However, accessing using a wicket:id will fail: > org.apache.wicket.WicketRuntimeException: Programming > error: 'parent' should be a Page or a Border. > changing the tag using a MarkupFilter will also fail as it requires to > value of the current locale of WebSession > but the markup filter seems to allow no access to it. > It would be straightforward to just access html using a wicket:id... > *imho* this would be a great enhancement! > Can somebody think of a better solution? > On 5/9/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > hmm this is because of the HtmlHeaderContainer that container wants a page > to be its parent. > So you can't attach a wicket container to the html because then you > encapsulate the complete page. > i dont know immediantly how to solve this -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r537371 - in /incubator/wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/ main/java/org/apache/wicket/markup/ main/java/org/apache/wicket/markup/html/internal/ main/java/org/ap
Author: jdonnerstag
Date: Sat May 12 02:58:18 2007
New Revision: 537371
URL: http://svn.apache.org/viewvc?view=rev&rev=537371
Log:
wicket-549: allow to attach components to the tag.
It is now possible to attach a wicket component to for example to modify
the xmlns:lang or lang attribute. A test has been added as well.
Fixed OnChangeAjaxBehaviorTest who's test output was based on English locale.
Added:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/BodyContainerResolver.java
(with props)
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/basic/SimplePageExpectedResult_13.html
(with props)
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_13.html
(with props)
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_13.java
(with props)
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/WicketTag.java
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/ajax/form/OnChangeAjaxBehaviorTest.java
incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/basic/SimplePageTest.java
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application.java?view=diff&rev=537371&r1=537370&r2=537371
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application.java
Sat May 12 02:58:18 2007
@@ -34,6 +34,7 @@
import org.apache.wicket.markup.parser.filter.RelativePathPrefixHandler;
import org.apache.wicket.markup.parser.filter.WicketMessageTagHandler;
import org.apache.wicket.markup.resolver.AutoComponentResolver;
+import org.apache.wicket.markup.resolver.BodyContainerResolver;
import org.apache.wicket.markup.resolver.EnclosureResolver;
import org.apache.wicket.markup.resolver.FragmentResolver;
import org.apache.wicket.markup.resolver.HtmlHeaderResolver;
@@ -856,6 +857,7 @@
{
settingsAccessible = true;
IPageSettings pageSettings = getPageSettings();
+
// Install default component resolvers
pageSettings.addComponentResolver(new ParentResolver());
pageSettings.addComponentResolver(new AutoComponentResolver());
@@ -868,6 +870,7 @@
pageSettings.addComponentResolver(new
RelativePathPrefixHandler());
pageSettings.addComponentResolver(new EnclosureResolver());
pageSettings.addComponentResolver(new
WicketContainerResolver());
+ pageSettings.addComponentResolver(new BodyContainerResolver());
// Install button image resource factory
getResourceSettings().addResourceFactory("buttonFactory",
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java?view=diff&rev=537371&r1=537370&r2=537371
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/ComponentTag.java
Sat May 12 02:58:18 2007
@@ -93,7 +93,6 @@
*/
private boolean hasNoCloseTag = false;
-
/** added behaviors */
// FIXME these behaviors here are merely for wicket:message attributes
on
// tags that are also wicket components. since this addition behavors
have
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/WicketTag.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/WicketTag.java?view=diff&rev=537371&r1=537370&r2=537371
==
---
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/WicketTag.java
(original)
+++
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/WicketTag.java
Sat May 12 02:58:18 2007
@@ -100,14 +100,6 @@
}
/**
-* @return True,
