Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler_warnings_062017 into lp:widelands

2017-06-18 Thread Klaus Halfmann
Gun: I can eventually setup that new Branch as sirver suggested at tuesday,
I would just call it compiler_warnings_20170618 or such.
OK?
-- 
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_062017/+merge/325717
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/compiler_warnings_062017.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands

2017-06-18 Thread kaputtnik
Review: Needs Fixing

I got a crash when trying to open the buildings statistics menu:

widelands: 
/home/kaputtnik/widelands-repo/bug-1697242-fileview/src/ui_basic/tabpanel.cc:313:
 virtual void UI::TabPanel::draw(RenderTarget&): Assertion `x <= get_w()' 
failed.

Played in fullscreen with initial resolution 800x600. Tested this three times 
and on the second try the crash happens only after opening the buildings 
statistics menu the second time (press B (open), press B (close), press B -> 
crash). The first and third try the crash happens after the first try to open 
the buildings statistics menu.

To be sure i opened also a new game with this branch, and after hitting 'B' 
several times the crash happens.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1697242-fileview.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-winconditions into lp:widelands

2017-06-18 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fh1-winconditions into 
lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/fh1-winconditions.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp


Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-winconditions into lp:widelands

2017-06-18 Thread GunChleoc
Thanks for the review :)

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/fh1-winconditions.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp