[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1697242-fileview into lp:widelands
Review: Approve lgtm. This seems like a net simplification to me, which is always great :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1697242-fileview/+merge/325456 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1697242-fileview. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-osx into lp:widelands
Review: Needs Fixing I think building on Mac OS is sufficient, the logic should be unchanged. And I also do not think that we require a ton of compilers there - one build should be sufficient. We test all the compilers on Linux and they should be compatible across OSes. The test suite would be nice, but is run by me on OS X for each daily I build, so it is not super critical either. I think this can go as is. Thanks for your work, as usual :). However, the .travis.yml file seems to be broken right now (see last bunnybot comment), so this needs to get fixed first. -- https://code.launchpad.net/~widelands-dev/widelands/travis-osx/+merge/327490 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-osx. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_cmakelist into lp:widelands
Review: Approve Anything that's in the src dir only needs to be added to a local CMakeList.txt, which you have done. @Klaus: Travis can't do Windows, which is why we have AppVeyor. Let's get this in ASAP, thanks for the fix! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_cmakelist/+merge/328630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_cmakelist. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
