[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands
Continuous integration builds have changed state: Travis build 3020. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/324319958. Appveyor build 2828. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_seafaring_fix-2828. -- https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_fix/+merge/335640 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands
TiborB has proposed merging lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_fix/+merge/335640 The allows_seafaring rework some time ago damaged the functionality of AI seafaring. One of basic issue is that AI expected that if map is not seafaring (and brief time after game start it is by default so), it disabled all seafaring activities forever. So AI can have shipyard building ships forever and never stop it and never start preparation for expedition. Entire concept of switching seafaring map ON/OFF in AI is bit fragile... -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_seafaring_fix into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/better_notification_mail into lp:widelands-website
Review: Needs Fixing I found a bug in this code which needs fixing. -- https://code.launchpad.net/~widelands-dev/widelands-website/better_notification_mail/+merge/335028 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp