Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands
Review: Approve LGTM. The target should stay in I'd say, since it is an second tier ware. And AFAIK currently all second tier wares have economy targets. So why make an exception here? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/+merge/361290 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1809838-blackroot-target. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands
Launchpad failed to parse the branch. Here is the only commit: https://bazaar.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/revision/8955 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/+merge/361290 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands
Continuous integration builds have changed state: Travis build 4369. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/472649794. Appveyor build 4162. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_blackroot_target-4162. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/+merge/361290 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands. Commit message: Adding missing check whether blackroot flour is required. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1809838 in widelands: "Blackroot flour economy target is ignored" https://bugs.launchpad.net/widelands/+bug/1809838 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/+merge/361290 Checking in the production program whether blackroot flour is required before grinding blackroot, so the economic target is respected. It might be that this isn't checked on purpose, since different from corn there is no other use for blackroot. If the check shouldn't be in the production program, the economy target for blackroot flour should be removed instead. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1809838-blackroot-target into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
