Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1814372-lua-gametype into lp:widelands
Okay, looking better now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1814372-lua-gametype/+merge/362638 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1814372-lua-gametype into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1814372-lua-gametype into lp:widelands
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1814372-lua-gametype into lp:widelands. Commit message: Adding lua method to get the type of the current game, i.e., single or multiplayer. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1814372 in widelands: "Make single/multiplayer mode accessible to lua" https://bugs.launchpad.net/widelands/+bug/1814372 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1814372-lua-gametype/+merge/362638 This allows scripts to differentiate between single- and multiplayer games, allowing to adapt to restrictions of multiplayer games. The idea for this came up while debugging desyncs, since the lua sleep() command can lead to desyncs in multiplayer if not used properly (i.e., for all players at the same time). -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1814372-lua-gametype into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands
A branch with the requested lua method is up: https://code.launchpad.net/~widelands-dev/widelands/bug-1814372-lua-gametype/+merge/362638 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1810062-territorial-calculations into lp:widelands
Hi I figured out a solution to check the caps of a field without taking immovables into account. Basicly I just added a lua hook and a new field property "max_caps". This solution speeds up the algorithm because we don't have to take immovable fields into account for the accesibility loops. Question is shall I push another revision to this branch with my changes or shall I push a new branch? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1810062-territorial-calculations/+merge/361366 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1810062-territorial-calculations into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands
This is merged into trunk now. New bug: https://bugs.launchpad.net/widelands/+bug/1814372 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial into lp:widelands
Looks like bunnybot is in winter sleep ... The travis error is about curl, and i would wonder if the changes would affect building widelands at all, since only some lua code is changed. > But if notabilis implements the single- multiplayer?-method we wouldn't need > this branch here... I think we need this change in this branch to get closer to the next official release. And i think the changes are straightforward and do not change anything for the players. Implementing a single/multiplayer switch does not affect this branch, except the documentation. It would 'only' harden the codebase against possible mistakes when using the wrong functions, imho. I will create a new bug report to make the single/multiplayer mode accessible in lua, and merge this branch by hand. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1811583-desync-with-territorial/+merge/362272 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1811583-desync-with-territorial. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
