[Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/economy-target-profiles. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands
Continuous integration builds have changed state: Travis build 5411. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/582115732. Appveyor build 5181. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_economy_target_profiles-5181. -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/economy-target-profiles. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands
Continuous integration builds have changed state: Travis build 5408. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/582051006. Appveyor build 5178. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-5178. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ferry. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/relax-ai-asserts. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands
Thanks for the review :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/relax-ai-asserts. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands
Fix confirmed :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/economy-target-profiles. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands
Fixed as well now -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/economy-target-profiles. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands
Review: Approve I can't think of a cleaner solution either at this point, so code LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/economy-target-profiles. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/refactor_gamehost into lp:widelands
LAN or Internet game? -- https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/refactor_gamehost. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands
Continuous integration builds have changed state: Travis build 5404. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/581765188. Appveyor build 5174. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_relax_ai_asserts-5174. -- https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/relax-ai-asserts. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/refactor_gamehost into lp:widelands
Review: Needs Fixing Looks like I must check this with a debugger, get his wheh joining a netwok game in trunk Assertion failed: (clients_.at(id).state_ == Client::State::kConnected), function try_receive, file ../src/network/nethostproxy.cc, line 76. -- https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/refactor_gamehost. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Review: Approve local tests ok -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
The UI test sometimes fails because it takes too long for the game to close. I have implemented a fix in one of my other branches. Will rerun the Travis job. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Mhh,one test in travis fails test/maps/plain.wmf/scripting/test_ui.lua ... Running Widelands ... FAIL But only for GCC_VERSION="4.9" BUILD_TYPE="Debug" ? will run the test loocally, too -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Review: Approve Locally commpiles without issues. Start upto Lobby was fine. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 5399. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/581705807. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Thanks for the review! I already did a code review on your branch, I guess you overlooked it. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/refactor_gamehost into lp:widelands
You just asked for a review. See my comment above. -- https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/refactor_gamehost into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands
Review: Approve * Replaced: - widelands_ball_of_mud + widelands_options -> fine * Codestyle: using this for a member function makes no sense. * Smuggeled in some USE_XDG handling :-) Will compile and start this, not doing much testing. Please: review my refactor_gamehost before merging it becomes to much pain. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
