[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe 
into lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[GunChleoc]

Thanks!

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[Notabilis]

Review: Approve

Code is looking good and last player has no longer the "random" tribe.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 4137. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/441494752.
Appveyor build 3934. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1797531_playermenu_tribe-3934.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

[GunChleoc]

GunChleoc has proposed merging 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands.

Commit message:
Fix initialization of last player dropdown in editor player menu

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695

Player number start with 1, not with 0...
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands.
=== modified file 'src/editor/ui_menus/player_menu.cc'
--- src/editor/ui_menus/player_menu.cc	2018-08-28 18:27:59 +
+++ src/editor/ui_menus/player_menu.cc	2018-10-15 05:06:59 +
@@ -184,7 +184,7 @@
 		}
 
 		plr_tribe->select(
-		   (p < map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
+		   (p <= map.get_nrplayers() && Widelands::tribe_exists(map.get_scenario_player_tribe(p))) ?
 		  map.get_scenario_player_tribe(p) :
 		  "");
 		plr_tribe->selected.connect(

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp