[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/bug-1806230-enable-ok-button 
into lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1806230-enable-ok-button/+merge/361163
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 4363. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/472186116.
Appveyor build 4156. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1806230_enable_ok_button-4156.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1806230-enable-ok-button/+merge/361163
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands

[bunnybot]

Refusing to merge, since Travis is not green. Use @bunnybot merge force for 
merging anyways.

Travis build 4350. State: failed. Details: 
https://travis-ci.org/widelands/widelands/builds/470244109.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1806230-enable-ok-button/+merge/361163
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands

[GunChleoc]

Review: Approve

LGTM :)

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1806230-enable-ok-button/+merge/361163
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands

[Notabilis]

Notabilis has proposed merging 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands.

Commit message:
Enabling OK button in map options of editor when tags are changed.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1806230 in widelands: "Editor: Map tags not changeable"
  https://bugs.launchpad.net/widelands/+bug/1806230

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1806230-enable-ok-button/+merge/361163

Adding the missing linkage between changes to the tabs and enabling the OK 
button in the map option menu of the editor.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1806230-enable-ok-button into lp:widelands.
=== modified file 'src/editor/ui_menus/main_menu_map_options.cc'
--- src/editor/ui_menus/main_menu_map_options.cc	2018-12-13 07:24:01 +
+++ src/editor/ui_menus/main_menu_map_options.cc	2018-12-19 21:39:17 +
@@ -129,6 +129,7 @@
 	// TODO(GunChleoc): We need team images in the listselect here,
 	// so map editors will be able to delete entries.
 	// This is waiting for the new RT renderer.
+	// TODO(Notabilis): Add onChanged-code below after this is added
 	teams_list_.add("Not implemented yet.", "", nullptr, false);
 
 	unsigned int nr_players = static_cast(eia().egbase().map().get_nrplayers());
@@ -148,6 +149,9 @@
 	author_.changed.connect(boost::bind(::changed, this));
 	descr_->changed.connect(boost::bind(::changed, this));
 	hint_->changed.connect(boost::bind(::changed, this));
+	for (const auto& tag : tags_checkboxes_) {
+		tag.second->changed.connect(boost::bind(::changed, this));
+	}
 
 	ok_.sigclicked.connect(boost::bind(::clicked_ok, boost::ref(*this)));
 	cancel_.sigclicked.connect(boost::bind(::clicked_cancel, boost::ref(*this)));

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp