[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/bug-1809838-document-mill 
into lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1809838-document-mill.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[GunChleoc]

@bunnybot merge force
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1809838-document-mill.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[GunChleoc]

Review: Approve


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1809838-document-mill.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 4631. State: errored. Details: 
https://travis-ci.org/widelands/widelands/builds/510422490.
Appveyor build 4418. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_document_mill-4418.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[bunnybot]

Continuous integration builds have changed state:

Travis build 4613. State: errored. Details: 
https://travis-ci.org/widelands/widelands/builds/508113746.
Appveyor build 4400. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_document_mill-4400.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[GunChleoc]

Text looks good, Can you make it translatable, please?

pgettext("atlanteans_building", text)

Let's have it for Build 21 so we won't break string freeze again.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands

[Notabilis]

Notabilis has proposed merging 
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.

Commit message:
Documenting "strange" behavior of atlanteans mill for players.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1809838 in widelands: "Blackroot flour economy target is ignored"
  https://bugs.launchpad.net/widelands/+bug/1809838

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704

The mill is always grinding blackroot, even when the economy target is met. 
This branch documents this behavior for players so it isn't considered/reported 
as bug.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.
=== modified file 'data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua'
--- data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua	2018-05-04 20:38:53 +
+++ data/tribes/buildings/productionsites/atlanteans/mill/helptexts.lua	2019-03-18 20:58:41 +
@@ -18,7 +18,7 @@
 
 function building_helptext_note()
-- TRANSLATORS#: Note helptext for a building
-   return ""
+   return "When no cornmeal is required, the mill will try to produce blackroot flour even when there is no demand for it."
 end
 
 function building_helptext_performance()

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp