[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/net-more-resolve-logging/+merge/368955 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-more-resolve-logging. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands
Review: Approve LGTM :) inputqueues @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/net-more-resolve-logging/+merge/368955 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-more-resolve-logging. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands
Continuous integration builds have changed state: Travis build 5197. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/547099205. Appveyor build 4976. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_net_more_resolve_logging-4976. -- https://code.launchpad.net/~widelands-dev/widelands/net-more-resolve-logging/+merge/368955 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands
Notabilis has proposed merging lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands. Commit message: More log output if trying to resolve network addresses Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/net-more-resolve-logging/+merge/368955 Some more log output to help debug network problems. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands. === modified file 'src/network/network.cc' --- src/network/network.cc 2019-02-23 11:00:49 + +++ src/network/network.cc 2019-06-18 06:13:12 + @@ -38,14 +38,19 @@ boost::asio::ip::tcp::resolver::iterator iter = resolver.resolve(query); if (iter == boost::asio::ip::tcp::resolver::iterator()) { // Resolution failed + log("Could not resolve network name '%s:%u' to %s-address\n", hostname.c_str(), +port, ((protocol == boost::asio::ip::tcp::v4()) ? "IPv4" : "IPv6")); return false; } addr->ip = iter->endpoint().address(); addr->port = port; + log("Resolved network name '%s:%u' to %s\n", + hostname.c_str(), port, addr->ip.to_string().c_str()); return true; } catch (const boost::system::system_error& ec) { // Resolution failed - log("Could not resolve network name: %s\n", ec.what()); + log("Could not resolve network name '%s:%u' to %s-address: %s\n", hostname.c_str(), + port, ((protocol == boost::asio::ip::tcp::v4()) ? "IPv4" : "IPv6"), ec.what()); return false; } } ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp