Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands
typo: Without this check - Without this patch -- https://code.launchpad.net/~widelands-dev/widelands/soldierselect_radiobutton/+merge/176784 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/soldierselect_radiobutton. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands
I agree that the new buttons look really good, and that their placement is good as well. Thanks! Glad that you like it that way too. However, start and stop buttons have now appeared to the lower left corner. Good catch - I messed that up. I added something along the lines of your patch and merged the branch. not dynamic_castconst Widelands::MilitarySite *(productionsite) btw, we have a convenience macro for this is_a(Widelands::Militarysite, productionsite) -- https://code.launchpad.net/~widelands-dev/widelands/soldierselect_radiobutton/+merge/176784 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/soldierselect_radiobutton. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands
Review: Approve Looks good and works great. I also like those new icons. Should there be such option for training sites as well, so we can choose to train rookies or heroes ? I have no idea if the underlying logic could allow this -- https://code.launchpad.net/~widelands-dev/widelands/soldierselect_radiobutton/+merge/176784 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/soldierselect_radiobutton. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands
About trainingsites: How should these options differ? Currently, there is an option regarding whether the trainingsite attempts to train least-trained guy or most-trained guy, if there are more than one tha could be trained in a step. There is no UI for that. Also, it would be relatively easy to switch on/off the whole premature soldier-layoff feature. -- https://code.launchpad.net/~widelands-dev/widelands/soldierselect_radiobutton/+merge/176784 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/soldierselect_radiobutton. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp