[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509
Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed:
What|Removed |Added
CC||mediawiki-bugs@nadir-seen-f
||ire.com
--- Comment #11 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com
2011-11-21 09:45:08 UTC ---
The proper way to do this now in current code:
- Use userpage-anon and userpage-user for classes, they fit in better with the
ns-* page-* pattern that we already have going with classes. ip-userpage is an
odd break from that. (note don't use something like page-anonuser since that
would conflict with a page titled [[Anonuser]])
- Code would go in OutputPage::headElement, likely right after the
`$bodyAttrs['class'] .= ' ' . $sk-getPageClasses( $this-getTitle() );` line.
- You'd probably move the $this-getTitle() from that to a $title variable and
use it in getPageClasses as well.
if ( $title-getNamespace() == NS_USER || $title-getNamespace() ==
NS_USER_TALK ) {
// Don't show the class on subpages
if ( !$title-isSubpage() ) {
$bodyAttrs['class'] .= ' ' . ( User::isIP( $this-getTitle() ) ?
'userpage-anon' : 'userpage-user' );
}
}
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Keywords|design, need-review, patch | CC||roan.katt...@gmail.com --- Comment #9 from Roan Kattouw roan.katt...@gmail.com 2011-11-20 18:01:54 UTC --- These patches don't apply at all, marking them as obsolete. pageclass et al seem to have disappeared in one of the recent skin system refactorings, so I don't really know how to apply this to trunk. Removing design keyword, it's not really needed IMO because the default design isn't changed at all, this'll just enable people to do certain things in their own CSS more conveniently. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Attachment #4508|0 |1 is obsolete|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Attachment #4509|0 |1 is obsolete|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 --- Comment #10 from Sumana Harihareswara suma...@panix.com 2011-11-20 20:52:05 UTC --- rememberthedot, are you interested in revising this patch to work with current trunk? Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords||design CC||suma...@panix.com Component|General/Unknown |User interface --- Comment #8 from Sumana Harihareswara suma...@panix.com 2011-11-06 14:25:34 UTC --- Adding the design keyword since this is partly a visual design change. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12509] Add a CSS class to target IP user pages
https://bugzilla.wikimedia.org/show_bug.cgi?id=12509 Happy-melon happy-me...@live.com changed: What|Removed |Added Blocks||22771 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
