[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-10-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453


Bug 13453 depends on bug 18291, which changed state.

Bug 18291 Summary: rebuildrecentchanges zaps all deletions due to looking in 
wrong table
https://bugzilla.wikimedia.org/show_bug.cgi?id=18291

   What|Old Value   |New Value

 Status|REOPENED|RESOLVED
 Resolution||FIXED



-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-10-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453


OverlordQ overlo...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Comment #10 from OverlordQ overlo...@gmail.com  2009-10-28 18:24:35 UTC 
---
Fixed in r58269


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453


Roan Kattouw roan.katt...@gmail.com changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com




--- Comment #7 from Roan Kattouw roan.katt...@gmail.com  2009-06-30 10:51:03 
UTC ---
(In reply to comment #6)
 Seems to be r49112 that causes this.  
 
 'rc_cur_id' = 'COALESCE(page_id, 0)'
 
 was there a problem with that field being NULL vs 0?
 

Has to be I guess, but it seems weird to me because we use 0 in this role in a
lot of other places as well (e.g. rev_user, which is either a valid user_id or
0). Is there even any benefit from adding these relations between tables in the
postgres schema? The MySQL schema doesn't have them.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453





--- Comment #8 from OverlordQ overlo...@gmail.com  2009-06-30 11:30:23 UTC ---
The benefit is getting warnings like this that your software is trying to
insert data that doesn't make sense. Without strict mode MySQL is known to do
some really silly things when inserting data and foreign keys would catch that.

The hackish way would be to create a stub page like is done for anonymous users
and user_id 0 but that would likely do odd things elsewhere. 

I guess without doing something strange like splitting up the log table into
actions against pages and actions against users, would be to drop the
constraint.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453





--- Comment #9 from Roan Kattouw roan.katt...@gmail.com  2009-06-30 19:09:25 
UTC ---
(In reply to comment #8)
 The benefit is getting warnings like this that your software is trying to
 insert data that doesn't make sense.
That's not true. rc_cur_id=0 DOES make sense, it has a well-defined meaning.
PostgreSQL should not try to enforce its conception of what makes sense over
MW's. For that reason, the constraint should be dropped IMO, as you suggest.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453


jida...@jidanni.org changed:

   What|Removed |Added

 Depends on||18291




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453


OverlordQ overlo...@gmail.com changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |
Version|1.13-svn|1.16-svn




--- Comment #4 from OverlordQ overlo...@gmail.com  2009-06-17 04:59:48 UTC ---
This seems to have regressed to being broken again.

I'll attach the output


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453





--- Comment #5 from OverlordQ overlo...@gmail.com  2009-06-17 05:00:56 UTC ---
Created an attachment (id=6234)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=6234)
Backtract + output


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 13453] rebuildrecentchanges broken on PostgreSQL

2009-06-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=13453





--- Comment #6 from OverlordQ overlo...@gmail.com  2009-06-17 05:08:25 UTC ---
Seems to be r49112 that causes this.  

'rc_cur_id' = 'COALESCE(page_id, 0)'

was there a problem with that field being NULL vs 0?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l