[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Andre Klapper  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from Andre Klapper  ---
Alright :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #24 from Ariel T. Glenn  ---
oops, I didn't mean to re-open. just to add myself. sorry! do what you need to
do...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #23 from Andre Klapper  ---
Ariel: You silently reopened this - could you add a comment, e.g. how often /
where this still can be seen? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Aaron Schulz  changed:

   What|Removed |Added

   Assignee|aschulz4...@gmail.com   |wikibugs-l@lists.wikimedia.
   ||org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Ariel T. Glenn  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||ar...@wikimedia.org
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Aaron Schulz  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #22 from MZMcBride  ---
Related: . Tim thinks this should help
with about 80% of the problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Rob Lanphier  changed:

   What|Removed |Added

   Assignee|ro...@wikimedia.org |aschulz4...@gmail.com

--- Comment #21 from Rob Lanphier  ---
Giving this to AaronSchulz to look at.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Andre Klapper  changed:

   What|Removed |Added

   Keywords||platformeng
 CC||g...@wikimedia.org
Version|1.13.x  |1.22-git

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Tim Starling  changed:

   What|Removed |Added

   Assignee|tstarl...@wikimedia.org |ro...@wikimedia.org

--- Comment #20 from Tim Starling  ---
What makes this tricky is the use of the $commit=false parameter to
doDeleteArticleReal() by FileDeleteForm to attempt to roll back everything when
a FileBackend operation fails. Of course, you can't unpurge Squid or unsend an
IRC log line, but at least it does make an effort. 

Moving things like squid purges and links updates to a DeferredUpdates job
would be easy if it wasn't for this. You can't unqueue a DeferredUpdates job at
present. Maybe you could clear the queue or somehow identify invalid jobs, but
it would be pretty messy and heuristic. The use of onTransactionIdle() would
suffer similar problems.

Ideally, WikiPage::doDeleteArticleReal() would be split up into a pre-commit
function and a post-commit function, and FileDeleteForm would call the
post-commit function after the file operations are successful.

WikiPage::doDeleteArticleReal() itself would continue to do both halves, for
backwards compatibility, which would be fairly convenient in the short term
since ApiDelete and maintenance/deleteBatch.php could continue to call it. But
in the long term, those two callers would be best served by a new entry point
that treated file and non-file deletions equivalently.

Assigning to Rob Lanphier for delegation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #19 from Tim Starling  ---
The transaction length is certainly epic. Here's an indicative debug log trace
from my local test wiki, just showing the transaction in question, annotated
with hook calls:

http://paste.tstarling.com/p/spMggU.html

35 DB queries, 59 hook calls, 4 squid purges and some FileBackend operations.
It's not hard to imagine something in there being slow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #18 from Tim Starling  ---
Created attachment 12105
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=12105&action=edit
Exception rate time series

Rate of exceptions with WikiPage->doDeleteUpdates in the backtrace. Clearly
something new is going on, possibly correlated with deployment of MW 1.21wmf11
to commonswiki.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Tim Starling  changed:

   What|Removed |Added

   Priority|Low |High
 CC||tstarl...@wikimedia.org
   Assignee|wikibugs-l@lists.wikimedia. |tstarl...@wikimedia.org
   |org |

--- Comment #17 from Tim Starling  ---
Log analysis and frequent reports on bug 46086 indicate that this has been
happening more often since 1.21wmf11 was deployed. So, increasing priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Tim Starling  changed:

   What|Removed |Added

 CC||rainerril...@hotmail.com

--- Comment #16 from Tim Starling  ---
*** Bug 46086 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Rainer Rillke @commons.wikimedia  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=46086

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

MZMcBride  changed:

   What|Removed |Added

 CC||b...@mzmcbride.com

--- Comment #15 from MZMcBride  ---
There's a report of updateCategoryCounts erroring here:

https://en.wikipedia.org/w/index.php?title=User_talk:MZMcBride&oldid=550337699#Bug_46086

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #14 from Aaron Schulz  ---
(In reply to comment #13)
> Adding to comment 12: Two more methods the deadlock was reported in:
> 
> * WikiPage::updateCategoryCounts
> * HTMLCacheUpdate::invalidateTitles

These are the only two I'm still seeing in the logs a lot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #13 from Siebrand  2012-01-06 11:52:45 UTC ---
Adding to comment 12: Two more methods the deadlock was reported in:

* WikiPage::updateCategoryCounts
* HTMLCacheUpdate::invalidateTitles

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #12 from Siebrand  2012-01-06 11:44:30 UTC ---
Just now I came across this again. Slightly different scenario -- mass deleting
empty categories on Wikimedia Commons:

“RecentChange::save”: “1213: Deadlock found when trying to get lock; try
restarting transaction (10.0.6.32)”.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Carl Fürstenberg  changed:

   What|Removed |Added

 CC||azat...@gmail.com

--- Comment #11 from Carl Fürstenberg  2011-05-24 22:19:37 
UTC ---
When updating twinkle to api now, I'm getting database query errors a lot (10
in a minute depending on the amount being processed) which seems to be related
to this:



#0 /usr/local/apache/common-local/php-1.17/includes/db/Database.php(734):
DatabaseBase->reportQueryError('Deadlock found ...', 1213, 'UPDATE  `page`
...', 'Title::invalida...', false)
#1 /usr/local/apache/common-local/php-1.17/includes/db/Database.php(1349):
DatabaseBase->query('UPDATE  `page` ...', 'Title::invalida...')
#2 /usr/local/apache/common-local/php-1.17/includes/Title.php(2485):
DatabaseBase->update('page', Array, Array, 'Title::invalida...')
#3 /usr/local/apache/common-local/php-1.17/includes/Article.php(4093):
Title->invalidateCache()
#4 /usr/local/apache/common-local/php-1.17/includes/Article.php(3271):
Article::onArticleDelete(Object(Title))
#5 /usr/local/apache/common-local/php-1.17/includes/api/ApiDelete.php(154):
Article->doDeleteArticle('Deleted talk pa...')
#6 /usr/local/apache/common-local/php-1.17/includes/api/ApiDelete.php(79):
ApiDelete::delete(Object(Article), 'a0b48ef8649b3b5...', 'Deleted talk pa...')
#7 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(657):
ApiDelete->execute()
#8 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(339):
ApiMain->executeAction()
#9 /usr/local/apache/common-local/php-1.17/includes/api/ApiMain.php(323):
ApiMain->executeActionWithErrorHandling()
#10 /usr/local/apache/common-local/php-1.17/api.php(115): ApiMain->execute()
#11 /usr/local/apache/common-local/live-1.5/api.php(3):
require('/usr/local/apac...')
#12 {main}



-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #10 from Siebrand  2011-05-17 15:09:56 UTC ---
(In reply to comment #5)
> Is still still reproducible?

As said, I haven't tried with images, but I just reproduced it mass deleting
pages in the MediaWiki namespace on nl.wikimedia.org (1.17wmf1 (r88299)). The
error thrown came from  RecentChange::save and was:

1213: Deadlock found when trying to get lock; try restarting transaction
(10.0.6.49)”.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Reedy  changed:

   What|Removed |Added

 Blocks||28599

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Reedy  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #9 from Reedy  2011-04-11 18:46:45 UTC ---
Reverted in r85814

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Reedy  changed:

   What|Removed |Added

 Blocks||28499

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Reedy  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||s...@reedyboy.net
 Resolution||FIXED

--- Comment #8 from Reedy  2011-04-11 13:08:10 UTC ---
r85785

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

--- Comment #7 from Siebrand  2011-03-22 07:02:15 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > Is still still reproducible?
> 
> I don't do any mass deletions anymore at Commons, but let me quickly check if
> there are enough speedy deletion tags at the moment to give it a try.

Cannot reproduce.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Siebrand  changed:

   What|Removed |Added

 CC||s.mazel...@xs4all.nl

--- Comment #6 from Siebrand  2011-03-22 06:58:32 UTC ---
(In reply to comment #5)
> Is still still reproducible?

I don't do any mass deletions anymore at Commons, but let me quickly check if
there are enough speedy deletion tags at the moment to give it a try.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921

Chad H.  changed:

   What|Removed |Added

 CC||innocentkil...@gmail.com

--- Comment #5 from Chad H.  2011-03-22 01:58:16 UTC 
---
Is still still reproducible?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 13921] deadlocks mass-deleting media files in categories

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=13921


Aryeh Gregor  changed:

   What|Removed |Added

 CC||simetrical+wikib...@gmail.co
   ||m




--- Comment #4 from Aryeh Gregor   2009-02-16 
18:03:47 UTC ---
Ugh, I hate databases.  :(


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l