[Bug 14925] Refactor upload code to split backend and interface
https://bugzilla.wikimedia.org/show_bug.cgi?id=14925 Bug 14925 depends on bug 18563, which changed state. Bug 18563 Summary: Merge new-upload branch (tracking) https://bugzilla.wikimedia.org/show_bug.cgi?id=18563 What|Old Value |New Value Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14925] Refactor upload code to split backend and interface
https://bugzilla.wikimedia.org/show_bug.cgi?id=14925 Chad H. innocentkil...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #13 from Chad H. innocentkil...@gmail.com 2009-07-23 02:49:15 UTC --- New-upload was merged to trunk, this is fixed there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14925] Refactor upload code to split backend and interface
https://bugzilla.wikimedia.org/show_bug.cgi?id=14925 ^demon innocentkil...@gmail.com changed: What|Removed |Added CC||innocentkil...@gmail.com Depends on||18563 --- Comment #12 from ^demon innocentkil...@gmail.com 2009-07-01 01:18:48 UTC --- Adding this as a blocker to 18563. This has been done in the new-upload branch and will become a part of core when that gets merged. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14925] Refactor upload code to split backend and interface
https://bugzilla.wikimedia.org/show_bug.cgi?id=14925 --- Comment #10 from Roan Kattouw roan.katt...@home.nl 2008-12-16 21:12:32 UTC --- (In reply to comment #9) Tagging as need-review; calling on Tim to review this and see if it addresses the issues he brought up. Bump. This is needed for a pretty major feature (API upload), and has been waiting to be reviewed for nearly 3 months now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 14925] Refactor upload code to split backend and interface
https://bugzilla.wikimedia.org/show_bug.cgi?id=14925 --- Comment #11 from Tim Starling tstarl...@wikimedia.org 2008-12-17 04:45:28 UTC --- * Update the patch and Upload*.php, needs to incorporate SpecialUpload.php changes between r41253 and r44701 * UploadForm::internalProcessUpload() has too much boilerplate, which would have to be reproduced in each new UI component. I suggest merging verifyPermissions(), fetchFile(), verifyUpload(), checkWarnings(), performUpload() and cleanupTempFile() into a single function. It should accept an associative array as its parameter, with members such as initial page text, ignore warnings, comment and user. Preferably it would return a Status object. * Get rid of the UploadBase status constants, they're not extensible. Use message names for status codes. You can wrap them in Status objects where convenient. * Fix the UploadBase::BEFORE_PROCESSING case in processUpload() * Fix stupid comment It will show an error form on failure. No it will not. * Rename UploadFromStash to UploadFromSession, document it to the point where ordinary humans might be able to work out how to use it. Rename stashSession() to createSession(), rename unsaveUploadedFile() to destroySession(). Document UploadFromSession::initialize(). Document the fact that these three functions go together. * Suggest renaming UploadFromUpload to something less vague, maybe UploadFromWebForm * Upload handlers. Should probably just be a global -- indeed it should, then it would be extensible. But the global should allow for arbitrary class names, instead of prepending UploadFrom, so that extensions can maintain a naming scheme where class names start with the name of the extension. * Document all functions, including parameter definitions, with an extension writer audience in mind. It won't take long. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
