[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Keywords||patch-in-gerrit --- Comment #33 from Matthew Flaschen mflasc...@wikimedia.org --- Alright, I'm making another go at this (https://gerrit.wikimedia.org/r/#/c/38915/). It's a simpler implementation, leveraging jQuery UI and the existing code. It doesn't interfere with the submit handling (cloning forms and such), because I think that handles some deletion buttons this doesn't. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Isarra zhoris...@gmail.com changed: What|Removed |Added CC||zhoris...@gmail.com --- Comment #34 from Isarra zhoris...@gmail.com --- This request presents a serious design issue. History pages are confusing and link-covered enough as it is. Adding a javascript workaround to remove some of the differentiation between components is not going to help matters when, for the user, the only thing attaching these buttons to their selections is the fact that they are visibly buttons. There is no other visible mapping between them at present, not positional nor in terms of style, and the entire history page layout would need to be reworked before a more proper solution would be viable. Lacking that, however, such a change as this does not belong in core. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 --- Comment #35 from Matthew Flaschen mflasc...@wikimedia.org --- Created attachment 11522 -- https://bugzilla.wikimedia.org/attachment.cgi?id=11522action=edit Screenshot of new compare button -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Attachment #5511|0 |1 is obsolete|| --- Comment #30 from Sumana Harihareswara suma...@panix.com 2011-11-25 02:58:21 UTC --- Comment on attachment 5511 -- https://bugzilla.wikimedia.org/attachment.cgi?id=5511 Fix infinite loop bug, add support for HTML diffs, tweak style and make implementation neater No longer applies cleanly to trunk; obsolete per automated testing by Rusty, http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Attachment #5512|0 |1 is obsolete|| --- Comment #31 from Sumana Harihareswara suma...@panix.com 2011-11-25 02:58:44 UTC --- Comment on attachment 5512 -- https://bugzilla.wikimedia.org/attachment.cgi?id=5512 With lighter button color No longer applies cleanly to trunk; obsolete per automated testing by Rusty, http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added Keywords|need-review, patch | CC||suma...@panix.com --- Comment #32 from Sumana Harihareswara suma...@panix.com 2011-11-25 03:02:44 UTC --- Matthew, I'm sorry for the wait. As you can see in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047 there was some code review of the patch and it ended up being reverted due to issues that some developers raised. If you have the time and the interest to revisit the issue, we'd welcome discussion in the #mediawiki channel on freenode IRC -- that might be a good place to discuss approach. Thank you for your contribution and again, sorry for the wait. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 --- Comment #29 from DieBuche diebu...@gmail.com 2011-07-06 12:35:42 UTC --- Reverted in r91547; to be reapplied later -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 DieBuche diebu...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 DieBuche diebu...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||diebu...@gmail.com Resolution||FIXED --- Comment #28 from DieBuche diebu...@gmail.com 2011-04-14 13:20:29 UTC --- Fixed in r86047 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 mybugs.m...@gmail.com changed: What|Removed |Added CC||mybugs.m...@gmail.com -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch changed: What|Removed |Added CC||mhorvath2...@juno.com --- Comment #27 from Alexandre Emsenhuber [IAlex] alex.emsenhu...@bluewin.ch 2010-03-29 14:57:16 UTC --- *** Bug 22997 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 --- Comment #25 from Matthew Flaschen matthew.flasc...@gatech.edu 2009-07-09 08:49:42 UTC --- Sure, Mike. However, looking at Wikipedia history pages, I don't see a second button yet. Also, I haven't heard any reaction to attachment 5512. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 --- Comment #26 from Mike.lifeguard mike.lifegu...@gmail.com 2009-07-09 19:31:35 UTC --- (In reply to comment #25) Sure, Mike. However, looking at Wikipedia history pages, I don't see a second button yet. Also, I haven't heard any reaction to attachment 5512 [details]. Yes, as I said, Wikimedia doesn't use html diff. But the patch still needs to change that to a link if the wiki is configured appropriately. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 16165] Compare selected versions, show/hide, and visual/html diff should be links, not buttons
https://bugzilla.wikimedia.org/show_bug.cgi?id=16165 Mike.lifeguard mike.lifegu...@gmail.com changed: What|Removed |Added Summary|Compare selected versions |Compare selected versions, |and show/hide should be |show/hide, and visual/html |links, not buttons |diff should be links, not ||buttons --- Comment #24 from Mike.lifeguard mike.lifegu...@gmail.com 2009-07-08 14:51:11 UTC --- Actually, there are three. HTML diff isn't used on Wikimedia, but it should be a link too. That's one main fault with the patch I submitted earlier, since I didn't know that button existed at all. Matthew, are you still interested in implementing this? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
