[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 Andrew Garrett changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #10 from Andrew Garrett 2009-09-18 13:01:53 UTC --- (In reply to comment #9) > I've just removed my abuse-filter-editor permission and find I can't view > private filters now. That's because it hasn't been given to administrators on any wikis yet. If you want to give it to administrators on a particular wiki, please file a site request bug saying so. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 xenocidic changed: What|Removed |Added CC||xenow...@gmail.com Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #9 from xenocidic 2009-09-18 13:00:55 UTC --- I've just removed my abuse-filter-editor permission and find I can't view private filters now. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 Andrew Garrett changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Andrew Garrett 2009-07-03 14:17:29 UTC --- Committed with adjustments in r52743. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 Cenarium changed: What|Removed |Added CC||cenarium.sy...@gmail.com --- Comment #7 from Cenarium 2009-06-30 21:29:47 UTC --- Per the discussion at [[Wikipedia talk:Abuse filter#Adding abuse-filter-view-private into sysop package]], we would like this permission into the sysop package, but no separate user group. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 Haza-w changed: What|Removed |Added Attachment #6255 is|0 |1 obsolete|| --- Comment #6 from Haza-w 2009-06-30 21:08:59 UTC --- Created an attachment (id=6288) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6288) abusefilter-view-private user right Created canView function and changed the static variable declaration slightly. I'm assuming this works... perhaps someone could test it? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 --- Comment #5 from Andrew Garrett 2009-06-23 12:45:30 UTC --- (In reply to comment #4) > Apologies for making such a mess of the attachment... Bugzilla and I are still > not quite acquainted! > > This is a second version of the patch – I suddenly realised that I hadn't > added any language variables for the new user right. > Since we're both online at the same time, it might make sense for you to drop into #mediawiki and I'll do a live review with you. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362 --- Comment #4 from Haza-w 2009-06-23 12:44:12 UTC --- Created an attachment (id=6255) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6255) abusefilter-view-private user right, added English language variables Apologies for making such a mess of the attachment... Bugzilla and I are still not quite acquainted! This is a second version of the patch – I suddenly realised that I hadn't added any language variables for the new user right. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362
--- Comment #3 from Andrew Garrett 2009-06-23
12:41:03 UTC ---
- if (isset($row->af_hidden) && $row->af_hidden &&
!$this->canEdit()) {
+ if (isset($row->af_hidden) && $row->af_hidden &&
!($this->canEdit() || $wgUser->isAllowed( 'abusefilter view-private' ))) {
Would prefer that this was broken out to a canView() method, instead of hacked
in here.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362
Haza-w changed:
What|Removed |Added
Attachment #6254 is|0 |1
obsolete||
--- Comment #2 from Haza-w 2009-06-23 12:39:05 UTC ---
(From update of attachment 6254)
>Index: AbuseFilter/AbuseFilter.php
>===
>--- AbuseFilter/AbuseFilter.php(revision 52305)
>+++ AbuseFilter/AbuseFilter.php(working copy)
>@@ -78,6 +78,7 @@
> $wgAvailableRights[] = 'abusefilter-private';
> $wgAvailableRights[] = 'abusefilter-modify-restricted';
> $wgAvailableRights[] = 'abusefilter-revert';
>+$wgAvailableRights[] = 'abusefilter-view-private';
>
> $wgLogTypes[] = 'abusefilter';
> $wgLogNames['abusefilter'] = 'abusefilter-log-name';
>Index: AbuseFilter/Views/AbuseFilterViewEdit.php
>===
>--- AbuseFilter/Views/AbuseFilterViewEdit.php (revision 52305)
>+++ AbuseFilter/Views/AbuseFilterViewEdit.php (working copy)
>@@ -220,7 +220,7 @@
> $wgOut->setSubtitle( wfMsg( 'abusefilter-edit-subtitle',
> $filter, $history_id ) );
>
> // Hide hidden filters.
>- if (isset($row->af_hidden) && $row->af_hidden &&
>!$this->canEdit()) {
>+ if (isset($row->af_hidden) && $row->af_hidden &&
>!($this->canEdit() || $wgUser->isAllowed( 'abusefilter-view-private' ))) {
> return wfMsg( 'abusefilter-edit-denied' );
> }
>
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19362] New user permission abusefilter-viewprivate
https://bugzilla.wikimedia.org/show_bug.cgi?id=19362
--- Comment #1 from Haza-w 2009-06-23 12:38:09 UTC ---
(From update of attachment 6254)
Index: AbuseFilter/AbuseFilter.php
===
--- AbuseFilter/AbuseFilter.php (revision 52305)
+++ AbuseFilter/AbuseFilter.php (working copy)
@@ -78,6 +78,7 @@
$wgAvailableRights[] = 'abusefilter-private';
$wgAvailableRights[] = 'abusefilter-modify-restricted';
$wgAvailableRights[] = 'abusefilter-revert';
+$wgAvailableRights[] = 'abusefilter-view-private';
$wgLogTypes[] = 'abusefilter';
$wgLogNames['abusefilter'] = 'abusefilter-log-name';
Index: AbuseFilter/Views/AbuseFilterViewEdit.php
===
--- AbuseFilter/Views/AbuseFilterViewEdit.php (revision 52305)
+++ AbuseFilter/Views/AbuseFilterViewEdit.php (working copy)
@@ -220,7 +220,7 @@
$wgOut->setSubtitle( wfMsg( 'abusefilter-edit-subtitle',
$filter, $history_id ) );
// Hide hidden filters.
- if (isset($row->af_hidden) && $row->af_hidden &&
!$this->canEdit()) {
+ if (isset($row->af_hidden) && $row->af_hidden &&
!($this->canEdit() || $wgUser->isAllowed( 'abusefilter-view-private' ))) {
return wfMsg( 'abusefilter-edit-denied' );
}
Index: AbuseFilter/AbuseFilter.i18n.php
===
--- AbuseFilter/AbuseFilter.i18n.php(revision 52305)
+++ AbuseFilter/AbuseFilter.i18n.php(working copy)
@@ -61,6 +61,7 @@
'right-abusefilter-private' => 'View private data in the abuse log',
'right-abusefilter-modify-restricted' => 'Modify abuse filters with
restricted actions',
'right-abusefilter-revert' => 'Revert all changes by a given abuse
filter',
+ 'right-abusefilter-view-private' => 'View abuse filters marked as
private',
'action-abusefilter-modify' => 'modify abuse filters',
'action-abusefilter-view' => 'view abuse filters',
@@ -69,6 +70,7 @@
'action-abusefilter-private' => 'view private data in the abuse log',
'action-abusefilter-modify-restricted' => 'modify abuse filters with
restricted actions',
'action-abusefilter-revert' => 'revert all changes by a given abuse
filter',
+ 'action-abuserfilter-view-private' => 'view abuse filters marked as
private',
// Abuse Log
'abusefilter-log' => 'Abuse filter log',
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
