[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Alex Monk changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #13 from Alex Monk --- Sounds resolved to me. Marking as such. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Andre Klapper changed: What|Removed |Added CC||aklap...@wikimedia.org --- Comment #12 from Andre Klapper --- All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Helder changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=68783 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 --- Comment #11 from Gerrit Notification Bot --- Change 54317 merged by jenkins-bot: Final page of search results sometimes having erroneous "next" link https://gerrit.wikimedia.org/r/54317 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Andre Klapper changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=57414 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 --- Comment #10 from Gerrit Notification Bot --- Change 54317 had a related patch set uploaded by Nemo bis: Fix for Bug 19938 (final page of search results sometimes having erroneous "next" link) https://gerrit.wikimedia.org/r/54317 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Andre Klapper changed: What|Removed |Added Keywords|patch-in-gerrit | Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Andre Klapper changed: What|Removed |Added CC||fole...@netcourrier.com --- Comment #9 from Andre Klapper --- *** Bug 30163 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Alex Monk (Krenair) changed: What|Removed |Added Status|NEW |ASSIGNED CC||kren...@gmail.com Assignee|wikibugs-l@lists.wikimedia. |dile...@gmail.com |org | --- Comment #8 from Alex Monk (Krenair) --- (In reply to comment #7) > Your patch seems to be correct. Don't know why, the bug is still showing > 'NEW'. Assigned to Dylan Lexie. New accounts don't have the ability to modify bug statuses like that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Gaurav Chawla changed: What|Removed |Added CC||grvi...@gmail.com --- Comment #7 from Gaurav Chawla --- Your patch seems to be correct. Don't know why, the bug is still showing 'NEW'. But, since its open, I would like to give an alternate solution. In SpecialSearch.php, replace "max( $titleMatchesNum, $textMatchesNum ) < $this->limit" by "max( $titleMatchesNum, $textMatchesNum ) < $this->limit || $totalRes == $this->limit + $this->offset" -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Michelle Lee Kosik changed: What|Removed |Added CC||kosi...@mail.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Valerie Juarez changed: What|Removed |Added Keywords||patch-in-gerrit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Dylan Lexie changed: What|Removed |Added CC||dile...@gmail.com --- Comment #6 from Dylan Lexie --- gerrit Ic30586e217fbde4b9d0aeda277a77030c4dce216 https://gerrit.wikimedia.org/r/#/c/54317/ Essentially follows Roan Kattouw's suggestion. (Sorry about the long lines in the commit message. This is my first experience with Gerrit and I didn't anticipate a non-wrapping display.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Valerie Juarez changed: What|Removed |Added Assignee|tpars...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org --- Comment #5 from Valerie Juarez --- Going to assign to 'Nobody'. Having this already assigned to Trevor may deter someone from taking this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Sumana Harihareswara changed: What|Removed |Added Keywords||easy --- Comment #4 from Sumana Harihareswara --- I predict that this is relatively easy to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Valerie Juarez changed: What|Removed |Added CC||valerie.m.jua...@gmail.com Version|1.16.x |1.21-git --- Comment #3 from Valerie Juarez --- This issue still persists. There are 11,750 articles containing the word "hunger". This is divisible by 50 and 250. This is the last page of results - http://en.wikipedia.org/w/index.php?title=Special:Search&limit=250&offset=11500&redirs=1&profile=default&search=hunger If you scroll all the way down that page and select "next 250", the next page has the message "There were no results matching the query." -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Roan Kattouw changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #2 from Roan Kattouw 2009-07-27 21:45:19 UTC --- Should probably just pull $limit+1 results and only show the (next) link if the $limit+1'th result is actually there. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19938] last search results page contains next page link if result count is multiple of limit
https://bugzilla.wikimedia.org/show_bug.cgi?id=19938 Brion Vibber changed: What|Removed |Added CC||br...@wikimedia.org AssignedTo|wikibugs- |tpars...@wikimedia.org |l...@lists.wikimedia.org | --- Comment #1 from Brion Vibber 2009-07-27 17:18:12 UTC --- Assigning to Trevor -- search UI fixups. (Note this should be easier to test locally now if you enable $wgSearchMySQLTotalHits (or fudge the #s in the class temporarily) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
