[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2011-11-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

--- Comment #9 from Gadget850 ed.pal...@gmail.com 2011-11-10 13:18:22 UTC ---
Now implemented on en.wiki.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2011-11-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

--- Comment #8 from Gadget850 ed.pal...@gmail.com 2011-11-10 10:30:25 UTC ---
That works. See test at 

http://test.wikipedia.org/wiki/User:Gadget850/Ordered_lists_in_references

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2011-11-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Erwin Dokter er...@darcoury.nl changed:

   What|Removed |Added

 CC||er...@darcoury.nl

--- Comment #10 from Erwin Dokter er...@darcoury.nl 2011-11-10 18:54:27 UTC 
---
Yes, but better is to fix this in cite.php. If a linebreak is all that is
needed, I'll see if I can come up with a patch.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2011-11-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

--- Comment #11 from Erwin Dokter er...@darcoury.nl 2011-11-10 19:04:34 UTC 
---
PHP is a little out of my league, but somewhere in function
referencesFormatEntry in Cite_body.php, a \n needs to be inserted.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2011-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Brad Jorsch b-jor...@alum.northwestern.edu changed:

   What|Removed |Added

 CC||b-jorsch@alum.northwestern.
   ||edu

--- Comment #7 from Brad Jorsch b-jor...@alum.northwestern.edu 2011-11-09 
22:05:29 UTC ---
This has little to do with Cite. It's mostly the parser being simplistic
combined with Tidy making a bad fix.

As far as Cite is concerned, the ref with the embedded list gets expanded to
wikitext something like this:

LI id=cite_note-0[[#cite_ref-0|↑]] This is a reference with a numbered
list
# line 1
# line 2
# line 3— no newline/LI

I've capitalized the li/li tags to make the next step clearer.

That gets handed to the parser, which doesn't pay any attention to the HTML.
doBlockLevels just blindly converts the wiki-list by inserting olli in
place of the # for the first element, /lili in place of the # for all
subsequent elements, and /li/ol after the last list element. The /LI
from Cite winds up inside the last list element:

LI id=cite_note-0a href=#cite_ref-0↑/a This is a reference with a
numbered list
olli line 1
/lili line 2
/lili line 3— no newline/LI
/li/ol

Tidy apparently decides that the last /li is closing the LI and inserts a
missing /ol, and then the real /ol is interpreted as closing the
reference's list. And then the li for the next reference gets a missing
ul inserted before it. A browser given this tag soup might do the same, or it
might decide that last /li is extraneous and then insert the missing /li
when it sees the li for the next ref.

The reason it works with the newline is because the /LI is then after the
list instead of inside the last element, so when the parser inserts its
/li/ol it winds up before the /LI and everything is correct.

We ''could'' work around this in Cite by changing
[[MediaWiki:cite_references_link_one]] and
[[MediaWiki:cite_references_link_many]] to have a newline before the /li, or
we could insert a newline at the end of the string passed as $3 to these
messages.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Happy-melon happy-me...@live.com changed:

   What|Removed |Added

 CC||happy-me...@live.com

--- Comment #4 from Happy-melon happy-me...@live.com 2010-05-24 19:29:08 UTC 
---
Confirmed as a(nother) bad interaction with Tidy; unTidy'd output is correct.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Happy-melon happy-me...@live.com changed:

   What|Removed |Added

 Blocks||2542

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Gadget850 ed.pal...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #5 from Gadget850 ed.pal...@gmail.com 2010-05-24 20:03:10 UTC ---
Guess we can close this and track it at Bug 2542 as a Tidy issue.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |

--- Comment #6 from Platonides platoni...@gmail.com 2010-05-24 20:04:26 UTC 
---
 Confirmed as a(nother) bad interaction with Tidy; unTidy'd output is correct.

It is not correct, or Tidy wouldn't need to fix us.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Gadget850 ed.pal...@gmail.com changed:

   What|Removed |Added

 CC||ed.pal...@gmail.com

--- Comment #2 from Gadget850 ed.pal...@gmail.com 2010-05-22 12:09:33 UTC ---
http://en.wikipedia.org/wiki/Help:Cite_errors/Testcases7

Nesting an ordered list inside another ordered list. Not terminating with a
newline causes the rest of the list to be wrapped in an unordered list. I would
not be surprised if this was an interaction with HTML Tidy.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 20050] Reference with numbered list inside can spoil later ref rendering

2010-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=20050

Platonides platoni...@gmail.com changed:

   What|Removed |Added

 CC||platoni...@gmail.com

--- Comment #3 from Platonides platoni...@gmail.com 2010-05-22 12:18:25 UTC 
---
You are right. The ul is caused by Tidy. MediaWiki outputs /li/ol instead
of /ol/li, and Tidy tries to fix it by opening a ul.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l