[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 Max Semenik changed: What|Removed |Added Status|NEW |RESOLVED CC||maxsem.w...@gmail.com Resolution|--- |WONTFIX --- Comment #9 from Max Semenik --- RIP CodeReview. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069
Roan Kattouw changed:
What|Removed |Added
CC||roan.katt...@gmail.com
--- Comment #8 from Roan Kattouw 2010-12-07 16:10:11
UTC ---
(In reply to comment #7)
> find \( -name \*.php -or -name \*.inc \) -exec php -l \{\} \; | grep -v "No
> syntax errors detected"
I branched REL1_17 today, which caused the pre-commit hook to syntax-check a
full copy of /trunk/phase3 and /trunk/extensions , which succeeded.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069
Platonides changed:
What|Removed |Added
CC||platoni...@gmail.com
--- Comment #7 from Platonides 2010-12-05 15:31:51 UTC
---
Comment #5 is trivially fixed by ensuring we have no files with syntax errors.
We no longer have anyone in the whole trunk. There used to be one added on
purpose in NamespaceCompat.php but it was removed in r70693.
find \( -name \*.php -or -name \*.inc \) -exec php -l \{\} \; | grep -v "No
syntax errors detected"
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 --- Comment #6 from Reedy 2010-12-05 14:45:45 UTC --- Any idea what we should do with this now, as we've got php -l pre commit? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 Bug 20069 depends on bug 25940, which changed state. Bug 25940 Summary: Add API module(s) to add comments/set revision status https://bugzilla.wikimedia.org/show_bug.cgi?id=25940 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 --- Comment #5 from Reedy 2010-11-17 20:05:07 UTC --- As a thing to this, we shouldn't blame users for syntax errors if they already exist on the file pre commit... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 20069] Implement PHP syntax validity (as SVN post commit hook)
https://bugzilla.wikimedia.org/show_bug.cgi?id=20069 Reedy changed: What|Removed |Added Depends on||25940 Summary|Implement PHP syntax|Implement PHP syntax |validity checking to upload |validity (as SVN post |results to CodeReview tests |commit hook) --- Comment #4 from Reedy 2010-11-15 21:49:22 UTC --- Retitling and adding dependancy Post commit hook, pinging CR and setting fixme would be great -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
